From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kLkHO7AtoV+oBgAA0tVLHw (envelope-from ) for ; Tue, 03 Nov 2020 10:15:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id qAr9NrAtoV/BOQAA1q6Kng (envelope-from ) for ; Tue, 03 Nov 2020 10:15:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 734AD940416 for ; Tue, 3 Nov 2020 10:15:12 +0000 (UTC) Received: from localhost ([::1]:55310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZtLJ-0000Zs-OE for larch@yhetil.org; Tue, 03 Nov 2020 05:15:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZtLC-0000ZV-Nv for guix-patches@gnu.org; Tue, 03 Nov 2020 05:15:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60165) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZtLC-0005fd-Cq for guix-patches@gnu.org; Tue, 03 Nov 2020 05:15:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZtLC-0001GY-5u for guix-patches@gnu.org; Tue, 03 Nov 2020 05:15:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44191] gnu: Add kristall Resent-From: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 03 Nov 2020 10:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44191 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Christopher Baines Cc: 44191@debbugs.gnu.org, nicolo@nixo.xyz Received: via spool by 44191-submit@debbugs.gnu.org id=B44191.16043984614804 (code B ref 44191); Tue, 03 Nov 2020 10:15:02 +0000 Received: (at 44191) by debbugs.gnu.org; 3 Nov 2020 10:14:21 +0000 Received: from localhost ([127.0.0.1]:43478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZtKW-0001FQ-PP for submit@debbugs.gnu.org; Tue, 03 Nov 2020 05:14:21 -0500 Received: from mail-wm1-f41.google.com ([209.85.128.41]:40441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZtKU-0001FA-5x for 44191@debbugs.gnu.org; Tue, 03 Nov 2020 05:14:19 -0500 Received: by mail-wm1-f41.google.com with SMTP id k18so12180470wmj.5 for <44191@debbugs.gnu.org>; Tue, 03 Nov 2020 02:14:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=FEMfCPfDgBsZ3kjkxoV3WK6NSP5OmbZ52+5rW0bOPcw=; b=C+aduZaYEBvKcPsWJ0/iw0e0HYVKMIg2w92MjjC7JWJNSB/R82yt8iLWy2gT9GOngD wIKvsH7EOVjs9X8c5DK1vTpaVU0gB1NOKI7ZyPXoFZRxNQN2BXP1jkYike5lxtySqcOH bP2PONp57JbTYqneREWTBJgdC8GS9IkpEZiYx2PeUmB5kNNOskxAYkOt9prXnpVqxnsO pKBkAE8C6OGGuvi/0A0h7X46EQCOTyazr3DaROSDrc6IwILXeICjwnTiet7xJcQfYtB6 5nvQGPkatS4uHwDqHXMdYcefwN4eiZ0Bvc3P5TR2rVhHW8EKiiEtAlHRsxmui54l/aGw hThA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=FEMfCPfDgBsZ3kjkxoV3WK6NSP5OmbZ52+5rW0bOPcw=; b=UAGtCa7BSbXCKc87HyqcZaBHAYet4mbrzvhyGqVMsggt0hR5dKSd1AFK/WaDxC0i5B I31y15MqGcT1DTYHc/FuiCthmamtpW0xDMV9iM3vwvAUECDBINjkrue3mkuH6RNres4m cMpO+Vp8wQ8bqQFdcgmUA8O3svZBHUh/O0lOb5gJXvpx8NmDxp3PKtaHcKVHQ3h/7Oeb 1h+xW0FsbkS7hVXXGSEqRocpU/Ytc6890sYuwsn7oGoRqtvxi6yc5JKgJcK6F1aG6Bl4 5KEyr8+vqxYOYwLlVBkYcNIrqvBoravENl2Rd501PluZOCZTUFvo/Y/6dnlWjD0nJeu6 I+6w== X-Gm-Message-State: AOAM531WfRx/oQNIN/2jWAAr4x5kWqAH7YCL861v3jsUxYtcepHyelOS 1Pk84+CK47et8jda2f8jeJE= X-Google-Smtp-Source: ABdhPJz5ZBkz/lPBY8xE0kx+lKgMsMzt7El6imBVzFxgHfvaWQHyXMrdBL+PF87+g/FguVY9JCtmkA== X-Received: by 2002:a1c:1906:: with SMTP id 6mr2632173wmz.87.1604398452316; Tue, 03 Nov 2020 02:14:12 -0800 (PST) Received: from guixSD (host-87-8-141-238.retail.telecomitalia.it. [87.8.141.238]) by smtp.gmail.com with ESMTPSA id d8sm2270981wmb.11.2020.11.03.02.14.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 02:14:11 -0800 (PST) From: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti In-Reply-To: <87sg9uxhtc.fsf@cbaines.net> References: <8736233h7h.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87o8kqab7i.fsf@cbaines.net> <87tuui1ce2.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87imaxym37.fsf@cbaines.net> <87sga0n9ew.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87o8knn6rm.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87sg9uxhtc.fsf@cbaines.net> Date: Tue, 03 Nov 2020 11:14:10 +0100 Message-ID: <87k0v2ycgd.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=C+aduZaY; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: QrXKEujN2T/2 Hi! Christopher Baines writes: > > Given this is a stylesheet, rather than cmark, I don't think it's a > blocker, although I do think it would be neater to have a package for > it. > Would it be better to at least pass it's origin as an input? #+begin_src scheme ("breeze-stylesheet" ,(origin (method git-fetch) (uri (git-reference (url "https://github.com/Alexhuszagh/BreezeStyleSheets") (commit "2d595a956f8a5f493aa51139a470b768a6d82cce"))) (file-name (git-file-name name version)) (sha256 (base32 "1kvkxkisi3czldnb43ig60l55pi4a3m2a4ixp7krhpf9fc5wp294")))) #+end_src I'm ok with making a package for it, but in that case I'm not sure what to do. I think I'd use the copy-build-system, right? Should the package be hidden? > I've made some more comments below, and I wanted to enquire about > exactly how the fonts are used, but I think this is pretty much ready to > merge. > > I'd maybe use symlink rather than copy file, since you want the fonts to > be used from the respective packages in the store, however, is this just > to satisfy the build system? It looks to me like the XDG_DATA_DIRS > wrapping is probably what'll make the fonts work at runtime (if > anything)? Regarding fonts, I tried removing both from the inputs, and emojis at this page [1] rendered just fine. Should I just remove them from the inputs and let the user install them? The code tries to load them with the relative path: #+begin_src cpp // Provide OpenMoji font for a safe fallback QFontDatabase::addApplicationFont(":/fonts/OpenMoji-Color.ttf"); QFontDatabase::addApplicationFont(":/fonts/NotoColorEmoji.ttf"); #+end_src This function fails silently (The function returns -1 if the font could not be loaded.) and the error code is not checked, so we don't even need to patch kristall source for this. Let me know and thanks again, Nicol=C3=B2 [1] https://unicode.org/Public/emoji/1.0/emoji-data.txt