From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4EitGitUOmDhWwAA0tVLHw (envelope-from ) for ; Sat, 27 Feb 2021 14:16:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id wApvFitUOmB8RgAAB5/wlQ (envelope-from ) for ; Sat, 27 Feb 2021 14:16:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CFB7817A85 for ; Sat, 27 Feb 2021 15:16:10 +0100 (CET) Received: from localhost ([::1]:45184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lG0O9-0004Gm-UL for larch@yhetil.org; Sat, 27 Feb 2021 09:16:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lG0O2-0004Fv-EQ for guix-patches@gnu.org; Sat, 27 Feb 2021 09:16:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60149) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lG0O2-0000u1-6q for guix-patches@gnu.org; Sat, 27 Feb 2021 09:16:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lG0O1-0002Ke-Vw for guix-patches@gnu.org; Sat, 27 Feb 2021 09:16:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46703] [PATCH] gnu: add bmake Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 27 Feb 2021 14:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46703 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 46703@debbugs.gnu.org Cc: qblade@protonmail.com X-Debbugs-Original-To: qblade via Guix-patches via X-Debbugs-Original-Cc: qblade , 46703@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16144353397654 (code B ref -1); Sat, 27 Feb 2021 14:16:01 +0000 Received: (at submit) by debbugs.gnu.org; 27 Feb 2021 14:15:39 +0000 Received: from localhost ([127.0.0.1]:43462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lG0Nf-0001z5-Bw for submit@debbugs.gnu.org; Sat, 27 Feb 2021 09:15:39 -0500 Received: from lists.gnu.org ([209.51.188.17]:45926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lG0Nd-0001wk-6v for submit@debbugs.gnu.org; Sat, 27 Feb 2021 09:15:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lG0Nd-0003u4-0y for guix-patches@gnu.org; Sat, 27 Feb 2021 09:15:37 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:38679) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lG0NX-0000g3-37 for guix-patches@gnu.org; Sat, 27 Feb 2021 09:15:36 -0500 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 0A530240007; Sat, 27 Feb 2021 14:15:26 +0000 (UTC) From: Nicolas Goaziou References: Date: Sat, 27 Feb 2021 15:15:25 +0100 In-Reply-To: (qblade via Guix-patches via's message of "Mon, 22 Feb 2021 06:33:57 +0000") Message-ID: <87k0qt1ts2.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.178.230; envelope-from=mail@nicolasgoaziou.fr; helo=relay10.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1614435370; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=s4B1qFTZ1Nab+REsUJ4OXLxQZ4n8cfrJPG5Dlh3q6lg=; b=R+dUeFL1nVySoHwdwtqdHEveSYPQhp3OCyQ7F68viOQpOiAcSwfQkwTDCmEpOJJBmcKOo1 ZklLbTCmjGl1clUXDsp1Dk1KjAptbAKfBKyYG+q46EWNcMh+UEmtxnX1z4p2FV8MpYSjsG uKvbpzxGq+MA4UbFwwobSOza1BdaqU1Co51sCQJCpeCMBguGIaiwZvBnsEpqjZUz55uCEd foJi1tkey8jRc4X6a4KoG0uoIZAwLvA6U+KGFeE5d4Ta8KPOpSsyTZ55cifFUz5tWDFcoa VjpEf3FYHw6DPBhG9SbO83/Bu99fkJjgcNKGXmn8Nx5ClJz54C83Zbtz6XhJGA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1614435370; a=rsa-sha256; cv=none; b=R3kqmIEmFzD6b/I0AEWjqiiKOXF+GQQP+H5FJZEcdf9qTAtomMw4wzOAoRvzPcXLhZG6vP sPxjsyCKstwX8GMeKXSSUKF6zvk3sTiQO7nsgXVqZM+m5uETCtQpRtF7FDldEtHv/iDBxr /NPqJ9Fk0KrqtxRrC42H4QQSZoYoIDSnDvR8eLGc6T+4HyGJCKu8Fp1E9gpP2ZNumROzFM HXju/5aiWsXyd+QH2iqAGvAVesiLgzeu5ivNmZbGU78bGutGE0aTLarqMxj2OsfTUZGprz +DbVWfzULIYPbWg+TbwIXJY/YEyqLqqfK4Zrr/5lPGm+G18J9vG+ZYuQIgV/bw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.87 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: CFB7817A85 X-Spam-Score: -0.87 X-Migadu-Scanner: scn1.migadu.com X-TUID: nM00Ow8tpL4H Hello, qblade via Guix-patches via writes: > * gnu/packages/build-tools.scm (bmake): New variable. Thank you. Some comments follow. > + (name "bmake") > + (version "20200902") There is a newer version available. Could you provide it instead? I tried to quickly update it (hash "07n9avzdg6gifrzyddnyzada5s5rzklvbqfpv5drljpxcgpqpvwg") but there are additional failing tests. > + (arguments > + `(#:tests? #f ;; test in build You need a single semicolon for end-of-line comments. Also (nitpick), I find ";test during build" clearer. > + #:phases > + (modify-phases %standard-phases > + (add-after 'configure 'fix-test ;; fix from nixpkgs See above for comment syntax. > + (description "Program designed to simplify the maintenance of > +other programs.") I suggest: "bmake is a program designed to simplify the maintenance of other programs. Its input is a list of specifications as to the files upon which programs and other files depend." Could you send an updated patch? Regards, -- Nicolas Goaziou