unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Alexandru-Sergiu Marton <brown121407@posteo.ro>
Cc: 46352@debbugs.gnu.org
Subject: [bug#46352] [PATCH 0/4] Update Raku (Perl 6)
Date: Sat, 20 Mar 2021 22:07:37 +0100	[thread overview]
Message-ID: <87k0q14jqe.fsf_-_@gnu.org> (raw)
In-Reply-To: <20210206213511.11551-2-brown121407@posteo.ro> (Alexandru-Sergiu Marton's message of "Sat, 6 Feb 2021 23:35:09 +0200")

Hi,

Alexandru-Sergiu Marton <brown121407@posteo.ro> skribis:

> * gnu/packages/perl6.scm (moarvm): Update to 2020.12.

[...]

> -            ;(delete-file-recursively "3rdparty/dynasm") ; JIT
> -            (delete-file-recursively "3rdparty/dyncall")
> -            (delete-file-recursively "3rdparty/freebsd")

Apparently the 1st and 3rd line here are removed.

Is 3rdparty/freebsd being used now?  If there an opportunity for
unbundling?  If not, that’s OK.

Regarding dynasm, I think it’s best to keep the line commented out as a
reminder of what’s left to unbundle, if that’s still applicable.

Nitpick: could you mention in the commit log the modified fields:
‘inputs’, ‘arguments’, and ‘source’.  That often helps fellow reviewers
read the diff.  :-)

BTW, said reviewers have been so slow that there’s apparently a newer
version available now.  Apologies!

Thanks in advance,
Ludo’.




  reply	other threads:[~2021-03-20 21:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-06 21:33 [bug#46352] [PATCH 0/4] Update Raku (Perl 6) Alexandru-Sergiu Marton
2021-02-06 21:35 ` [bug#46352] [PATCH 1/4] gnu: Add dyncall Alexandru-Sergiu Marton
2021-02-06 21:35   ` [bug#46352] [PATCH 2/4] gnu: moarvm: Update to 2020.12 Alexandru-Sergiu Marton
2021-03-20 21:07     ` Ludovic Courtès [this message]
2021-03-22  9:04       ` [bug#46352] [PATCH 0/4] Update Raku (Perl 6) Alexandru-Sergiu Marton
2021-03-23 10:32         ` Ludovic Courtès
2021-02-06 21:35   ` [bug#46352] [PATCH 3/4] gnu: nqp: Update to 2020.12 Alexandru-Sergiu Marton
2021-03-20 21:10     ` [bug#46352] [PATCH 0/4] Update Raku (Perl 6) Ludovic Courtès
2021-02-06 21:35   ` [bug#46352] [PATCH 4/4] gnu: rakudo: Update to 2020.12 Alexandru-Sergiu Marton
2021-03-20 21:08     ` [bug#46352] [PATCH 0/4] Update Raku (Perl 6) Ludovic Courtès
2021-03-20 21:03   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0q14jqe.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=46352@debbugs.gnu.org \
    --cc=brown121407@posteo.ro \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).