From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AePqI3q2YmCZvwAAgWs5BA (envelope-from ) for ; Tue, 30 Mar 2021 07:26:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id QJGHEHq2YmAWWQAAbx9fmQ (envelope-from ) for ; Tue, 30 Mar 2021 05:26:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8B9DA1F266 for ; Tue, 30 Mar 2021 07:26:17 +0200 (CEST) Received: from localhost ([::1]:49454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lR6tM-0007xw-Im for larch@yhetil.org; Tue, 30 Mar 2021 01:26:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lR6t8-0007xN-G2 for guix-patches@gnu.org; Tue, 30 Mar 2021 01:26:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38483) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lR6t8-0006tQ-4X for guix-patches@gnu.org; Tue, 30 Mar 2021 01:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lR6t8-0005cV-0C for guix-patches@gnu.org; Tue, 30 Mar 2021 01:26:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47282] [PATCH 00/13] node going forward In-Reply-To: <20210320145706.12308-1-jlicht@fsfe.org> Resent-From: Timothy Sample Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 30 Mar 2021 05:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47282 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jelle Licht Cc: 47282@debbugs.gnu.org Received: via spool by 47282-submit@debbugs.gnu.org id=B47282.161708190121512 (code B ref 47282); Tue, 30 Mar 2021 05:26:01 +0000 Received: (at 47282) by debbugs.gnu.org; 30 Mar 2021 05:25:01 +0000 Received: from localhost ([127.0.0.1]:50029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lR6s9-0005al-Cp for submit@debbugs.gnu.org; Tue, 30 Mar 2021 01:25:01 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:40559) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lR6s4-0005aS-I2 for 47282@debbugs.gnu.org; Tue, 30 Mar 2021 01:24:59 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 96E275C01F4; Tue, 30 Mar 2021 01:24:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 30 Mar 2021 01:24:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=5ltoCQAxD9TF8bqLVH851lmQjoq7k7v5s5kQmPrMmcU=; b=tRwY1Dji GOAyedRC+HHOee7jLGmDCBfYwihQZ7md2PaPgz7TU/Lh73+nAxX04zoqgbWgPm5G /vmbZEK4x6lRc7+hWKr0e8EUd9XyrLhIOzcpUcOZZkavbOJFneKNObK4yAk1sQAV oPQAdjpgZb2odnmk4IGx9hR12TF9G+HBb3JBNet34YmdV/6Ooa5G7gkh4dizhtAc CnejWmpNK0DVtMe1345zLdMF2COOAhPLuFN3fWCNdhFEAz6gISC3sP/ub93SEfnr wW4bjWLCBjjJSMk0afSiEHlZdkd7UKpvL+cUVFgQZzns0BIEScRl/b9weO+FE5qZ 7x+oPcilHI3q8w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehledgleekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufhffffkfgggtgfgsehtqhertddtreejnecuhfhrohhmpefvihhmohht hhihucfurghmphhlvgcuoehsrghmphhlvghtsehnghihrhhordgtohhmqeenucggtffrrg htthgvrhhnpeeljeeuvefhveduffekveeufeevgfeffeeltddtieeuieekhfevjeejjeei hfegfeenucfkphepjeegrdduudeirddukeeirdeggeenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsrghmphhlvghtsehnghihrhhordgtohhm X-ME-Proxy: Received: from mrblack (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id C3363240057; Tue, 30 Mar 2021 01:24:49 -0400 (EDT) From: Timothy Sample References: <20210320145706.12308-1-jlicht@fsfe.org> Date: Tue, 30 Mar 2021 01:24:48 -0400 Message-ID: <87k0pprz6n.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617081978; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=5ltoCQAxD9TF8bqLVH851lmQjoq7k7v5s5kQmPrMmcU=; b=VkpG/L+s1coCkcjFQVRy6iVVaTanx/uC/H3dyv/4f9JNYECfOyBItHf6GHn5lR3HEKdUlk 92tcUm24EzoWDwAgN19xdU03yFsgrzbDMlUxHff4vnPj5foau7aykTiW19RMdfndhIJ74f cIaClj2l/blD+IgHlSS+AqNOVj27G4ym/LxDDRENiy+LOkSHKfuM7xnc7nOfoRInogwyQP 1O6p43LM46vb5jQNxILUcD7VBucURf3xQtNMn9rOcD75W9vvd9PGLWDsec7OL0+zYUZyIa Le8r8FPX3Xdc/4OM3ssoQBWn0JGhdbIkPfBLOH+oCeWv5YhFiJg7bBYlUNRFpQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617081978; a=rsa-sha256; cv=none; b=nqtDFlv7NCn6WDSqH9JCXeAa6QVAKZmw3ujexpSHwIGyGOozrhGjciG3Jx2vTCSOUBxQ5F Otrk7byEjDgkuG/CTQGh83ph/5J34eJSdTX/M2QU7FnCADxdbA0PsFcqv9T4bHfAxtU5jv EpBarESQe1MhuEUNIcy0c5pbNdr8jc0BtOuqVeJcvM9rYDeVhI76IEGfItugfrntYMGIeV FfHWGhrhTcMYn36I57bzMPKndopxz18M+oIdGOnJNuZaecfu3/02hnFnKha+prr93T6riw LUr/oeREJpqYXcc/9EG1fUGZs7KDjsAV7DRPMytZl44YxOQmlUAJY1GQ07l39w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=tRwY1Dji; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.08 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=tRwY1Dji; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8B9DA1F266 X-Spam-Score: 0.08 X-Migadu-Scanner: scn0.migadu.com X-TUID: Wjy6dbCzxlvz Hi Jelle, Jelle Licht writes: > So, some people seem to be interested in this one; please review and test. Now that I=E2=80=99ve finally taken the time to dig into what you=E2=80=99v= e done here =E2=80=93 I must say it=E2=80=99s very impressive! I=E2=80=99ve taken the presumptuous step of re-rolling the series. The rea= son is that all the =E2=80=9C(delete 'build)=E2=80=9D bits were bothering me. = I decided to have the build system check the =E2=80=9Cpackage.json=E2=80=9D file for a b= uild script before trying to run it. Since that change required changing all the other patches, I thought it would be easier to just post the updated patches. Also, I=E2=80=99m hoping to spare you some trouble (since you=E2= =80=99ve already gone to a lot!). Of course, this approach gave me free reign to pick nits. :) Below is a list of bigger things that I changed, but I also adjusted some commit messages, indentation, descriptions, and other minor things. =E2=80=A2 Add the check for a =E2=80=9Cbuild=E2=80=9D script as explain= ed above, and adjust the =E2=80=9Cnpm-build-system=E2=80=9D packages accordingly. =E2=80=A2 Rename =E2=80=9Clibuv-node=E2=80=9D to =E2=80=9Clibuv-for-nod= e=E2=80=9D, as this style is used for similar packages. I also changed the name to just =E2=80=9Clibuv=E2= =80=9D and marked it hidden. =E2=80=A2 Change the =E2=80=9CFix incorrect import semantics=E2=80=9D c= omments to =E2=80=9CFix imports for esbuild=E2=80=9D. To me, if TypeScript=E2=80=99s tsc lik= es the imports, they are correct TypeScript (despite the esbuild bug report). =E2=80=A2 Set the llhttp version to 2.1.3, and add a patch to fix CVE-2020-8287. The resulting C source files are identical to the ones shipped with Node.js 14.16.0. This makes the tests a little simpler, allowing the removal of the HTTP method superset change and fixing the reading one byte failure. =E2=80=A2 Fix the SIGXFSZ failure by fixing a =E2=80=9C/bin/sh=E2=80=9D= in the test. The final result is still a little messy, but I don=E2=80=99t think we shou= ld hold this back any longer. It=E2=80=99s a significant step forward, and it= puts us in better shape to improve things incrementally. WDYT? Let me know if I made anything worse! :) If the altered patches look good to you, I suggest you go ahead and push them. -- Tim