From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6EvKBrRRmmDlHwAAgWs5BA (envelope-from ) for ; Tue, 11 May 2021 11:43:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id QCSFArRRmmDAVgAA1q6Kng (envelope-from ) for ; Tue, 11 May 2021 09:43:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9170A25F15 for ; Tue, 11 May 2021 11:43:15 +0200 (CEST) Received: from localhost ([::1]:52870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgOv4-0006sv-OH for larch@yhetil.org; Tue, 11 May 2021 05:43:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgOXe-0006s2-M8 for guix-patches@gnu.org; Tue, 11 May 2021 05:19:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51627) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lgOXe-0003VO-9D for guix-patches@gnu.org; Tue, 11 May 2021 05:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lgOXe-0003I4-5q for guix-patches@gnu.org; Tue, 11 May 2021 05:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48325] julia-1.6 guix Resent-From: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 11 May 2021 09:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48325 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: zimoun , Jean-Baptiste Volatier Cc: 48325@debbugs.gnu.org Received: via spool by 48325-submit@debbugs.gnu.org id=B48325.162072472612620 (code B ref 48325); Tue, 11 May 2021 09:19:02 +0000 Received: (at 48325) by debbugs.gnu.org; 11 May 2021 09:18:46 +0000 Received: from localhost ([127.0.0.1]:34940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgOXN-0003HT-I0 for submit@debbugs.gnu.org; Tue, 11 May 2021 05:18:45 -0400 Received: from mail-ej1-f43.google.com ([209.85.218.43]:43625) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgOXL-0003HF-1N for 48325@debbugs.gnu.org; Tue, 11 May 2021 05:18:43 -0400 Received: by mail-ej1-f43.google.com with SMTP id l4so28689649ejc.10 for <48325@debbugs.gnu.org>; Tue, 11 May 2021 02:18:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=vZG/qALcllY/EUlm0ncuTjPaqCg39KTh8gO3DZhfzfk=; b=J3HctEWovOOZnROA085e98dvjzSYvjYIetnt16f3aDzEFmttDzcEAj/qwK4rCsLRj2 mCfSRnmrtvR8mLuZGkG1TWUYAcUdeK03z6xESFzd/qtiprhDXCCMIMKGaOjzws7XvofW NQg089O9C6ohWWm+r5WSZngNsJ7+JHP4BcE0oHI87nyEkkIhYrGkmBC3Z29DrFlvR+pd uP9T8/BCJGXgm8g0n17PjsQbc6JTTJYzN8bd/PN4Ge7NdCltM6JGmLRLI+eszp1Y2W6c HE4X+goYpocl32fQNqdzjtWfU+1YlyKZV86KO7gXo0kooTvb88sdrRz/6C/FayViXrzB 4TZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=vZG/qALcllY/EUlm0ncuTjPaqCg39KTh8gO3DZhfzfk=; b=EozOT0vaeXLSK6vrt85gdSNEvCRd4Uy+WLv1yDO+Ah5jNctsLPazGXZrtnF9J6xr08 lCVax9WBUcE2R3xjm1zU9zTCkBOGIZ1nl9NJr88LlI1Uh9Kt/wTQStbdLKOYxE7+r+rB VTyAW+PTK/wANPShwWW6Oxr5nntMLVbQHZqIUIh7v53aFYwMMY/sQamfUb1BjQpDetGm +AG4DOuSurHm76uHqr3aac7DcDRCdOhF5l8QG91YdtVobaXZQlvfg8BCh8V9zqsnYiA4 rZktZhD8HxO5zkimULUvVn0bHcofHZHTuZfn/OjU19YMRQJAxeQFn3zBCKVujCjoXNgb iCSQ== X-Gm-Message-State: AOAM5301pNDQS2cW/4UJ4/HrLof+BJAM1/18rLXpBmb3oBjKJb8t6Ogy EFopLwV6zz07JruFkAQkeNNIh7wsFkM= X-Google-Smtp-Source: ABdhPJzzR5Dr6HpxszdV9SL8DG3G7fryt4NKGe7UQ6ZPzDrpAdebYpRFf2MRYWYPtCLB8TYN3H+d2w== X-Received: by 2002:a17:907:78c4:: with SMTP id kv4mr30195858ejc.445.1620724717152; Tue, 11 May 2021 02:18:37 -0700 (PDT) Received: from guixSD (host-79-17-142-89.retail.telecomitalia.it. [79.17.142.89]) by smtp.gmail.com with ESMTPSA id zh16sm11247356ejb.10.2021.05.11.02.18.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 02:18:36 -0700 (PDT) From: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti In-Reply-To: <86a6p22kw7.fsf@gmail.com> References: <87bl9xqx5c.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87pmxzfth8.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87mtt3f4mp.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <86a6p22kw7.fsf@gmail.com> Date: Tue, 11 May 2021 11:18:35 +0200 Message-ID: <87k0o5fx1w.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620726195; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=vZG/qALcllY/EUlm0ncuTjPaqCg39KTh8gO3DZhfzfk=; b=DIhJzvSnuXjlzfUpTlKwjazc8Ne2mPZf31XUncAvh/kose72W1YIMO4KmO/rATzr/s5POO +hdN19DSlCh8lUBA5rb6kKo7DMgpT8qSczCnDwzIaT6Cx38keX1DB00SJ6vV5tBwwOqrgX ErsiGyfC+tpw+96l31ZXDjYXocGO85gwBPek/Q7uYJEXdGOsfAJTR72kHfpc2C+sUaDV26 w8qEgP0HZE4nDZ99PtTYiu/yOO7ccI3FhxKaaftGODhtf28l7u+nlKo5JqjcxtVwnhzmFF bSDkOCmyYAS1DFq5232OJeY0PcFOJ4jE45e+smC+wbSOEeB0QNmwSP1KU9l3TQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620726195; a=rsa-sha256; cv=none; b=X6WGrSUJlMKhsgzsKEb2pckmpNUOGcCsIPWEC04bB6bqg+eWh7BmqE1RTLoOvBDxiXREeY woc6MIVMoutr/UruYCVSf0UdCfz755Lx9lXG1H2AI/nBszyv3ckOL+f7OR3ZlxZZ1kS9PW U7GxKkdJ/vjy8zplUvF6o7/RTsCAcR5K/Lqj41h7tUwAG6IQ7AWDfAmRYKh9QK/M/JIym+ EowZT8tYYKB3QCfnmxYfVgfgps2yYhtQbmI5kgMyaTxrLrJvQBFmut1DXlqGZP/WRd/UOC n0OFrItvnp6m93AkjXzi3Cuj/zqul8qUYp9GVbo8qz+frXVcSoeOnN8tcWjF6g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=J3HctEWo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.35 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=J3HctEWo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 9170A25F15 X-Spam-Score: -1.35 X-Migadu-Scanner: scn0.migadu.com X-TUID: votMAgKVPaB1 zimoun writes: > Hi Jean-Baptiste, > > Thanks for the patch. Here some minor comments. > > Please, split this patch. One per update, i.e., 5 patches I guess. > Some changes should probably be committed together since current julia will fail to build with newer deps versions, but at least for utf8proc I'm sure this can be splitted. =20 > Just to be sure, if Nicol=C3=B3 is co-author, it should be worth to add t= hem > in the commit message, something like: > > Co-Authored-By: Nicol=C3=B2 Balzarotti . > Yep I helped a bit >> - '("arpack-ng" "curl" "dsfmt" > > I have not read the Julia ChangeLog. Do they remove Arpack? This > should be mentioned in the commit message. Yep, see for example: https://github.com/JuliaLang/julia/commit/0196cf1ff549ac120d8c556d610927d76= d679722 > >> + '("curl" "dsfmt" >> "gmp" "lapack" >> - "libssh2" "libgit2" >> + "libssh2" "libnghttp2" "libgit= 2" > > Idem for libnghttp2. > Yep they added libnghttp2 https://github.com/JuliaLang/julia/blob/bb5b98e72a151c41471d8cc14cacb495d64= 7fb7f/stdlib/nghttp2_jll/src/nghttp2_jll.jl >> "mbedtls" "mpfr" >> "openblas" "openlibm" "pcre2" >> - "suitesparse")) >> - ":")) >> - #t)) >> + "suitesparse" "libfortran")) > > Idem for libfortran. I just realized this is not sorted, would you mind fixing it? Also, there are still a few #t which can be removed (like this one in 'prepare-deps) > >> - (add-before 'build 'fix-precompile >> - (lambda _ >> - (substitute* "base/loading.jl" >> - (("something(Base.active_project(), \"\")") "\"\"")) >> + (add-before 'build 'shared-objects-paths >> + (lambda* (#:key inputs #:allow-other-keys) > > [...] > >> + ;; FAILING: OpenBLAS > > What does it mean? > I think it's a leftover which can be removed > >> + (add-before 'install 'symlink-libraries > > [...] > >> + (link "zlib" "usr/lib/julia/" "libz\\.so") > > Does this fix > > > > ? > Does it make sense? > I just tried running > cd /gnu/store/fp5by15552ihyppxppigmbxs981rd08h-julia-1.6.1 > find -type f -exec grep '/tmp/guix-build-julia-1.5.3.drv-0' {} \; and it returns nothing. Also, your Pkg.add("GZip"); using GZip worked (but it printed =E2=94=8C Error: curl_easy_setopt: 48 =E2=94=94 @ Downloads.Curl ~/guix-build-julia-1.6.1.drv-0/julia-1.6.1/usr/share/julia/stdlib/v1.6/Down= loads/src/Curl/utils.jl:36 which might be worth investigating) >> - "USE_SYSTEM_ARPACK=3D1" > > What is the motivation for removing Arpack? Sorry if my question is > naive. As before, it's no longer used by Julia > >> "USE_SYSTEM_LIBGIT2=3D1" >> "USE_SYSTEM_ZLIB=3D1"))) >> (inputs >> `(("llvm" ,llvm-julia) >> ("p7zip" ,p7zip) >> - ;; The bundled version is 3.3.0 so stick to that version. With = other >> - ;; versions, we get test failures in 'linalg/arnoldi' as describ= ed in >> - ;; . >> - ("arpack-ng" ,arpack-ng-3.3.0) >> - >> - ("coreutils" ,coreutils) ;for bindings to "mkdir" and the like >> + ("coreutils" ,coreutils) ;for bindings to "mkdir" and th= e like > > This is not a change. Even if the new indentation is correct, please > let avoid cosmetic change in the same commit updating a complex package. > Because then digging in the history becomes more complex. :-) > Agreed >> + ("nss-certs" ,nss-certs) ; required to precompile > > Hum? Is it really necessary? > I think that the alternative is to disable a few tests. I opened a bug report a few months ago here: https://github.com/JuliaLang/julia/issues/40185 >> + ("glibc-locales" ,glibc-locales) > > Idem. Is it really necessary? Because it is a =E2=80=9Cbig=E2=80=9C pac= kages which > drastically increases the closure size of the Julia package. > I think it's the same as before (fixes a few tests) but I cannot verify this, Jean-Baptiste do you know what breaks when this is removed? > > Thanks again for the patch. > Yep, thanks Jean-Baptiste and Simon for your review Nicol=C3=B2