unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 50040@debbugs.gnu.org
Subject: [bug#50040] [PATCH 0/2] publish: Always render nar/narinfo during backing.
Date: Wed, 01 Sep 2021 22:48:42 +0200	[thread overview]
Message-ID: <87k0k06mz9.fsf@gnu.org> (raw)
In-Reply-To: <875yvm6kxf.fsf@gnu.org> (Mathieu Othacehe's message of "Tue, 31 Aug 2021 11:08:28 +0200")

Hello!

Mathieu Othacehe <othacehe@gnu.org> skribis:

>> Did you manage to come up with a way to synthetically reproduce the
>> problem?
>
> Yes but it is rather complex. I managed to restart a lot of builds at
> the same time by running SQL queries on the Cuirass database.

OK.

[...]

>>      But look, ‘read-derivation-from-file’ is called just to fill in the
>>      “System” field, which is not used anywhere (not a single caller of
>>      ‘narinfo-system’), so we could just as well remove it and see how
>>      it behaves.
>
> Yes, I'll propose a patch to remove it.

Neat.

>> Anyway, that the main thread is blocking while this happens is certainly
>> a problem, so this patch looks like an improvement.  That we have to use
>> the ‘http-write’ hack isn’t great, but I think it’s OK, unless we want
>> to switch to Fibers.
>
> I think that applying this patchset + removing read-derivation-from-file
> call + increasing Nginx timeouts could be a good start. However, I will
> be mostly afk for about 3 weeks so unable to monitor the publish server
> on Berlin and fix potential regressions. Maybe we should wait until
> then.

Yes, sounds safer.  Removing the “System” bit from narinfos produced by
‘guix publish’ should be fine, though.

Thanks!

Ludo’.




  reply	other threads:[~2021-09-01 20:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13 10:28 [bug#50040] [PATCH 0/2] publish: Always render nar/narinfo during backing Mathieu Othacehe
2021-08-13 10:30 ` [bug#50040] [PATCH 1/2] publish: Defer narinfo string creation to the http-write Mathieu Othacehe
2021-08-13 10:30   ` [bug#50040] [PATCH 2/2] publish: Remove cache bypass support Mathieu Othacehe
2021-08-30 22:31   ` [bug#50040] [PATCH 0/2] publish: Always render nar/narinfo during backing Ludovic Courtès
2021-08-31  9:08     ` Mathieu Othacehe
2021-09-01 20:48       ` Ludovic Courtès [this message]
2021-10-06  8:58   ` Mathieu Othacehe
2021-10-08  7:04     ` Mathieu Othacehe
2021-08-22  7:33 ` Mathieu Othacehe
2021-08-30 22:33   ` Ludovic Courtès
2021-09-06 13:54     ` Ludovic Courtès
2021-09-17 15:27       ` Mathieu Othacehe
2021-10-05 10:07         ` Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0k06mz9.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=50040@debbugs.gnu.org \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).