unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#50479] [PATCH] Update home-page for ghc-pandoc-types
@ 2021-09-08 15:26 Alice BRENON
  2021-09-09 16:04 ` bug#50479: " Arun Isaac
  0 siblings, 1 reply; 2+ messages in thread
From: Alice BRENON @ 2021-09-08 15:26 UTC (permalink / raw)
  To: 50479

[-- Attachment #1: Type: text/plain, Size: 877 bytes --]

Hi Guix,

Trying to find examples of values for the home-page field in large
packages with library dependencies that were developed specifically as
part of the project, I stumbled upon the fact that ghc-pandoc-types had
the old page for pandoc, https://johnmacfarlane.net/pandoc as
home-page, whereas ghc-pandoc, added after, has the new
https://pandoc.org/. Given the fact that the former now redirects to
the latter, I suppose it would be more consistent to update it in
ghc-pandoc-type's definition. The redirect is only a 302, not a 301, but
I suppose it's a mistake given the content of the URL which seem to
indicate it's meant to point to "the site of the pandoc project".

I hope I'm not wasting your time for such a small change, but I thought
that while I was at it, since it's the kind of detail that can go
unnoticed for a long time it was better to fix it.

Alice

[-- Attachment #2: 0001-gnu-ghc-pandoc-types-Update-home-page.patch --]
[-- Type: text/x-patch, Size: 1098 bytes --]

From 690a2bf8de20ad563dfdf48068ea7c9a0df10908 Mon Sep 17 00:00:00 2001
From: Alice BRENON <alice.brenon@ens-lyon.fr>
Date: Wed, 8 Sep 2021 16:48:02 +0200
Subject: [PATCH] gnu: ghc-pandoc-types: Update home-page

* gnu/packages/haskell-xyz.scm (ghc-pandoc-types): Update home-page to
  the new project page to which the previous one now redirects.
---
 gnu/packages/haskell-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/haskell-xyz.scm b/gnu/packages/haskell-xyz.scm
index c12f97802e..c9bb248c09 100644
--- a/gnu/packages/haskell-xyz.scm
+++ b/gnu/packages/haskell-xyz.scm
@@ -9765,7 +9765,7 @@ version = Version [~a] []
        ("ghc-test-framework-hunit" ,ghc-test-framework-hunit)
        ("ghc-test-framework-quickcheck2" ,ghc-test-framework-quickcheck2)
        ("ghc-hunit" ,ghc-hunit)))
-    (home-page "https://johnmacfarlane.net/pandoc")
+    (home-page "https://pandoc.org")
     (synopsis "Types for representing a structured document")
     (description
      "This module defines the @code{Pandoc} data structure, which is used by
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#50479: [PATCH] Update home-page for ghc-pandoc-types
  2021-09-08 15:26 [bug#50479] [PATCH] Update home-page for ghc-pandoc-types Alice BRENON
@ 2021-09-09 16:04 ` Arun Isaac
  0 siblings, 0 replies; 2+ messages in thread
From: Arun Isaac @ 2021-09-09 16:04 UTC (permalink / raw)
  To: Alice BRENON, 50479-done

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]


Hi Alice,

Welcome to Guix! :-) Thank for catching this! I have pushed your patch
to master after adding a copyright header for you and simplifying the
commit message.

> I hope I'm not wasting your time for such a small change, but I thought
> that while I was at it, since it's the kind of detail that can go
> unnoticed for a long time it was better to fix it.

No worries, all patches are welcome! :-)

Cheers!
Arun

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-09 16:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-08 15:26 [bug#50479] [PATCH] Update home-page for ghc-pandoc-types Alice BRENON
2021-09-09 16:04 ` bug#50479: " Arun Isaac

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).