From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GFf9ON7cR2Fu2wAAgWs5BA (envelope-from ) for ; Mon, 20 Sep 2021 02:59:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qASbNN7cR2FKdwAAB5/wlQ (envelope-from ) for ; Mon, 20 Sep 2021 00:59:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AF8741C833 for ; Mon, 20 Sep 2021 02:59:10 +0200 (CEST) Received: from localhost ([::1]:50082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mS7eH-0004SE-GS for larch@yhetil.org; Sun, 19 Sep 2021 20:59:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mS7eA-0004Rr-Dv for guix-patches@gnu.org; Sun, 19 Sep 2021 20:59:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57023) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mS7eA-0003mp-65 for guix-patches@gnu.org; Sun, 19 Sep 2021 20:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mS7e9-0000vR-Ub for guix-patches@gnu.org; Sun, 19 Sep 2021 20:59:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50363] [PATCH v3] Improve default diff hunk header detection. Resent-From: Kyle Meyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 20 Sep 2021 00:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50363 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: 50363@debbugs.gnu.org, ludo@gnu.org, maximedevos@telenet.be Received: via spool by 50363-submit@debbugs.gnu.org id=B50363.16320994873492 (code B ref 50363); Mon, 20 Sep 2021 00:59:01 +0000 Received: (at 50363) by debbugs.gnu.org; 20 Sep 2021 00:58:07 +0000 Received: from localhost ([127.0.0.1]:40336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS7dG-0000uF-Nn for submit@debbugs.gnu.org; Sun, 19 Sep 2021 20:58:06 -0400 Received: from out1.migadu.com ([91.121.223.63]:61377) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS7dD-0000u5-8N for 50363@debbugs.gnu.org; Sun, 19 Sep 2021 20:58:04 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1632099481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rUHxZGzGIls1tdFhWAeGsatNm9NBTv/EDlIZ+Day3rM=; b=wX+RM0ts05BWy+iaX6q70OuZm3g6ghI+TejXtUjje7VWXNV81rqrDUCP6Eic/w3n9lPxex QsSPH61qKI/CnBaT2IzXGGdYt63CoYOFc+FOvE8psoseeZtwz3wSUXsNJv5Rys8jXNyIwZ +Rt7B+GTuyC1TR4fZ7EntoL/jUOJ9i1C0td+ib+BkdEQpQDjUIEFBEXoeKH+bb24PtOOuO mkC1CZNOCpB0SNyb/rYu1b8vkF3soeemAfHHxu3yYCJSPX/DYIEdPs/M7FBe7Fup8RcDzR Nz2cOsfz1MDCJe2b6Fa7w+0Jouu5pi4AIy2Q65Ew++VUiWkAXK7J4/EmBFChOQ== From: Kyle Meyer In-Reply-To: <86ee9kgono.fsf@mgsn.dev> References: <58187bb9c61bc7599cde31b52a5dd58e90c1f78f.1632076068.git.iskarian@mgsn.dev> <87o88o8bf8.fsf@kyleam.com> <86ee9kgono.fsf@mgsn.dev> Date: Sun, 19 Sep 2021 20:57:53 -0400 Message-ID: <87k0jc83n2.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: AF8741C833 X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: Ud6QjvHdxKjk Sarah Morgensen writes: > Kyle Meyer writes: > >> Sarah Morgensen writes: [...] >>> @cindex @code{git send-email} >>> -@cindex @code{git-send-email} >> >> I suspect the second variant was included to help those that are using >> the git- variant to search (perhaps because that's how they'd refer to >> the manpage or because they know about Git's exec path). Not a big deal >> either way, but keeping it around seems okay to me. > > Hmmm. I originally removed it because it results in two entries in the > index. Perhaps I can index them as > > @cindex @code{git send-email} (or @code{git-send-email}) > > or similar. What do you think? I don't see having entries in the index for different variants as an issue (although I can see the point of view that it's just noise in this case). As for packing them into one line, dunno, think I'd just leave it either as it is (separate lines) or how your patch has it. But, again, I don't think it matters much either way (and perhaps wasn't worth me commenting on it :]).