unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Guillaume Le Vaillant <glv@posteo.net>
To: John Kehayias <john.kehayias@protonmail.com>
Cc: 51987@debbugs.gnu.org
Subject: [bug#51987] [PATCH] [core-updates-frozen] gnu: ledger: Remove failing test output.
Date: Sat, 20 Nov 2021 09:19:45 +0000	[thread overview]
Message-ID: <87k0h3xjnp.fsf@kitej> (raw)
In-Reply-To: <DbIKi7rOz5d9q96LfLMVQCTfb5fK-MSOs8GH9FC8DiJHahOjK-7r2NWlP5ioCqoHujEw0w2bUQG3sYw8_s-GZYFCyyxZZZvW4mf2m_bxYYA=@protonmail.com>

[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]

John Kehayias via Guix-patches via <guix-patches@gnu.org> skribis:

> Hello,
>
> I'm not sure why, but ledger started failing one of its test on core-updates-frozen. The test is for the error when trying to use a nonexistent file (as far as I can tell) and it fails in the error message reporting the path of the file without the leading "./". Output of the test below. The patch removes this test from ledger.
>
> 359/396 Test #359: RegressTest_BF3C1F82-2 ................................***Failed    0.04 sec
> FAILURE in error output from /tmp/guix-build-ledger-3.2.1.drv-0/source/test/regress/BF3C1F82-2.test:
> --
> $ledger -f - reg
> --
>   @@ -1,2 +1,2 @@
>
>    While parsing file "", line 2:
>
>   -Error: File to include was not found: "./non-existent-ledger-file-BF3C1F82"
>
>   +Error: File to include was not found: "non-existent-ledger-file-BF3C1F82"
>
> E[BF3C1F82-2.test]STDERR:
> b''
> FAILURE in error output from /tmp/guix-build-ledger-3.2.1.drv-0/source/test/regress/BF3C1F82-2.test:
> --
> $ledger -f /dev/stdin reg

Hi,

Instead of adding a patch removing the file, wouldn't it be simpler to just add a phase
calling '(delete-file "test/...")'?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

  reply	other threads:[~2021-11-20  9:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19 22:47 [bug#51987] [PATCH] [core-updates-frozen] gnu: ledger: Remove failing test output John Kehayias via Guix-patches via
2021-11-20  9:19 ` Guillaume Le Vaillant [this message]
2021-11-20 18:08   ` John Kehayias via Guix-patches via
2021-11-20 18:26     ` bug#51987: " Guillaume Le Vaillant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0h3xjnp.fsf@kitej \
    --to=glv@posteo.net \
    --cc=51987@debbugs.gnu.org \
    --cc=john.kehayias@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).