From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WF2IJspW8WGyZgAAgWs5BA (envelope-from ) for ; Wed, 26 Jan 2022 15:12:26 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 2M2MHcpW8WHUhQAAG6o9tA (envelope-from ) for ; Wed, 26 Jan 2022 15:12:26 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0512136A40 for ; Wed, 26 Jan 2022 15:12:26 +0100 (CET) Received: from localhost ([::1]:32944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nCj28-0003Dt-VH for larch@yhetil.org; Wed, 26 Jan 2022 09:12:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59488) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCiVr-0000qR-6S for guix-patches@gnu.org; Wed, 26 Jan 2022 08:39:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58355) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nCiVq-0007L5-Hn for guix-patches@gnu.org; Wed, 26 Jan 2022 08:39:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nCiVq-0005RY-G2 for guix-patches@gnu.org; Wed, 26 Jan 2022 08:39:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53536] [PATCH 0/1] Add poppler-with-data. Resent-From: Taiju HIGASHI Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 26 Jan 2022 13:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53536 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , 53536@debbugs.gnu.org Cc: me@tobias.gr, leo@famulari.name, marius@gnu.org Received: via spool by 53536-submit@debbugs.gnu.org id=B53536.164320433220908 (code B ref 53536); Wed, 26 Jan 2022 13:39:02 +0000 Received: (at 53536) by debbugs.gnu.org; 26 Jan 2022 13:38:52 +0000 Received: from localhost ([127.0.0.1]:51258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCiVf-0005R9-QV for submit@debbugs.gnu.org; Wed, 26 Jan 2022 08:38:52 -0500 Received: from mail-pf1-f176.google.com ([209.85.210.176]:45028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCiVe-0005Qw-83 for 53536@debbugs.gnu.org; Wed, 26 Jan 2022 08:38:50 -0500 Received: by mail-pf1-f176.google.com with SMTP id n32so13555209pfv.11 for <53536@debbugs.gnu.org>; Wed, 26 Jan 2022 05:38:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=taiju-info.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=7As0lXn51oW8FfFQaFNs9gg0ZQdRdTS9hPpLE0Qd2/E=; b=cr/beI98V67I5GC9GUK7dqqMk4NU6E2r0vS5V0MSpfVj/gVkF2PjTc9IA9tBQOUSL2 gHrzheiQvd8Y6PMJAaiZ5QfrR36tBv3TgKDeC6Jh7Ow5kSXH0nnPg9pOPbAeaaBj78B0 Bs7lAqzutyjN8duwafUvAcuyJGF7TyA/Fp1nZDBqMGnpRiT+ohgsIQr5t1GsYB1/aO9L 37KGrD2N7uNrdjL6Q5D9J6QXEJ3SYCM5dWyNjTh6+KRH/NNrTjgp4+Nss7PkC3CZKJq5 PEeX2ONbVbJGhKzrPsj4uz3MAfhRdxeZKe/Z8YK/Lqfc1zbI21b6CxF+BVzsxRZhAaKt ghzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=7As0lXn51oW8FfFQaFNs9gg0ZQdRdTS9hPpLE0Qd2/E=; b=6lJV5HMarcD09K/3JtwuPuRc5Lbx5wuVvPpbqRtQl4sVtvGwkMs1DQT/GDmWBnFUhN D4CNaPMtmmy73ElJZ/Idp2f7K4kRTTqYRQ83kkGZaBDO0dJb8WcXrfnzqossePL6Srl6 Qd3kdHTuZ0eKJhUDQ5s+l8CJIAvy+SN3BaEsBOkeaIAEaUY7GQCsMnlDs+iscP8V+Mrr /t4wjBMRVQ4SF46dTgcVKJeAUFXXU6q2tTcwNNb/N+jFtOz3qaZfGWnmypcRBqp8Clci iiHR9LmbhkjTkjyrSEpYaCQ9kzI0d4N0YH1WALArpbbS09NCnU3TqiDpzF6IyHytE0n/ ZUaQ== X-Gm-Message-State: AOAM532MYlt6Im6Gd0vGGZ2+Y6ILYT3iPhu+tYbEdxj//F3BExh7rxsB lJaDS/bDAHXHt/FIKX5MkW7T1Q== X-Google-Smtp-Source: ABdhPJyjQhQbgZrdAlwibCrom4julG4jQY85KWTqHJGWc6Ol7AJDtrLPxNJ3uedCNEb8HY8DZ3LYOw== X-Received: by 2002:a63:6886:: with SMTP id d128mr18825651pgc.247.1643204323739; Wed, 26 Jan 2022 05:38:43 -0800 (PST) Received: from Taix ([240b:253:ec40:2400:b7d1:436e:2d61:e925]) by smtp.gmail.com with ESMTPSA id e14sm2233684pfv.219.2022.01.26.05.38.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jan 2022 05:38:43 -0800 (PST) From: Taiju HIGASHI References: <20220125235931.4451-1-higashi@taiju.info> Date: Wed, 26 Jan 2022 22:38:02 +0900 In-Reply-To: (Liliana Marie Prikler's message of "Wed, 26 Jan 2022 08:37:30 +0100") Message-ID: <87k0em4nyd.fsf@taiju.info> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1643206346; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=7As0lXn51oW8FfFQaFNs9gg0ZQdRdTS9hPpLE0Qd2/E=; b=TEmGekOJQBkUWxQQwm20x0nnqIFdYW2kb+88BQWsn/bNXvzOkYuUNeIazUQGVdZ1JpQSYm 3jOYB4AfHlcnb+kqDfYpzvOCc9087V0iudQW+vJsI4tThw5i0VGySPVexYPYtEk4Eb1sqg rSX6aaJMucpo5Iq2hbkVmAV3F5x/TiI4mxKfVq3rQjQHTOrBBKVoeIKr8wWNn2Og5LeQZm 7OOVfgTe7nNDb4pK8MTSbeiS27JeuiJ0V0HCnVeo5z1XlSjTnonIa2FMcoPCv5ZPYFY8Ml KU+tSDDnr/LxTtjlGm0OOMMHqSCWAx7n6vxcZVHx/BklCT2UuKKC7aCf0ww+4A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1643206346; a=rsa-sha256; cv=none; b=icBiKR+XRtcsA02w+hj9FW7mszKYFyv7HDXvF0p8mYTJ7EkPCV0z7LSnfUfPXqs+XTfJy7 LWye8OnXEdHB1nkvLqdSM8RDn4PeIfsP6TtNFe9+2TwxKy1IgN/rwiAgAPnXY5Oz7S131S AmTlmbydnBRk+JvlSJ6JZYF9zx/SwiAhgRTLEOVbDDgdAbj2x3gp5yW3lbf0kAQ3Hxozcp UjWKRS6rzeuF3tOpIdW5XjxHCPSpUCNluKPvUhkk2r8d90aA2WZBCtOPtcXvYozULKoJ2k c8JWHaJ+GMV9xoDoT+nEP4pIUkkmv/wTCYZV+HedasYG62IwsAa6CD71WcW5cg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=taiju-info.20210112.gappssmtp.com header.s=20210112 header.b="cr/beI98"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.13 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=taiju-info.20210112.gappssmtp.com header.s=20210112 header.b="cr/beI98"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0512136A40 X-Spam-Score: -2.13 X-Migadu-Scanner: scn1.migadu.com X-TUID: 9ggt0dn6hQTx Hi Liliana, > That seems to be one solution, but note that the Qt5 variants of > poppler would still be affected by that bug. You're right, poppler-qt5 also needs a variant with poppler-data added. > Instead, I suggest we make poppler-with-data a replacement for > poppler, which should by package/inherit then also apply to the other > variants. > > I've CC'd Marius, Tobias and Leo to aid me in my judgement here, but I > think grafts would be necessary if we don't want to do input rewriting > with several variants. I apologize if I didn't understand exactly what you meant. Am I correct in understanding that the direction of this patch is correct? The idea is to create a variant called poppler-qt5-with-data and replace the input of packages that depend on poppler-qt5 with it. I'm starting to think that this patch proposal is a realistic and reasonable solution. I'm using poppler-with-data to write the manifest, but without poppler-with-data, I'm not sure what I'd do. In fact, I'm using poppler-with-data to write manifests, and it's much better than not using poppler-with-data. At least I don't have to redefine evince etc. on my own anymore. ref: https://git.sr.ht/~taiju/taix/tree/8a3ab4407eefe720193e401cf8f11d96550733e9/item/guix-config/package-config.scm If I am interpreting your reply incorrectly, I would appreciate it if you could be more specific. > Are there any other packages you might want to install into > POPPLER_INSTALL_PREFIX? If so, a colon-separated POPPLER_DATA_PATH > should be preferred. Note that if we add that feature, we'd still have > to graft it on master currently. At the moment, there is nothing other than poppler-data that we want to install in POPPLER_INSTALL_PREFIX. However, this idea, while generic, may be confusing to users, as shown in the reason why it was deprecated in Nix. At least, if the package poppler-with-data exists, we can speculate that it might be able to solve the problem. QUOTE: Previously we relied on an environment variable POPPLER_DATADIR which practically noone used and everyone was expected to set. This is a good candidate for a feature option because noone really _noticed_ that this data is not available. Disabled by default because of this and size of the data (22M). ref: https://github.com/NixOS/nixpkgs/pull/17819/commits/1bde33074efa11fa2edcf71032d2e634f852f349 Thanks