unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: Maxime Devos <maximedevos@telenet.be>, 54065@debbugs.gnu.org
Subject: [bug#54065] [PATCH 0/3] Update mumble to 1.4.230
Date: Tue, 05 Apr 2022 16:08:11 +0200	[thread overview]
Message-ID: <87k0c3mxmc.fsf_-_@gnu.org> (raw)
In-Reply-To: <91bd55c20b57aa4272e710f139551f9244addeb5.camel@gmail.com> (Liliana Marie Prikler's message of "Sat, 19 Feb 2022 16:03:37 +0100")

Hi,

Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:

> * gnu/packages/cpp.scm (poco): New variable.

[...]

> +    (synopsis "Portable C++ components")
> +    (description "A collection of libraries intended to be useful for building
> +network-based applications.")

Please make it a full sentence (info "(guix) Synopses and Descriptions").

> * gnu/packages/telephony.scm (find-python-interpreter-cmake-modules):
> New variable.
> (mumble): Update to 1.4.230.
> [source]: Adjust uri and snippet accordingly.
> [arguments]: Change to a list of G-expressions.
> <#:configure-flags>: New argument.
> <#:phases>: Drop ‘configure’ (moved to configure-flags).
> Add ‘unpack-submodules’, ‘fix-settings-crash’ and ‘hardcode-pulseaudio’.
> [inputs]: Add glib and poco.

[...]

> * gnu/packages/telephony.scm (mumble)[#:tests?]: Drop argument.
> [#:configure-flags]: Add “-Dtests=on”.

I believe Maxime’s comments were addressed and the rest LGTM, thanks!

Ludo’.




  reply	other threads:[~2022-04-05 14:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-19 15:39 [bug#54065] [PATCH 0/3] Update mumble to 1.4.230 Liliana Marie Prikler
2022-02-19 15:03 ` [bug#54065] [PATCH 1/3] gnu: Add poco Liliana Marie Prikler
2022-02-19 15:03 ` [bug#54065] [PATCH v2 " Liliana Marie Prikler
2022-04-05 14:08   ` Ludovic Courtès [this message]
2022-04-05 19:09     ` [bug#54065] [PATCH 0/3] Update mumble to 1.4.230 Liliana Marie Prikler
2022-02-19 15:05 ` [bug#54065] [PATCH v2 2/3] gnu: mumble: Update " Liliana Marie Prikler
2022-02-19 15:05 ` [bug#54065] [PATCH " Liliana Marie Prikler
2022-02-19 18:12   ` Maxime Devos
2022-02-19 19:20     ` Liliana Marie Prikler
2022-02-19 18:18   ` Maxime Devos
2022-02-19 19:18     ` Liliana Marie Prikler
2022-02-19 18:20   ` Maxime Devos
2022-02-19 19:18     ` Liliana Marie Prikler
2022-02-19 15:37 ` [bug#54065] [PATCH 3/3] gnu: mumble: Enable tests Liliana Marie Prikler
2022-02-19 15:37 ` [bug#54065] [PATCH v2 " Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0c3mxmc.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=54065@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).