[bug#54231] [PATCH] gnu: trezor-agent: Fix it by deleting the sanity-check phase.

[bug#54231] [PATCH] gnu: trezor-agent: Fix it by deleting the sanity-check phase.

[Attila Lendvai]

It used to work before the new sanity_check.py was added, and the build result
still seems to work fine.
---
 gnu/packages/finance.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 985eaa87f7..26c546caed 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -1156,6 +1156,7 @@ (define-public trezor-agent
     (arguments
      `(#:phases
        (modify-phases %standard-phases
+         (delete 'sanity-check) ; TODO It fails, but the package works fine.
          (add-after 'wrap 'fixup-agent-py
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (let* ((out (assoc-ref outputs "out")))
-- 
2.34.0

[bug#54231] [PATCH] gnu: trezor-agent: Fix it by deleting the sanity-check phase.

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

Attila Lendvai schreef op do 03-03-2022 om 11:58 [+0100]:
> +         (delete 'sanity-check) ; TODO It fails, but the package works fine.

How does it fail?  Maybe it indicates a real problem that merely
happens to be difficult to trigger in practice.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

[bug#54231] [PATCH] gnu: trezor-agent: Fix it by deleting the sanity-check phase.

[Attila Lendvai]

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

> > +         (delete 'sanity-check) ; TODO It fails, but the package works fine.
>
> How does it fail? Maybe it indicates a real problem that merely
> happens to be difficult to trigger in practice.


unfortunately i'm not a python expert, i don't know why it fails, but currently it doesn't even build.

i have attached the relevant part of the build output.

if you scan python-xyz.scm, this phase is deleted in several other packages.

--
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
“There is nothing sacrosanct about the majority; the lynch mob, too, is the majority in its own domain.”
	— Murray N. Rothbard (1926–1995), 'For a New Liberty' (1973)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: trezor-agent.log --]
[-- Type: text/x-log; name=trezor-agent.log, Size: 4523 bytes --]

starting phase `check'
running "python setup.py" with command "test" and parameters ()
running test
WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.
running egg_info
writing trezor_agent.egg-info/PKG-INFO
writing dependency_links to trezor_agent.egg-info/dependency_links.txt
writing entry points to trezor_agent.egg-info/entry_points.txt
writing requirements to trezor_agent.egg-info/requires.txt
writing top-level names to trezor_agent.egg-info/top_level.txt
reading manifest file 'trezor_agent.egg-info/SOURCES.txt'
writing manifest file 'trezor_agent.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
phase `check' succeeded after 0.3 seconds
starting phase `sanity-check'
validating 'trezor-agent' /gnu/store/2546g9jrhnyzy3iar35cy3clgzv505dh-trezor-agent-0.11.0-1/lib/python3.9/site-packages
...checking requirements: OK
...trying to load endpoint console_scripts trezor-agent: ERROR:
Traceback (most recent call last):
  File "/gnu/store/35ix1m6m8a5s21j02ajhdyqxb2xkshfb-sanity-check.py", line 85, in <module>
    ep.load()
  File "/gnu/store/b6j1qw1a5rkbfvcy7lc9fm95abbzpa4x-python-3.9.9/lib/python3.9/site-packages/pkg_resources/__init__.py", line 2450, in load
    return self.resolve()
  File "/gnu/store/b6j1qw1a5rkbfvcy7lc9fm95abbzpa4x-python-3.9.9/lib/python3.9/site-packages/pkg_resources/__init__.py", line 2456, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
ModuleNotFoundError: No module named 'trezor_agent'
...trying to load endpoint console_scripts trezor-gpg: ERROR:
Traceback (most recent call last):
  File "/gnu/store/35ix1m6m8a5s21j02ajhdyqxb2xkshfb-sanity-check.py", line 85, in <module>
    ep.load()
  File "/gnu/store/b6j1qw1a5rkbfvcy7lc9fm95abbzpa4x-python-3.9.9/lib/python3.9/site-packages/pkg_resources/__init__.py", line 2450, in load
    return self.resolve()
  File "/gnu/store/b6j1qw1a5rkbfvcy7lc9fm95abbzpa4x-python-3.9.9/lib/python3.9/site-packages/pkg_resources/__init__.py", line 2456, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
ModuleNotFoundError: No module named 'trezor_agent'
...trying to load endpoint console_scripts trezor-gpg-agent: ERROR:
Traceback (most recent call last):
  File "/gnu/store/35ix1m6m8a5s21j02ajhdyqxb2xkshfb-sanity-check.py", line 85, in <module>
    ep.load()
  File "/gnu/store/b6j1qw1a5rkbfvcy7lc9fm95abbzpa4x-python-3.9.9/lib/python3.9/site-packages/pkg_resources/__init__.py", line 2450, in load
    return self.resolve()
  File "/gnu/store/b6j1qw1a5rkbfvcy7lc9fm95abbzpa4x-python-3.9.9/lib/python3.9/site-packages/pkg_resources/__init__.py", line 2456, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
ModuleNotFoundError: No module named 'trezor_agent'
...trying to load endpoint console_scripts trezor-signify: ERROR:
Traceback (most recent call last):
  File "/gnu/store/35ix1m6m8a5s21j02ajhdyqxb2xkshfb-sanity-check.py", line 85, in <module>
    ep.load()
  File "/gnu/store/b6j1qw1a5rkbfvcy7lc9fm95abbzpa4x-python-3.9.9/lib/python3.9/site-packages/pkg_resources/__init__.py", line 2450, in load
    return self.resolve()
  File "/gnu/store/b6j1qw1a5rkbfvcy7lc9fm95abbzpa4x-python-3.9.9/lib/python3.9/site-packages/pkg_resources/__init__.py", line 2456, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
ModuleNotFoundError: No module named 'trezor_agent'
error: in phase 'sanity-check': uncaught exception:
%exception #<&invoke-error program: "python" arguments: ("/gnu/store/35ix1m6m8a5s21j02ajhdyqxb2xkshfb-sanity-check.py" "/gnu/store/2546g9jrhnyzy3iar35cy3clgzv505dh-trezor-agent-0.11.0-1/lib/python3.9/site-packa 
phase `sanity-check' failed after 0.2 seconds
command "python" "/gnu/store/35ix1m6m8a5s21j02ajhdyqxb2xkshfb-sanity-check.py" "/gnu/store/2546g9jrhnyzy3iar35cy3clgzv505dh-trezor-agent-0.11.0-1/lib/python3.9/site-packages" failed with status 1
builder for `/gnu/store/zaamrw85wbcw5h3x011bpns180jrm0pp-trezor-agent-0.11.0-1.drv' failed with exit code 1
build of /gnu/store/zaamrw85wbcw5h3x011bpns180jrm0pp-trezor-agent-0.11.0-1.drv failed
View build log at '/var/log/guix/drvs/za/amrw85wbcw5h3x011bpns180jrm0pp-trezor-agent-0.11.0-1.drv.gz'.
guix build: error: build of `/gnu/store/zaamrw85wbcw5h3x011bpns180jrm0pp-trezor-agent-0.11.0-1.drv' failed

[bug#54231] [PATCH] gnu: trezor-agent: Fix it by deleting the sanity-check phase.

[Attila Lendvai]

would it be possible to get this in? or another fix that restores the
package's buildability?

the tests can be fixed later by a python expert that wanders around
here.

--
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
“It is the mark of an educated mind to be able to entertain a thought without accepting it.”
	— Aristotle (BC 384–322), 'Metaphysics'

[bug#54231] [PATCH] gnu: trezor-agent: Fix it by deleting the sanity-check phase.

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]

Attila Lendvai schreef op di 12-04-2022 om 10:41 [+0000]:
> would it be possible to get this in? or another fix that restores the
> package's buildability?
> 
> the tests can be fixed later by a python expert that wanders around
> here.

It looks like 'trezor-agent' only has a python script and not a python
module, so no wonder that 'sanity-check' fails to find the module.  As
such, I believe that the 'sanity-check' phase can indeed be removed in
this case, if accompanied an appropriate comment.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

bug#54231: [PATCH] gnu: trezor-agent: Fix it by deleting the sanity-check phase.

[Guillaume Le Vaillant]

[-- Attachment #1: Type: text/plain, Size: 132 bytes --]

Patch pushed as d3d2881acf4f3efef61a4049ea4c7c3ba883f48c with a comment
explaining why the 'sanity-check' phase is deleted.
Thanks.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

[bug#54231] [PATCH] gnu: trezor-agent: Fix it by deleting the sanity-check phase.

[Marek Paśnikowski]

Greetings

I am a Guix newbie, so I do not know yet, how to find the package
source.

Does this package declare `python-trezor-agent` as a dependency? The
error message hints at this missing dependency.

[bug#54231] [PATCH] gnu: trezor-agent: Fix it by deleting the sanity-check phase.

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

Marek Paśnikowski schreef op wo 30-03-2022 om 15:29 [+0200]:
> Does this package declare `python-trezor-agent` as a dependency? The
> error message hints at this missing dependency.

Yes, it does:

    (inputs
     (list python-trezor python-trezor-agent))

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]