From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YJyCK02ZdmJURgEAbAwnHQ (envelope-from ) for ; Sat, 07 May 2022 18:07:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id YPuHK02ZdmKPwQAA9RJhRA (envelope-from ) for ; Sat, 07 May 2022 18:07:41 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4E77110243 for ; Sat, 7 May 2022 18:07:41 +0200 (CEST) Received: from localhost ([::1]:35260 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nnMy4-0007r0-Fk for larch@yhetil.org; Sat, 07 May 2022 12:07:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnMvc-0006K0-Dk for guix-patches@gnu.org; Sat, 07 May 2022 12:05:18 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58853) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nnMvW-0001oA-HE for guix-patches@gnu.org; Sat, 07 May 2022 12:05:08 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nnMvW-00069C-9t for guix-patches@gnu.org; Sat, 07 May 2022 12:05:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55220] [PATCH 0/4] Add --list-systems and --list-targets options. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 07 May 2022 16:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55220 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 55220@debbugs.gnu.org Received: via spool by 55220-submit@debbugs.gnu.org id=B55220.165193947723576 (code B ref 55220); Sat, 07 May 2022 16:05:02 +0000 Received: (at 55220) by debbugs.gnu.org; 7 May 2022 16:04:37 +0000 Received: from localhost ([127.0.0.1]:52745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nnMv7-00068C-JB for submit@debbugs.gnu.org; Sat, 07 May 2022 12:04:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nnMv5-00067y-Kz for 55220@debbugs.gnu.org; Sat, 07 May 2022 12:04:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40764) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnMuz-0001k6-MY; Sat, 07 May 2022 12:04:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=0WOWNKQke0FD114iyki0v0YTm87SxPab4b2CDXt3w4Y=; b=UkaDGssscrV8ssWF3zoh f9oB/Lx/MALX/Op8DV2yBSIKMRKrQcLL/XDAU29mUDWrRSfdNJogGFP8iY1AEeo9Y0KfDTPd6nRPQ FYUeiJTfXUuuQFF8oFc+47jmcNDqeLy/cExcHgWT4iiqZZ/2eJXp/pCPQ6bSN0U7OkB9FgaLqErBb seSORC4RiGgrSUTqn38hrkYznMj+BCji7aNIAtTplC5xXB2fN5QBMtTamJKpO8jkO92O3V34glmW2 GPWAVu4UNClW0GrtUKijaO8y9QICtvZ2V9lBF0GCBGsQ+qYQdVb7oMZxNa9tZld7yH8VLMV2QI6eF ZuNgmYhMakhCXg==; Received: from 71.125.192.77.rev.sfr.net ([77.192.125.71]:40320 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnMuz-0003z3-9N; Sat, 07 May 2022 12:04:29 -0400 From: Mathieu Othacehe References: <20220502111859.13605-1-othacehe@gnu.org> <20220502111859.13605-4-othacehe@gnu.org> <875ymi3e5t.fsf_-_@gnu.org> Date: Sat, 07 May 2022 18:04:26 +0200 In-Reply-To: <875ymi3e5t.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Fri, 06 May 2022 16:54:06 +0200") Message-ID: <87k0ax8h2t.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651939661; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=0WOWNKQke0FD114iyki0v0YTm87SxPab4b2CDXt3w4Y=; b=V3+Z5lXELqvJt2t86T8q6XHDBsX/t1gVNjkcpU66SK2bH4l1P5WfRl4nbHRshrOPw+lzZH vj++MrQGc9BtdQS+wYPHkFpQ/rj8ONGQvyHX9sBla5dhWkyayJTVRHvr6ZatPvSd46PYZe 84Q1HFrrpUGt5xI1+4xjpOikyFVB3SWgK5omzhzGRTconf/oh3MgYg0OaDzOlhyceuPzMZ 9g4bYERw2CDwwGJufD+/o4QM93iHstm5gH64Nwy07dbznVNPc6tvYdLnrA7uLD1bEXUN1y k5/kNk3z80FmFUVOPYi0DRHunAJRLUqL5T/Qf2yhGLIpcotgPr/yfDW1WDitrg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651939661; a=rsa-sha256; cv=none; b=pGm18Cli2LohZNVenYFod1m4d2zSD7toVJAwe1lNHwodbk7OzYlFCLhczYsqv05rO/Eaf/ ewumNa8lyorvB/hIAJMLn/okSZ/SEUoEkBzszY8mutDrEN02HDss6Y3/c8W43yZx5LlNlu j+MXlkBqKzJODRIao2Znq5aqwAELTQApE7vgIntHrHxrj1YpKitaMLhk1x9jK60ehHTc1/ /4zha+FmdHalSTOzdWIwWYlAAEWTbl6fCpSurSRwLfMaWXc1v0Q4m9V1NyWnB1fh/mHB+4 V01OfJS7mkXYiuAk1m0jCPXW/nwGNbZw5K+oV8t+JOV7Pa4L6XvWnHS8MoRhKQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=UkaDGsss; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.40 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=UkaDGsss; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4E77110243 X-Spam-Score: -2.40 X-Migadu-Scanner: scn1.migadu.com X-TUID: THk0JSCQKoeO > =E2=80=9Cas an argument to @option{--system}=E2=80=9D maybe? Done. > This is my main issue: should we still accept any triplet, and simply > print a nicer error than currently when the glibc dynamic linker name is > unknown? > > Or should be be just as strict as above, at the risk of frustrating > developers porting stuff to new or unusual platforms? > > Or should there be an option to bypass this check? It's debatable for sure. However, now that glibc-dynamic-linker (and system->linux-architecture in an additional patch) are relying on (gnu platform) I think forcing the user to prompt a "supported" target, or to define a new platform, makes sense. If someone is adventurous enough to try something like: 'guix build --target=3Dnew-target hello', patching glibc-dynamic-linker is already most likely required. So now that glibc-dynamic-linker is relying on (gnu platforms), defining a new platform will not be much harder. > Maybe I=E2=80=99m overrating the usefulness of allowing users to pass in > arbitrary triplets, though the manual does suggest that when porting to > a new platform (info "(guix) Porting"). Thoughts? I adapted this documentation section in v2. > How about replacing: > > (let ((s (false-if-exception (first (member arg (systems)))))) > (if s =E2=80=A6)) > > with: > > (if (member arg (systems)) =E2=80=A6) Done, > Also, please remove final period in the error message passed to =E2=80=98= leave=E2=80=99. and done. Thanks, Mathieu