From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CI1QM9ulyGKYQQEAbAwnHQ (envelope-from ) for ; Fri, 08 Jul 2022 23:47:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yBYgM9ulyGJgUAEA9RJhRA (envelope-from ) for ; Fri, 08 Jul 2022 23:47:07 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 991141B9BD for ; Fri, 8 Jul 2022 23:47:07 +0200 (CEST) Received: from localhost ([::1]:52192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9voY-0001Dx-A2 for larch@yhetil.org; Fri, 08 Jul 2022 17:47:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9vnW-0001BK-I8 for guix-patches@gnu.org; Fri, 08 Jul 2022 17:46:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39438) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9vnW-0006TN-8b for guix-patches@gnu.org; Fri, 08 Jul 2022 17:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o9vnW-0006IG-4g for guix-patches@gnu.org; Fri, 08 Jul 2022 17:46:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56318] [PATCH] import: github: Fix updater. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 08 Jul 2022 21:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56318 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel Cc: 56318@debbugs.gnu.org Received: via spool by 56318-submit@debbugs.gnu.org id=B56318.165731671124114 (code B ref 56318); Fri, 08 Jul 2022 21:46:02 +0000 Received: (at 56318) by debbugs.gnu.org; 8 Jul 2022 21:45:11 +0000 Received: from localhost ([127.0.0.1]:33334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9vmg-0006Gs-S8 for submit@debbugs.gnu.org; Fri, 08 Jul 2022 17:45:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9vmf-0006GU-2U for 56318@debbugs.gnu.org; Fri, 08 Jul 2022 17:45:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54070) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9vmW-0005yB-H6; Fri, 08 Jul 2022 17:45:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=pTdxGUCNYLIeCTYan1s0I4YOBEDprZJxfUUeSprkmpE=; b=nDAWV69RvsqQ0jeLmPAJ QBwEIRCc1hE0pYMfohobHrHkikZMQotFNQGGyZ7JKsYKo3XqEhdnifoZXDcqo3+D6DhJrQTNZNaef seYdrovMw1oulphO9Tdsq6RlMSUMWZ2PCMeDqGrTaUDX+FaHtjchPv2WJ8+l6Ai5U8SOFde5lZH00 vHw/1CHWcSJuvxQdyLhQWz6w8W4ZIjVc1r5/3TR8BA01ppTNSOuA2N5bSETeAx7Ie6ZsOJj/Jzue6 9R84VmsxV0Ey2lNQ7W40yY/sDaqntfdyLPluaKvblI4RRp7OZ9TUjebdnsADteFpBxDMI4LAAgNlg I9sZ6aPoUrVA2g==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:62404 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9vmW-0007Gf-5O; Fri, 08 Jul 2022 17:45:00 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <49ed104eb9117af150eea008a2029cfae703c79a.1656574934.git.h.goebel@crazy-compilers.com> Date: Fri, 08 Jul 2022 23:44:58 +0200 In-Reply-To: <49ed104eb9117af150eea008a2029cfae703c79a.1656574934.git.h.goebel@crazy-compilers.com> (Hartmut Goebel's message of "Thu, 30 Jun 2022 09:42:21 +0200") Message-ID: <87k08ns2hx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657316827; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=pTdxGUCNYLIeCTYan1s0I4YOBEDprZJxfUUeSprkmpE=; b=da35gbLE1lAsITHe0IRrW+lbZCkuupoRDMBZi0FMxpkG2Ljht75wQn0EGH+XQ3FHk7AyM5 vyx05tRZ/M54ruBcx+Zz6p2ij5UFe4HIm4wO9o3zBZtogGKXV2ct1RBXwyH5ybH97cCOrq /xpRwWeIXIdIaG5DUcsKllQibE8YIRWZHsotXBr4wM9FQiq1YZQ5qq82LShDtumBtqdNl4 WFOpgdSJegvEWLxHACXxPboboG9sEsmSyLPIPfWCes2xOhKevAlc704Gi1DEawLhC0c9bg 5ya4B0WjW/b1bFIChMYUUOuYcAsShb6UOqlmI/rKAdU6pu5lbHJBS3qzW8wQLA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657316827; a=rsa-sha256; cv=none; b=PGqiw/Y6GUsIFJr2eisVfllP31K+kC6zb3HXP5DIEt/YGAWFTNpGqU0ilOzrmkMNVL8op2 fo9RXIUn/BfnxKYiGEyy5DzFvFs5COT9ZT3OtATma4Nhnirp5yJjTHv68tmK8+S2oT1Vco zSx4GYbeoM3krdDiEkZanH1c5mOAvZvV1kCXeBRyumF+5i35rFv93/dLan43wWjrWVTX8r YPdus+SBPT3sKiTjlE9/gsv8NAZuTn1YGohQHecNG9DsKI1J3zDmP5tix3fT6H5NV2ATdk i4X7+BInSuUa4aBDMvy1RwVSXpfXs0hIFBPYIY7A9+zQrtdM+6vUFM26S2r3tQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=nDAWV69R; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.25 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=nDAWV69R; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 991141B9BD X-Spam-Score: -5.25 X-Migadu-Scanner: scn0.migadu.com X-TUID: 8jdfnXitYmE7 Hi, Hartmut Goebel skribis: > * guix/import/github.scm(updated-url): For one one of the > cases add missing 'prefix' and set new version. Could you add an example of a case that is fixed by this change in the commit log? (Like =E2=80=9C=E2=80=98guix refresh foo=E2=80=99 would fail t= o find the new release of =E2=80=98foo=E2=80=99 before this change.=E2=80=9D) Also in the commit log: I=E2=80=99d suggest something like =E2=80=9CUse cor= rect URL scheme=E2=80=9D instead of =E2=80=9CFix updater=E2=80=9D, for clarity. Otherwise LGTM (assuming the URL scheme is correct), thanks! Ludo=E2=80=99.