From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8NwsKYso1WI4bwAAbAwnHQ (envelope-from ) for ; Mon, 18 Jul 2022 11:31:55 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id OGwoKYso1WLPWwEA9RJhRA (envelope-from ) for ; Mon, 18 Jul 2022 11:31:55 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 413181681E for ; Mon, 18 Jul 2022 11:31:55 +0200 (CEST) Received: from localhost ([::1]:34274 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oDN6Y-0000iq-DN for larch@yhetil.org; Mon, 18 Jul 2022 05:31:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDN5k-0000hy-Dr for guix-patches@gnu.org; Mon, 18 Jul 2022 05:31:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51424) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oDN5i-0000HX-Cl for guix-patches@gnu.org; Mon, 18 Jul 2022 05:31:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oDN5i-00052X-7D for guix-patches@gnu.org; Mon, 18 Jul 2022 05:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56382] [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid crashing on startup Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 18 Jul 2022 09:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56382 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Raghav Gururajan , 56382@debbugs.gnu.org, 20255@debbugs.gnu.org, Morgan.J.Smith@outlook.com Received: via spool by 56382-submit@debbugs.gnu.org id=B56382.165813661519294 (code B ref 56382); Mon, 18 Jul 2022 09:31:02 +0000 Received: (at 56382) by debbugs.gnu.org; 18 Jul 2022 09:30:15 +0000 Received: from localhost ([127.0.0.1]:49182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDN4w-000512-M6 for submit@debbugs.gnu.org; Mon, 18 Jul 2022 05:30:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDN4n-0004yo-LH; Mon, 18 Jul 2022 05:30:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59218) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDN4h-0008Fi-IX; Mon, 18 Jul 2022 05:29:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=cx/RkAi8vCzdWqXQ+zSox2x5BmqlDz+0CqSfENtLXr8=; b=WFH1BNxNKlFLi7BK0TZv 1261q4AFXq5UaE5Ue5X6fbpIBBvuJ8MBSxg1yFQZgSGTgnIYlhVFMqxiVUYewNH2JGyN/uM87zwtr MJkvjXsBUekyRepytBeTfSQPS8QfBdQ6UkyNv+zFKPRocGjwQ2hgNUKcXa2zITxTLcqpWtOj2EKHP bOyWQlSNGPzUiJRfMQZavtaOGp5JPso/4T4szgUa7l9l+4+9j9H06kd83Zw9Q0TxL2i/UJ4JCegsR iXmm/SQS2MEDMwtN54DKEt1ai0Qy6vOgQnj4iFLO1P/HJNE5gPcWMuNl36hT6C5o+CuAAKO3KgfaK 01kYpwrxbPLOIQ==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=41642 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDN4g-0000R6-NP; Mon, 18 Jul 2022 05:29:59 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87sfn6asfz.fsf@gnu.org> <877d4e8r79.fsf@gnu.org> <87tu7hsupr.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: =?UTF-8?Q?D=C3=A9cadi?= 30 Messidor an 230 de la =?UTF-8?Q?R=C3=A9volution,?= jour de la =?UTF-8?Q?Chal=C3=A9mie?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 18 Jul 2022 11:29:55 +0200 In-Reply-To: <87tu7hsupr.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 15 Jul 2022 21:38:08 -0400") Message-ID: <87k08a3h0s.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658136715; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=cx/RkAi8vCzdWqXQ+zSox2x5BmqlDz+0CqSfENtLXr8=; b=UaRk7EBTZwR+9909J5NsGyp5m8gAKDatnWZFMgrq/MpXT+8WbJhIOLdcDJcy4xqt1hD7eE FTX4inyk0Jv3o4zJY8hyF5Y4wIUCL8+6DrE0PY1jEVEh49G7LWCBPqlyEEhrX8kUYGWryX QVW2dGl/rnYgkN8iYuq7/fLBgW3XG7cUv3WktFUMt7TplaQBpSzhUVU7B3zCpx2bItzkvO EACtgHzTQhhRjckZcOlefm1N5Ph6IlssbkZUuTzSQknjqLlzkPpqfPFuAz587aCssx026B am6slvA8LlLxKiOocTHfpfXOAqMIL+J1IlapZDmW8tYM5OWSw5jcgq8gvDYRNg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658136715; a=rsa-sha256; cv=none; b=E4qZKrEcfK3M+A/gGm8XRwQDh2WlWEOK7VQkLjMHyneSR/GFSBv7VoVjWr5K/1pJOowR8t PjwJEw0/72cm/zRR8GYUWnlyyem46numkIfT4srSZYUsmH8JfXdUByxLlXd3RiBHjHrYhF wKpTTGxsA0RozjZTunAL6Tq7A+9p08C4w3w6tGZnC3UddYIEwFShkWL/SxNk2tx7b5aEGt BqEjeU8rMbMZi2hT6Ri5XOSZsGJD1ndFwQ/SIx4n4JP+24P0NSr6ir5/4DmVp3KmuyMxh8 Vf0eXKG/GY9zS3Q+PKkpBiwlz3CVlclIzchmm7+PDCxZt6tJ7dnZ++inI2dblQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=WFH1BNxN; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.93 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=WFH1BNxN; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 413181681E X-Spam-Score: -2.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: MSy24vRTL+kz Hi, Maxim Cournoyer skribis: > Hi Ludovic, > > Ludovic Court=C3=A8s writes: > >> Hi, >> >> "Raghav Gururajan" skribis: >> >>>> Does simply adding =E2=80=98hicolor-icon-theme=E2=80=99 to =E2=80=98in= puts=E2=80=99 fix the issue? >>> >>> Most gtk-based apps expect hicolor-icon-theme and adwaita-icon-theme to= be in the profile. Adding these in either system or user profile would pre= vent this error from occurring. >> >> Right, so the proposed patch (adding =E2=80=98hicolor-icon-theme=E2=80= =99 to =E2=80=98inputs=E2=80=99, >> not =E2=80=98propagated-inputs=E2=80=99) shouldn=E2=80=99t make any diff= erence I guess? > > I think it works as inputs because of our wrappers (perhaps > XDG_DATA_DIRS)? But it's kind at odds with our policy which is to let > users manage icons themselves. Yeah. > Probably because of #20255 that wouldn't help currently (system and user > profiles are not merged), but if we fixed that bug we could make the > situation better by adding 'hicolor-icon-theme' to the default packages > of our desktop system templates. Right. BTW, the reason the solution at was rejected could be revisited. Since that time, search paths made it into the manifest itself, which brings a speed up: --8<---------------cut here---------------start------------->8--- $ sudo sh -c 'echo 3 > /proc/sys/vm/drop_caches ' $ time guix package -p ~/.guix-home/profile -p /run/current-system/profile = --search-paths > /dev/null real 0m0.540s user 0m0.131s sys 0m0.063s $ time guix package -p ~/.guix-home/profile -p /run/current-system/profile = --search-paths > /dev/null real 0m0.135s user 0m0.130s sys 0m0.024s --8<---------------cut here---------------end--------------->8--- Thoughts? Ludo=E2=80=99.