From: "Ludovic Courtès" <ludo@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 59171@debbugs.gnu.org
Subject: [bug#59171] [PATCH] services: guix-build-coordinator: Remove duplicate log timestamp.
Date: Mon, 14 Nov 2022 18:26:10 +0100 [thread overview]
Message-ID: <87k03xo3bh.fsf@gnu.org> (raw)
In-Reply-To: <20221110140852.24447-1-mail@cbaines.net> (Christopher Baines's message of "Thu, 10 Nov 2022 14:08:52 +0000")
Hi,
Christopher Baines <mail@cbaines.net> skribis:
> * gnu/services/guix.scm (guix-build-coordinator-shepherd-services,
> guix-build-coordinator-agent-shepherd-services,
> guix-build-coordinator-queue-builds-shepherd-services): Set
> %current-logfile-date-format to "".
[...]
> + (start #~(lambda args
> + (parameterize ((%current-logfile-date-format ""))
> + (apply
> + (make-forkexec-constructor
> + (list #$(make-guix-build-coordinator-start-script
> + database-uri-string
> + allocation-strategy
> + "/var/run/guix-build-coordinator/pid"
> + package
> + #:agent-communication-uri-string
> + agent-communication-uri-string
> + #:client-communication-uri-string
> + client-communication-uri-string
> + #:hooks hooks
> + #:parallel-hooks parallel-hooks
> + #:guile guile))
> + #:user #$user
> + #:group #$group
> + #:pid-file "/var/run/guix-build-coordinator/pid"
> + ;; Allow time for migrations to run
> + #:pid-file-timeout 60
> + #:environment-variables
> + `(,(string-append
> + "GUIX_LOCPATH=" #$glibc-utf8-locales "/lib/locale")
> + "LC_ALL=en_US.utf8"
> + "PATH=/run/current-system/profile/bin") ; for hooks
> + #:log-file "/var/log/guix-build-coordinator/coordinator.log")
> + args))))
It’s not pretty but I don’t have anything else to offer.
Perhaps you can make it slightly less verbose by writing it like this:
(start #~(lambda ()
;; Arrange so that shepherd does not add a timestamp to
;; the logs produced by the Coordinator.
(parameterize …
(fork+exec-command (list …) …))))
There are other services in a similar situation. I wonder what we
should recommend.
Ludo’.
next prev parent reply other threads:[~2022-11-15 0:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 14:08 [bug#59171] [PATCH] services: guix-build-coordinator: Remove duplicate log timestamp Christopher Baines
2022-11-14 17:26 ` Ludovic Courtès [this message]
2022-11-20 12:06 ` bug#59171: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k03xo3bh.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=59171@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).