From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GM4XIDsBnGMY7wAAbAwnHQ (envelope-from ) for ; Fri, 16 Dec 2022 06:25:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 4MUMIDsBnGN99QAAauVa8A (envelope-from ) for ; Fri, 16 Dec 2022 06:25:15 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 34640127CF for ; Fri, 16 Dec 2022 06:25:15 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p63DV-0002ou-14; Fri, 16 Dec 2022 00:25:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p63DT-0002og-5m for guix-patches@gnu.org; Fri, 16 Dec 2022 00:25:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p63DS-0001Dp-MK for guix-patches@gnu.org; Fri, 16 Dec 2022 00:25:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p63DS-0003a4-3R for guix-patches@gnu.org; Fri, 16 Dec 2022 00:25:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60068] bug#60069: [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 16 Dec 2022 05:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60068 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: me@tobias.gr, 60068@debbugs.gnu.org Received: via spool by 60068-submit@debbugs.gnu.org id=B60068.167116826813746 (code B ref 60068); Fri, 16 Dec 2022 05:25:02 +0000 Received: (at 60068) by debbugs.gnu.org; 16 Dec 2022 05:24:28 +0000 Received: from localhost ([127.0.0.1]:47090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p63Ct-0003Zd-UH for submit@debbugs.gnu.org; Fri, 16 Dec 2022 00:24:28 -0500 Received: from mail-qt1-f181.google.com ([209.85.160.181]:43619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p63Cq-0003ZV-13 for 60068@debbugs.gnu.org; Fri, 16 Dec 2022 00:24:26 -0500 Received: by mail-qt1-f181.google.com with SMTP id a16so1925797qtw.10 for <60068@debbugs.gnu.org>; Thu, 15 Dec 2022 21:24:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=82xupxKQ7m07vG3SKiXE4zfJr3nbNMxOwCXiFHeGNB4=; b=VpAAa8gAHHEKLgo4Y4i9cKQph7pPUekii0ue9LSEK+Rvq6zcOrYjY7Usi0Rf2486HC qthgDLOuIISk90+bf9l9+VGynddizuA1nMjqcABEdfD4Zwoye/bc3oSGjc3zVXlVlge3 obx85nNuJsDapYa31/0yliPGlIa+XiCp9/kpME4FgDBwH/PW5SMOBCpdhAtXE9cGDYOR S6WnzexYlVNzBq3p/Q1wA/041Tjj8GGAR/ryJMkd0loM6jlBLo82b/KsbHXa7uGq2XYa nbpPDqD3ciGLq3yH64LWvVzXIJvegq38LlmzHHNNOpU4YD5U6APKX5aG+Vug05n7hEgg HsMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=82xupxKQ7m07vG3SKiXE4zfJr3nbNMxOwCXiFHeGNB4=; b=y0R69uBUEifi0HlbJGQDqrd2XZETThWMDqAu9aYImCs84hIfmkJ3Xo6raY/+ezHYv5 QQU+kFfC/HRWUi4a32PVulEE/8pos6KmYmhN2jDtvGVIDE9t5Srpp5ANMkhUSEy38ULE 6Lq6MtL1tsHjG+eAKDvkgqU57knaomlBENSxogQbfvzd3lPadMdIw1r14CT5HYHV17hM Eij6hYoRwhyVmeYiq8PyNFkc2zPt0sb6UwKcuhUJP1HEtpFD4n23tKzb/KXCjoulQykw xQgrtwP+oTILT2lM87VNzBJxPb1V2XyAowEKgsgRjPXEn/783mykdka6jJfy3QAlvoo+ GZyg== X-Gm-Message-State: ANoB5pmSTy8LzRgei5HbUR62S+z6nw7YUFCF7ZBw2e99ndMZRFV1abmn oNGyumqlzZZpcj6dyhVan0c= X-Google-Smtp-Source: AA0mqf7aVrRhZT6v3L7sVTvpcdIgTnjkjQNH/lCdS2mRDP9PbxY4+7WmhPHfw7dEQVUGTMp5k0a8DA== X-Received: by 2002:ac8:7214:0:b0:3a8:2f0d:cc34 with SMTP id a20-20020ac87214000000b003a82f0dcc34mr10791221qtp.25.1671168258189; Thu, 15 Dec 2022 21:24:18 -0800 (PST) Received: from hurd (dsl-10-129-63.b2b2c.ca. [72.10.129.63]) by smtp.gmail.com with ESMTPSA id w7-20020ac86b07000000b003a50d92f9b4sm780469qts.1.2022.12.15.21.24.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Dec 2022 21:24:17 -0800 (PST) From: Maxim Cournoyer References: <20221214155603.29381-1-maxim.cournoyer@gmail.com> <20221214204640.16879-1-maxim.cournoyer@gmail.com> <871qp0pw4y.fsf_-_@gnu.org> Date: Fri, 16 Dec 2022 00:24:16 -0500 In-Reply-To: <871qp0pw4y.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Thu, 15 Dec 2022 15:41:17 +0100") Message-ID: <87k02rc45b.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671168315; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=82xupxKQ7m07vG3SKiXE4zfJr3nbNMxOwCXiFHeGNB4=; b=k5iNp2pxwXJhzF+mkbk0ieDOz03UAwVSN9hN1JTaBR2nWerUdifGop7txDwf1j+8M8Eo3s 2Alk06uxr8H2p79mdQCTSTGoc1oPkG0s5FqsgzgvsOoJG5gnxH/fzEmEyK6PFL4itpNGie c3qZnzgQF8/K0b7FOUZCs7ZsTWFe+qUKxpweQTzUVKIfmrQi9OQuAlf5MU+QWSGbDr3tOx R9J4B6idoA2yarQgEPrd0/WkMyUzfNzfW/9jq5O5If79E7CAA9IBfPRicSa3NiyG6vXunk eamoLatuZlqkOvaVAxW1ScEZC5xDQQdb+Nw4K7XMzobgR7HEstBWmIyGbIzqZQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=VpAAa8gA; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671168315; a=rsa-sha256; cv=none; b=bTrsfTrDZxJFi9h0ylRZVbYTb9DRhyXisuvBqaZtPg2/qtKsbeZKozvCAwjRakB+p9YTTT kReavaQayDU0SOt9MXkecXsjwNla/KXxJkNJWSsqoUaBKhf19wiivWvgPJGon9g8hAllBK CgPSN32o+DDKDQX/c1djzqxb7tuPVITHOSmULScoQKXTQ0gM6NPrjzk0ycGkgjHwyfL+4J LFC/mlhDt1Yb8V1+wkIgQuJKV0A0isAwELeC+3OCTgbedF9fXd2oZ2ehsk8mlvLqTi3Omt 1LMCMNyknP5gn9b1qKuUQrEiilFLJOjHh4W50CVZ0wAHf6Ot06ZFaZtXlpTn7w== X-Spam-Score: 6.03 X-Migadu-Queue-Id: 34640127CF X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=VpAAa8gA; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.03 X-TUID: dS0Jr8BLJogV Hi Ludo, Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >> * etc/guix-install.sh: (REQUIRE): Add missing "useradd" command. > > [...] > >> * etc/guix-install.sh (chk_require): Directly exit in case of errors in >> chk_require, instead of relying on 'set -e'. > > These two patches LGTM; you can add them to =E2=80=98master=E2=80=99 and = that way people > will benefit from it when installing 1.4.0. Done, for the two patches mentioned above, leaving the GUIX_ALLOW_OVERWRITE one open for further discussions. --=20 Thanks, Maxim