From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yHcxKp/Xz2MSUgEAbAwnHQ (envelope-from ) for ; Tue, 24 Jan 2023 14:05:35 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id GNPvKZ/Xz2Pv8wAAauVa8A (envelope-from ) for ; Tue, 24 Jan 2023 14:05:35 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8943B3EE8C for ; Tue, 24 Jan 2023 14:05:35 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKIXE-0004Zn-HG; Tue, 24 Jan 2023 07:36:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKIWy-0004R7-9R for guix-patches@gnu.org; Tue, 24 Jan 2023 07:36:09 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKIWx-0001Mq-AN for guix-patches@gnu.org; Tue, 24 Jan 2023 07:36:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pKIWx-0003Lq-0V for guix-patches@gnu.org; Tue, 24 Jan 2023 07:36:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61010] [PATCH] gnu: Add icewm Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 24 Jan 2023 12:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61010 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andy Tai , 61010@debbugs.gnu.org Received: via spool by 61010-submit@debbugs.gnu.org id=B61010.167456371612806 (code B ref 61010); Tue, 24 Jan 2023 12:36:02 +0000 Received: (at 61010) by debbugs.gnu.org; 24 Jan 2023 12:35:16 +0000 Received: from localhost ([127.0.0.1]:56046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKIWB-0003KO-Vm for submit@debbugs.gnu.org; Tue, 24 Jan 2023 07:35:16 -0500 Received: from mail-wr1-f46.google.com ([209.85.221.46]:33302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKIW7-0003Je-ED for 61010@debbugs.gnu.org; Tue, 24 Jan 2023 07:35:11 -0500 Received: by mail-wr1-f46.google.com with SMTP id q5so9068893wrv.0 for <61010@debbugs.gnu.org>; Tue, 24 Jan 2023 04:35:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=6eb0O5VetjGKr8vHBY3a549gC3nPtal/AfcN8q9az18=; b=fbekIOA94rMh0F5MyY9NAS3iblX9UiXNYdtvcD4mr6T+iVN7q2b0Z/XRGSQ187LR4t a/rNvT1uLkF7n7InBB3aCY2DQU2B33LH4Jz3pEaJ6vkQj16dbMxCoOa9hKkU8P30ptGo rIB8FFveTVLfq8SQS8mvrQsX/L0kEPObBde3KBqmAjzfaFt6Ihyt+2y+layq/H5+JO8t 62ZFsHMcV7sEZwRk/95MxPWwS+EXzsKixA6hF/HYENnM/ztbQtxgPxW54tO/3Pc11xih IGHrYfWTM4BDOiSHcSQJQeWShXBdLEwwcivfQe7etGJ19BrUL/nqSoZXute82OAx9b4n z5Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6eb0O5VetjGKr8vHBY3a549gC3nPtal/AfcN8q9az18=; b=SG05dxfKWxy3YX5Ez1TzT/kg2fcxri9eQvOY2UEgYDFEOjBkh55UqJ8pAqOeQSFvqe bMF5wXFi1JrCtgk0d0zja7MyPFkmuypNHxb+KhoxSoCeqrFFjH1ylgnaUOGF252xTn+E nSjCY6e0gsRV1e/8fxsG+AiziS90c+mPfxHZBMJBGRe00GuY3TMvKVvsoscgFOTq7NwD nus5A1mgZqYV4TfhYd9XvjdQKaAh2kHC4O/SwDolA8LLtDXGZu5MpsbbxZIV7aPtqGhc PU9AheQhL3wQ2IIIFwAW9PYBlB0H3BqMcIFPkToxJy2VtGg2VhYGVp0IGpQCkBXHhFii hvvw== X-Gm-Message-State: AFqh2kqhL0capI19jnWfKoS/BTBo4R23vVhsYxrds3avL+jOwEEiiFeE j6Z5iHCt2wnXKiUhK2xye/arRD46ckg= X-Google-Smtp-Source: AMrXdXuzXTlB3tpUaJEaJR8AKK+32vZYN4UUFiGZN9KwIJIpqxdda+UYZNiIr8WJDHzzQpwPe8tmYA== X-Received: by 2002:a05:6000:1e0d:b0:236:c60b:c766 with SMTP id bj13-20020a0560001e0d00b00236c60bc766mr4372164wrb.6.1674563705856; Tue, 24 Jan 2023 04:35:05 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id h16-20020a5d5050000000b002423dc3b1a9sm1836666wrt.52.2023.01.24.04.35.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 04:35:05 -0800 (PST) From: Simon Tournier In-Reply-To: References: Date: Tue, 24 Jan 2023 13:26:14 +0100 Message-ID: <87k01cp195.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674565535; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=6eb0O5VetjGKr8vHBY3a549gC3nPtal/AfcN8q9az18=; b=m3bFdbWST9Q2MY3sP9RmhBDu/0iOvxsbXpmSOhFv/LdXrqbY4Q+xK+tpwLnsrWP6IyuY77 zerUV/60xss00ycNmIrav7IWiZVdC6yxEkTkui1AUVbEWjM6tesfVekwWfWb4YMSJiyESH kGESocslFcZXpfnymU9vlq2AKx2zMyhUGqLNWnwcFLCBaF8m6iHfgWmdU4jsftlOTDdBAc xuGiW3Jr71vOwjvK35Mo9biUT9EeuLQ3CeZwkjEvBTe+vCMpUYd4KsjB6E2VissVPtycwg 4iJ2aT6ZdKfjbygPrA1mw7JdqvUgmi5bjzOgXs1Hwnxa2gwYFDstoLKkpEAu5w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=fbekIOA9; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674565535; a=rsa-sha256; cv=none; b=eTmiNAA8xrB5r+oRBPlsaQ79rDmXB4dIPhmkNu3FcjqeQNu6Wd9PCd90yfv4alzkrH+AqF Q//e42z6rfHUbdCJQ1kpLkrzLBpXkarwtWwXtS1PtA+TpQgGS1v+MnmTuGCvOepBSENSel 966YIEHBSzXBrPqF8ZDHC0cm6BXgcSEqhKChtasb06+ijMEy+KcWjQKqzqpKSnizRzwW7p 2Y+ahZYdtg+T1Lbxv9FnJ8pVSBdLZAdRsy81DmT5GLQwwqn/N/FR7nlRYeBfva6hqZgmnf tt6iSuVtDkr/4dtSiKjBi6+yX/ECRbdjo0wT49yp0RTy5+QW9n9ZnBGXnaF0Mw== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=fbekIOA9; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Spam-Score: 7.41 X-Spam-Score: 7.41 X-Migadu-Queue-Id: 8943B3EE8C X-TUID: 70e89JbwyG2L Hi, Thanks for the follow up. :-) The patch builds fine and it LTGM except one minor point. On dim., 22 janv. 2023 at 12:37, Andy Tai wrote: > + (source (origin > + (method url-fetch) > + (uri (string-append > + "https://github.com/ice-wm/icewm/releases/download/" > + version "/icewm-" version ".tar.lz")) This archive contains generated .gmo which are not in the source code [1] and I do not know what is the usual Guix policy about that. Do we re-generate them? Other said, these files are in the archive tar.gz [2]. 1: 2: > \ No newline at end of file This patch does not apply to current master. From my point of view, it is worth to provide the base-commit (see --base option of git-format-patch or git-send-email). And it helps if the new package is not added to the end of the file. For instance, I would put it between i3lock-fancy and xmonad-next. Cheers, simon