From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MBKCNg3K52MsAAAAbAwnHQ (envelope-from ) for ; Sat, 11 Feb 2023 18:02:05 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id IPlVNg3K52NjdQEAauVa8A (envelope-from ) for ; Sat, 11 Feb 2023 18:02:05 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9E640396E7 for ; Sat, 11 Feb 2023 18:02:05 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQtFI-00058m-5v; Sat, 11 Feb 2023 12:01:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQtFG-00057R-F1 for guix-patches@gnu.org; Sat, 11 Feb 2023 12:01:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQtFG-00019F-6H for guix-patches@gnu.org; Sat, 11 Feb 2023 12:01:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pQtFG-0004ew-1v for guix-patches@gnu.org; Sat, 11 Feb 2023 12:01:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61434] [PATCH] gnu: Add emacs-pasp-mode. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 11 Feb 2023 17:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61434 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 61434@debbugs.gnu.org Received: via spool by 61434-submit@debbugs.gnu.org id=B61434.167613480817824 (code B ref 61434); Sat, 11 Feb 2023 17:01:02 +0000 Received: (at 61434) by debbugs.gnu.org; 11 Feb 2023 17:00:08 +0000 Received: from localhost ([127.0.0.1]:43006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQtEN-0004dQ-Lm for submit@debbugs.gnu.org; Sat, 11 Feb 2023 12:00:07 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:54069) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQtEL-0004bH-QP for 61434@debbugs.gnu.org; Sat, 11 Feb 2023 12:00:06 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 4399D60002; Sat, 11 Feb 2023 16:59:57 +0000 (UTC) From: Nicolas Goaziou References: <602f2c0db9881fdd663c9919b5783db950ac900b.camel@gmail.com> Date: Sat, 11 Feb 2023 17:59:55 +0100 In-Reply-To: <602f2c0db9881fdd663c9919b5783db950ac900b.camel@gmail.com> (Liliana Marie Prikler's message of "Sat, 11 Feb 2023 16:15:00 +0100") Message-ID: <87k00ouohg.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676134925; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=cFCoVIdgjQgcRuQ0UHS2tknK19ONJGPjyxkncJ5P54U=; b=Dx98EiSXXUwBTzdeJyZnwhHNYEDSdw50rhSX9AcuLsdTgUiPXVIe/GyEdrLnapwndFYbiL eTaEzgDBc8qZAj5P/6kSzfTnN6Ao8iO4+6awOuGF4r1D7rB6d1bvLyclMUZ1laIolEQs/e 2oDzaHODYnragJqt9IjM0y6tzuVlRCR9yiv8wZD8agbfIBeGP0co1GFX0fV899FQ2ggfi7 KyOjnKB0NCeUFMau/Kkt44M3L80/X1/S9NtUsY0qh0q2OsYBv7BfR1bj0RGw63VyK/PHrz ANlRn2iroShqbgLm9U2XXHQNSeP+SsnQFfl7pZVEZrYn5QmpV/DJszB8KmcP9g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676134925; a=rsa-sha256; cv=none; b=FlJBHJ1uhtbgT4EVH274aHTf8guXOBpdndvI+QP8Ugp9sUPU1qJbDMxTZ1CLBJKPBqqxAv FA3ZT73e+VwVakcgwoFdQWvfPGtmHXymJptBoUa8tWp/ztBZIZ2xAvH56jIelGcmkaam4G hnSo3T+g43xd+U41lFm7Wr89ZGrNnUFh1VVLGhWU2fz8MeHYqTf3/VlmiKq3fqG6Dw0A8I wePp0YeP5MhNwnY3l9f5fwIY/wd4/HJ3bv83z9tkESRn5LOp8ZVTK2oE+hqLA0crfSNPu4 lpOvadngUUkeX3/rysnvf3vAUV0TKFgMGpLV7GKvhz/uraQkUFlYkrQ877A0bw== X-Migadu-Queue-Id: 9E640396E7 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Spam-Score: -3.96 X-Spam-Score: -3.96 X-TUID: VGHQlgsLz7ZF Hello, Liliana Marie Prikler writes: > * gnu/packages/patches/emacs-pasp-mode-quote-file-names.patch: New file. > * gnu/local.mk: Register it here. > * gnu/packages/emacs-xyz.scm (emacs-pasp-mode): New variable. Thank you. Some comments follow. > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/santifa/pasp-mode.git") You can remove the ".git" suffix. > + (add-after 'unpack 'defconst-version > + (lambda _ > + (emacs-batch-edit-file "pasp-mode.el" > + '(progn > + (search-forward-regexp > + "(defcustom pasp-mode-version \"[^\"]*\"[ > + ]*\\(\"[^\"]*\"\\)[^()]*)") > + (let ((docstring (match-string 1))) > + (backward-sexp) > + (kill-sexp) > + (insert (format "(defconst emacs-pasp-version \"%s\" %s)" > + #$version docstring)) > + (basic-save-buffer)))))) This dance is not necessary. You can simply use `emacs-substitute-variables', change the value, and keep the defcustom. A defconst is not a constant in Elisp anyway. > + (synopsis "Major mode for editing Answer Set Programs.") You can remove the final full stop. It may be clearer to also mention "Potassco" so as to understand better the PASP acronym. > + (description > + "This package provides a major mode for editing answer set programs, > +in particular ones that can be solved by @command{clingo}.") I suggest "Answer Set Programs", since this seems to be a very specific thing. I didn't build it, but LGTM. Regards, -- Nicolas Goaziou