* [bug#59927] [PATCH] gnu: go-gopkg-in-yaml-v3: update after hash mismatch
@ 2022-12-09 15:04 Gleb Zakharov
2023-02-15 10:51 ` bug#59927: " Tobias Geerinckx-Rice via Guix-patches via
0 siblings, 1 reply; 2+ messages in thread
From: Gleb Zakharov @ 2022-12-09 15:04 UTC (permalink / raw)
To: 59927; +Cc: Gleb Zakharov
It seems the authors of go yaml package made a bugfix
in the repository and updated the v3 branch. Because of
the resulting hash mismatch, a docker package couldn't
be built.
I updated the hash, changed a version from
a branch of the repository to the v3.0.1 tag
and applied guix style command.
---
gnu/packages/golang.scm | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 70ddef52f1..b49fe7566d 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -38,6 +38,7 @@
;;; Copyright © 2022 Dhruvin Gandhi <contact@dhruvin.dev>
;;; Copyright © 2022 Nicolas Graves <ngraves@ngraves.fr>
;;; Copyright © 2022 ( <paren@disroot.org>
+;;; Copyright © 2022 Gleb Zakharov <snyssfx@gmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -4520,21 +4521,20 @@ (define-public go-gopkg-in-yaml-v2
(define-public go-gopkg-in-yaml-v3
(package
(name "go-gopkg-in-yaml-v3")
- (version "3")
- (source
- (origin
- (method git-fetch)
- (uri (git-reference
- (url "https://gopkg.in/yaml.v3")
- (commit (string-append "v" version))))
- (file-name (git-file-name name version))
- (sha256
- (base32 "06f4lnrp494wqaygv09dggr2dwf3z2bawqhnlnnwiamg5y787k4g"))))
+ (version "3.0.1")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://gopkg.in/yaml.v3")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "01b0wjb7yzv8wzzz2iim8mjpkwjnykcanrwiq06pkl89lr6gv8hn"))))
(build-system go-build-system)
(arguments
'(#:import-path "gopkg.in/yaml.v3"))
- (native-inputs
- (list go-gopkg-in-check-v1))
+ (native-inputs (list go-gopkg-in-check-v1))
(home-page "https://gopkg.in/yaml.v3")
(synopsis "YAML reader and writer for the Go language")
(description
base-commit: 0ffa501f2b3e83ae56e9c2bd31418439090e869a
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#59927: [PATCH] gnu: go-gopkg-in-yaml-v3: update after hash mismatch
2022-12-09 15:04 [bug#59927] [PATCH] gnu: go-gopkg-in-yaml-v3: update after hash mismatch Gleb Zakharov
@ 2023-02-15 10:51 ` Tobias Geerinckx-Rice via Guix-patches via
0 siblings, 0 replies; 2+ messages in thread
From: Tobias Geerinckx-Rice via Guix-patches via @ 2023-02-15 10:51 UTC (permalink / raw)
To: 59927-done
[-- Attachment #1: Type: text/plain, Size: 795 bytes --]
Hi Gleb,
Thanks for this fix! I've applied it with suitable delay to the
master branch.
I added a GNU ‘Change Log’ line to follow our standards[1].
Trivial in this case but always required:
* gnu/packages/golang.scm (go-gopkg-in-yaml-v3): Update to
3.0.1.
Don't mix unrelated changes: ‘guix style’ turned this
trivially-audited patch:
-(version "3")
+(version "3.0.1")
-(base32 "foo")
+(base32 "bar")
into a 20-line diff :-)
Unfortunately, such changes are not considered copyrightable by
current standards.
I disagreed with ‘guix style's’ mangling of the source field, so I
just dropped it entirely.
Thanks again!
T G-R
[1]:
https://guix.gnu.org/en/manual/devel/en/html_node/Submitting-Patches.html#Submitting-Patches
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-15 11:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-09 15:04 [bug#59927] [PATCH] gnu: go-gopkg-in-yaml-v3: update after hash mismatch Gleb Zakharov
2023-02-15 10:51 ` bug#59927: " Tobias Geerinckx-Rice via Guix-patches via
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).