unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Simon Tournier <zimon.toutoune@gmail.com>
Cc: 62008@debbugs.gnu.org
Subject: [bug#62008] [PATCH 0/2] Update Disarchive to 0.5.0
Date: Tue, 07 Mar 2023 10:49:02 +0100	[thread overview]
Message-ID: <87jzzsevsh.fsf_-_@gnu.org> (raw)
In-Reply-To: <20230306191950.3639176-1-zimon.toutoune@gmail.com> (Simon Tournier's message of "Mon, 6 Mar 2023 20:19:49 +0100")

Hi Simon,

Simon Tournier <zimon.toutoune@gmail.com> skribis:

> * gnu/packages/backup.scm (disarchive)[arguments]: Add phase after install
> to wrap program.
> [inputs]: Add guile-gcrypt and guile-lzma.
> [propagated-inputs]: Remove it.

For this package, I have a slight preference for keeping propagated
inputs so that one can use Disarchive as a library.

WDYT?

Some comments while at it…

[...]

> +              (let* ((effective
> +                      (read (open-pipe* OPEN_READ
> +                                        (string-append #$guile-3.0 "/bin/guile")
> +                                        "-c" "(write (effective-version))")))

(guix build guile-build-system) exports ‘target-guile-effective-version’
to do that; it’s more convenient.

> +                     (modules (list #$output
> +                                    #$guile-bytestructures
> +                                    #$guile-gcrypt
> +                                    #$guile-lzma))

This should use (this-package-input "guile-bytestructures“) and similar,
for consistency.

Ludo’.




  parent reply	other threads:[~2023-03-07  9:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 19:18 [bug#62008] [PATCH 0/2] Update Disarchive to 0.5.0 Simon Tournier
2023-03-06 19:19 ` [bug#62008] [PATCH 1/2] gnu: disarchive: Wrap program instead of using propagated inputs Simon Tournier
2023-03-06 19:19   ` [bug#62008] [PATCH 2/2] gnu: disarchive: Update to 0.5.0 Simon Tournier
2023-03-07  9:51     ` [bug#62008] [PATCH 0/2] Update Disarchive " Ludovic Courtès
2023-03-07  9:49   ` Ludovic Courtès [this message]
2023-03-07 10:43     ` Simon Tournier
2023-03-10  8:17       ` Ludovic Courtès
2023-03-10 11:41         ` Simon Tournier
2023-03-10 16:44           ` Ludovic Courtès
2023-08-16 17:28             ` Simon Tournier
2023-08-18 13:56               ` Ludovic Courtès
2023-08-18 15:03                 ` Simon Tournier
2023-08-19  8:57                 ` Simon Tournier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzzsevsh.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=62008@debbugs.gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).