[bug#61018] [PATCH 0/2] Add pcsc-tools, and missing dependency perl-pcsc

[Maxim Cournoyer <maxim.cournoyer@gmail.com>]

Hi,

Jake Leporte <jakeleporte@outlook.com> writes:

> * gnu/packages/perl.scm (perl-pcsc): New variable.
> ---
>  gnu/packages/perl.scm | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index b6fb81e..a1a9983 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -86,6 +86,7 @@ (define-module (gnu packages perl)
>    #:use-module (gnu packages python)
>    #:use-module (gnu packages readline)
>    #:use-module (gnu packages sdl)
> +  #:use-module (gnu packages security-token)
>    #:use-module (gnu packages textutils)
>    #:use-module (gnu packages video)
>    #:use-module (gnu packages web)
> @@ -12269,6 +12270,41 @@ (define-public perl-path-iterator-rule
>  arduous to type for one-liners.")
>      (license license:asl2.0)))
>  
> +(define-public perl-pcsc
> +  (package
> +    (name "perl-pcsc")
> +    (version "1.4.14")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "mirror://cpan/authors/id/W/WH/WHOM/pcsc-perl-" version
> +                    ".tar.bz2"))
> +              (sha256
> +               (base32
> +                "17f6i16jv6ci6459vh6y3sz94vgcvykjjszcl4xsykryakjvf8i7"))))
> +    (build-system perl-build-system)
> +    (arguments
> +     (list
> +           ;; The tests for this package require access to a
> +           ;; card reader with a card inserted, so they won't be
> +           ;; possible to run in the build environment
> +           #:tests? #f
> +           #:phases #~(modify-phases %standard-phases
> +                        (add-after 'unpack 'patch-dlopen
> +                          (lambda* (#:key inputs #:allow-other-keys)
> +                            (substitute* "PCSCperl.h"
> +                              (("libpcsclite.so.1")
> +                               (search-input-file inputs
> +                                                  "/lib/libpcsclite.so.1"))))))))
> +    (native-inputs (list pkg-config))
> +    (inputs (list pcsc-lite))
> +    (synopsis "Perl library for PC/SC")
> +    (description
> +     "This library allows communication with a smart card using PC/SC from a Perl
> +script.")
> +    (home-page "https://pcsc-perl.apdu.fr/")
> +    (license license:gpl2+)))
> +
>  (define-public perl-pod-constants
>    (package
>      (name "perl-pod-constants")

I've installed this change with the following small modification
(reword the comment and end it with a period):

--8<---------------cut here---------------start------------->8---
modified   gnu/packages/perl.scm
@@ -12339,17 +12339,16 @@ (define-public perl-pcsc
     (build-system perl-build-system)
     (arguments
      (list
-           ;; The tests for this package require access to a
-           ;; card reader with a card inserted, so they won't be
-           ;; possible to run in the build environment
-           #:tests? #f
-           #:phases #~(modify-phases %standard-phases
-                        (add-after 'unpack 'patch-dlopen
-                          (lambda* (#:key inputs #:allow-other-keys)
-                            (substitute* "PCSCperl.h"
-                              (("libpcsclite.so.1")
-                               (search-input-file inputs
-                                                  "/lib/libpcsclite.so.1"))))))))
+      ;; The test suite is disabled because it requires access to a card
+      ;; reader with a card inserted.
+      #:tests? #f
+      #:phases #~(modify-phases %standard-phases
+                   (add-after 'unpack 'patch-dlopen
+                     (lambda* (#:key inputs #:allow-other-keys)
+                       (substitute* "PCSCperl.h"
+                         (("libpcsclite.so.1")
+                          (search-input-file inputs
+                                             "/lib/libpcsclite.so.1"))))))))
     (native-inputs (list pkg-config))
     (inputs (list pcsc-lite))
     (synopsis "Perl library for PC/SC")
--8<---------------cut here---------------end--------------->8---

-- 
Thanks,
Maxim