unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Timothy Sample <samplet@ngyro.com>
To: "Ludovic Courtès" <ludovic.courtes@inria.fr>
Cc: 43442@debbugs.gnu.org, zimoun <zimon.toutoune@gmail.com>
Subject: [bug#43442] [PATCH] Fixes init of #42162: gforge.inria.fr down Dec. 2020
Date: Wed, 22 Mar 2023 16:42:39 -0600	[thread overview]
Message-ID: <87jzz8xva8.fsf@ngyro.com> (raw)
In-Reply-To: <87jzzbms54.fsf_-_@gnu.org> ("Ludovic Courtès"'s message of "Mon, 20 Mar 2023 15:09:11 +0100")

Hello,

Ludovic Courtès <ludovic.courtes@inria.fr> writes:

> This whole hack looks like a dead end.
>
> It would be ideal if SWH would compute nar hashes, as you proposed:
>
>   https://gitlab.softwareheritage.org/swh/meta/-/issues/4538
>
> As a stopgap, I wonder if we could use “double hashing” on our side, but
> only for svn: we’d store both the nar sha256 as we currently do, plus
> the swhid.  It still seems to me that it’d be hard to scale and to
> maintain that over time, even if it’s limited to svn.  Plus, there’d
> still be the problem of ‘svn-multi-fetch’, which is what most TeX Live
> packages use.
>
> Thoughts?

Not too many, but I do have more bad news.  Apologies if this is already
known, but I’m just getting up to speed with how SWH handles Subversion
(for coverage checking) and thought this seemed pretty significant.

I was starting with doing a simple check for the “easy” Subversion
repositories.  That is, no externals (‘recursive?’) and no
‘svn-multi-fetch’ [1].  I immediately hit a problem.  Guix hashes the
export of the repository with the keywords processed, while SWH hashes
it with unprocessed keywords.

For example, take ‘libsmpeg’.  It has a file called “mkinstalldirs”,
which has a keyword in it: “$Id$”.  The SWH loader hashes this as

    $Id$

while we hash it as

    $Id: mkinstalldirs 9 1999-10-21 15:55:01Z hercules $

This is not a big issue in terms of coverage checking, but it will be an
issue for automatic recovery.  Even if you know the exact SWH directory
ID, you won’t get a directory that satisfies the daemon’s hash check.  I
have no idea how hard it is to process the keywords with only data from
SWH.  In this case, you would have to walk revisions to find the last
time “mkinstalldirs” was modified, and then format its metadata.
However, I assume the Subversion properties are gone, so there might be
edge cases like a file with “$Id$” (or whatever) that Subversion
wouldn’t processes.

Again, apologies if this is old news.  Actually apologies either way,
’cause this is a bit of a downer!


-- Tim

[1] More precisely, I was going to process recursive ‘svn-fetch’ origins
because a lot of them are needlessly marked as recursive.  In some
(many?) cases, the repositories don’t actually have external references,
so the flag does nothing.  I was only going to skip the ones where it
makes a difference.




  reply	other threads:[~2023-03-22 23:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16  8:14 [bug#43442] [PATCH] Fixes init of #42162: gforge.inria.fr down Dec. 2020 zimoun
2020-09-16  8:16 ` [bug#43442] [PATCH 1/2] gnu: mpfi: Replace 'url-fetch' by 'svn-fetch' zimoun
2020-09-16  8:16   ` [bug#43442] [PATCH 2/2] gnu: gmp-ecm: " zimoun
2020-09-21 21:19   ` [bug#43442] [PATCH 1/2] gnu: mpfi: " Ludovic Courtès
2020-09-21 21:51     ` zimoun
2020-09-23 16:21       ` Ludovic Courtès
2020-09-23 17:07         ` zimoun
2020-09-25  8:56           ` Ludovic Courtès
2020-10-01 20:26             ` zimoun
2020-10-01 21:01               ` zimoun
2020-10-03  8:59               ` Ludovic Courtès
2023-03-20 14:09                 ` [bug#43442] [PATCH] Fixes init of #42162: gforge.inria.fr down Dec. 2020 Ludovic Courtès
2023-03-22 22:42                   ` Timothy Sample [this message]
2023-03-24 17:22                     ` [bug#43442] Subversion keyword substitution Ludovic Courtès
2023-03-24 23:31                       ` Timothy Sample
2023-03-27  9:04                         ` Ludovic Courtès
2023-04-03 12:05                           ` Simon Tournier
2023-04-04 17:16                           ` Timothy Sample
2023-04-07 16:45                         ` Ludovic Courtès
2023-04-03 13:34                   ` [bug#43442] [PATCH] Fixes init of #42162: gforge.inria.fr down Dec. 2020 Simon Tournier
2024-03-09 22:34                   ` bug#43442: Code stored with Subversion (SVN) cannot be retrieved from SWH Ludovic Courtès
2020-09-17  8:14 ` [bug#43442] [PATCH] Fixes init of #42162: gforge.inria.fr down Dec. 2020 Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzz8xva8.fsf@ngyro.com \
    --to=samplet@ngyro.com \
    --cc=43442@debbugs.gnu.org \
    --cc=ludovic.courtes@inria.fr \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).