unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: 63720@debbugs.gnu.org
Subject: [bug#63720] [PATCH] website: List languages in two columns.
Date: Mon, 05 Jun 2023 14:47:04 +0200	[thread overview]
Message-ID: <87jzwihy9j.fsf@gnu.org> (raw)
In-Reply-To: <878rdcxvt2.fsf@pelzflorian.de> (pelzflorian@pelzflorian.de's message of "Thu, 25 May 2023 17:41:45 +0200")

Hi,

"pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> skribis:

> * website/apps/base/templates/components.scm (navbar): Specify a CSS
> class for the languages dropdown list.
> * website/static/base/css/navbar.css (languages-dropdown-list): New
> rule.
> ---
>
> The translations dropdown is too long and high.  It seems to me
> adjusting the number of columns dynamically and limiting the height is
> not possible, unless we rewrite dropdowns to use CSS flexbox in <div>
> elements instead of lists.  Instead, this patch sets a fixed column
> number of two, which should be appropriate for the foreseeable future.
>
> Also, there is only one languages dropdown, so this patch could
> specify an id and not a new class for the languages dropdown.  But a
> class works too and works always, so using a class seems better (?).

No opinion on this, but two columns sounds like a good idea to me.

Thanks,
Ludo’.




  reply	other threads:[~2023-06-05 12:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25 15:41 [bug#63720] [PATCH] website: List languages in two columns pelzflorian (Florian Pelz)
2023-06-05 12:47 ` Ludovic Courtès [this message]
2023-06-06  6:29   ` bug#63720: " pelzflorian (Florian Pelz)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzwihy9j.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=63720@debbugs.gnu.org \
    --cc=pelzflorian@pelzflorian.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).