From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id mGGVLzlk3mTtLQEASxT56A (envelope-from ) for ; Thu, 17 Aug 2023 20:17:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id CPhrLzlk3mSMKAEAauVa8A (envelope-from ) for ; Thu, 17 Aug 2023 20:17:29 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5C36948862 for ; Thu, 17 Aug 2023 20:17:29 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=dEP7vS2u; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692296249; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=DDPzmLwUDa9Ccy3aJZF5PhxaOvnSC1WyfSgpi6ByVAk=; b=bPOixJWu6ruJ0DtccMHeV/rnZM6lyrsDlR0oR28kqv2LuuXas/vyRlfp5+rLfAlRVGFqfI e6alF7Mf6oRg16kLAUWOjfDpiDM+q1mqrf4m8gPrm8Xng1x+rPt04XN+JYK3Ye4EJH5bZ6 tze2zwg3x/gtyk4DHSyvW05+kflUQMd1kE3xOQjVODEc1qA0xUV/QmN1xkjr+2kSCn6r8N wwaQKU2rW+dHJQvwr4scwtMuxIHDVLB9o+d0e+3qyrkXjRFjne5tu78EJY3PBJAyiWQK0N HN/pPvaU9mUesm9m5ewTVbhYSX4wKud2nukbxlr+Ro/Cll0DLIiXR4goSyX9bA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=dEP7vS2u; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692296249; a=rsa-sha256; cv=none; b=nO02cACWdV7vsc7ENgHoXWMf0+MyOYVtULuKuKar2dWmBu4E7118jo5YheG0EKUnuFPw+U QhE3kN75h6I8bLyvBTDo3SQJIujotKK7X39FM5PRRd59E2hvFe8fVKH9MbnpPYD+FiDFGV 3bIEtEj908SOd8btC30hT1F3WJ41Y8uaX2GPopYP4j3Os5vDeiKhiBnokOTgctiR/9w+2C hzGmxf7u6z6oRxf5sdxjVNnFtYOVE+upkkW3ov9fIrNB2qV7/yEFk51sLhoMouGPILFu4J 4mV1i0PBo9Zswy2hs73oH4Vn/sbDej/JxVpFOpVymSMzSrMeNlV5R6RtVrSPlg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWhYk-0007AU-30; Thu, 17 Aug 2023 14:17:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWhYM-00079N-Mv for guix-patches@gnu.org; Thu, 17 Aug 2023 14:17:09 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qWhYM-0003eK-DZ for guix-patches@gnu.org; Thu, 17 Aug 2023 14:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qWhYM-00035O-Ab for guix-patches@gnu.org; Thu, 17 Aug 2023 14:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64746] [PATCH v2 2/3] pull: Tag commit argument with 'tag-or-commit. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 17 Aug 2023 18:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64746 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon Tournier Cc: Josselin Poiret , Mathieu Othacehe , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Ricardo Wurmus , 64746@debbugs.gnu.org, Christopher Baines Received: via spool by 64746-submit@debbugs.gnu.org id=B64746.169229618211811 (code B ref 64746); Thu, 17 Aug 2023 18:17:02 +0000 Received: (at 64746) by debbugs.gnu.org; 17 Aug 2023 18:16:22 +0000 Received: from localhost ([127.0.0.1]:45572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWhXh-00034R-Of for submit@debbugs.gnu.org; Thu, 17 Aug 2023 14:16:22 -0400 Received: from mail-oi1-x235.google.com ([2607:f8b0:4864:20::235]:57831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWhXf-00034C-9H for 64746@debbugs.gnu.org; Thu, 17 Aug 2023 14:16:20 -0400 Received: by mail-oi1-x235.google.com with SMTP id 5614622812f47-3a43cbb432aso6114404b6e.3 for <64746@debbugs.gnu.org>; Thu, 17 Aug 2023 11:16:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692296173; x=1692900973; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=DDPzmLwUDa9Ccy3aJZF5PhxaOvnSC1WyfSgpi6ByVAk=; b=dEP7vS2uc5C+jA0DpgT5EiDglyX4ZoWqS3Pb0H4hOOBBxsEFXNaQkoUQucUG63tgqT xvkuQNh2KJ5ANxEGrPoJ41BWulMrMJCJFwTLe98mBStq2RH3AlZ10DM8iEF2g+04LsR7 z5xwflFBZBnKkWrcUIPYWt8MBrMWmuS77bBiCr1UfFORWr9VdEV3WH5GTJ4zZ34SUrwL fPMlaGXO9EDXv4CLnd+rie9V+JVJT8atgGuKKMqTgb2yUdSS4eieCP4iNtRaqoXt3bnn 4QgHLeLgztVkqPf/EiVS+Z1/Z1IhsHlFOraFjUnGx3rdClAcdj0MpYEXcbudt9fTQASW 7Wbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692296173; x=1692900973; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DDPzmLwUDa9Ccy3aJZF5PhxaOvnSC1WyfSgpi6ByVAk=; b=IWxhhpC/Ks/OzQdr0w50d58/yRM3y9WcI7sXxg90XVk+ZhR/wehUXkQAg6TkI5jmHf sU3zGje6fAQTT+fPvzI7J6uEZOlm++wajv98s6CSEhaqWVAJyoDwDOwZAlKMgfTFk2vA HWffggmG5TatUEJLR+UbzRDOmQ3hdFkjeO+Rw7Ch4xTBMBAOTJTeWh7s5aoDCFftebvl wyp67CFg9qAH1CqUq4I7TzwY104HY1KQstcvH7n7QD1I/TB6xmh8HVc/Mjm/UiMcmdvF A54DdHM6rHp6JV6dCJBlzOjQ258TJLjyd7VamzR0HMbdrBdj10P27MwUCL8A4IVhbbWs U7cQ== X-Gm-Message-State: AOJu0YxQkTs1SJ1LmpvVHf5C0KrrqVSv/wN5wF2GTzk/J0TT3yNDAMK7 yD1OYVugMyzrib+WZ3I4eN4= X-Google-Smtp-Source: AGHT+IE0w8RKzi811LPMpk1fohgLl8s6OmuqNsAK53z/iBPFRAJfQC4KYdXLumuWaFwD5D6I9r5Gmg== X-Received: by 2002:a54:4397:0:b0:3a4:39e5:5c69 with SMTP id u23-20020a544397000000b003a439e55c69mr268098oiv.53.1692296173365; Thu, 17 Aug 2023 11:16:13 -0700 (PDT) Received: from hurd (dsl-152-182.b2b2c.ca. [66.158.152.182]) by smtp.gmail.com with ESMTPSA id h18-20020a0cf452000000b0063d1f967268sm47481qvm.111.2023.08.17.11.16.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Aug 2023 11:16:12 -0700 (PDT) From: Maxim Cournoyer References: <340786ccd3d40c0c8906028dc20af5ae9b0aa6b9.1692128648.git.maxim.cournoyer@gmail.com> <87o7j7f2tb.fsf@gmail.com> <87bkf6j02r.fsf@gmail.com> <87a5up4tie.fsf@gmail.com> Date: Thu, 17 Aug 2023 14:16:11 -0400 In-Reply-To: <87a5up4tie.fsf@gmail.com> (Simon Tournier's message of "Thu, 17 Aug 2023 16:45:45 +0200") Message-ID: <87jzttfsb8.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 4.31 X-Spam-Score: 4.31 X-Migadu-Queue-Id: 5C36948862 X-Migadu-Scanner: mx1.migadu.com X-TUID: QU4vqc+NxdJy Hi Simon, Simon Tournier writes: > Hi Maxim, > > On Wed, 16 Aug 2023 at 14:47, Maxim Cournoyer = wrote: > >>>> (option '("commit") #t #f >>>> (lambda (opt name arg result) >>>> - (alist-cons 'ref `(commit . ,arg) result))) >>>> + (alist-cons 'ref `(tag-or-commit . ,arg) result))) > > [...] > >> (match ref >> - (('commit . commit) >> + ((or ('commit . commit) >> + ('tag-or-commit . commit)) > >> The reason is to standardize the API of (guix pull) and (guix git), >> whose procedure had a different expectation for 'ref' objects. > > My point is that this =E2=80=99or=E2=80=99 is useless, IIUC. Well, I hav= e removed it in > the series fixing the annoyance with the network access of =E2=80=9Cguix > time-machine=E2=80=9D. It isn't, unless you meant after applying further changes :-) You should be able to see the problem by reverting that commit and running 'guix time-machine --commit=3Dv1.4.0 -- describe', for example. --=20 Thanks, Maxim