unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: John Kehayias <john.kehayias@protonmail.com>,
	Marius Bakke <marius@gnu.org>,
	zhengjunjie@iscas.ac.cn, 66424-done@debbugs.gnu.org
Subject: [bug#66424] [PATCH core-updates] gnu: libxkbcommon: Fix cross-compile.
Date: Mon, 16 Oct 2023 09:48:31 -0400	[thread overview]
Message-ID: <87jzrmznio.fsf@gmail.com> (raw)
In-Reply-To: <ZSy_NXpc42Gr51Mb@3900XT> (Efraim Flashner's message of "Mon, 16 Oct 2023 07:42:29 +0300")

Hi Efraim,

Efraim Flashner <efraim@flashner.co.il> writes:

[...]

>> looks like the same change was made on master in
>> bc1634a197dc9ab7aa0dead8c7449bb5db09cea6. Along with other commits
>> then to do the same thing to other similar packages.
>> 
>> So, I'm closing as I believe this is done but figured I'd loop in
>> Efraim in case there was anything else on this matter to discuss.
>
> Oh no! I really need to get better about checking the bug tracker to see
> if someone else has already worked through changes I'm thinking of.
>
> I tried a bit of pkg-config hackery/trickery for a bunch of the
> packages, even messing with the meson cross definitions file, but it
> turned out that pkg-config-for-build did the exact wrapping that was
> needed AND it provided a symlink from (pkg-config-for-target) to
> "pkg-config", which was what meson needed.
>
> I'll cherry-pick the commits over to core-updates and then do some of
> the fixups to make everything cleaner.

Thanks for the resolution, and sorry for the regression I had
introduced.

-- 
Thanks,
Maxim




      reply	other threads:[~2023-10-16 13:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-09 15:07 [bug#66424] [PATCH] gnu: libxkbcommon: Fix cross-compile Zheng Junjie
2023-10-12 18:07 ` [bug#66424] [PATCH core-updates] " John Kehayias via Guix-patches via
2023-10-13 14:49   ` Maxim Cournoyer
2023-10-14 17:30     ` zhengjunjie
2023-10-14 21:02       ` John Kehayias via Guix-patches via
2023-10-16  2:28       ` bug#66424: " John Kehayias via Guix-patches via
2023-10-16  4:42         ` [bug#66424] " Efraim Flashner
2023-10-16 13:48           ` Maxim Cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzrmznio.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=66424-done@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=john.kehayias@protonmail.com \
    --cc=marius@gnu.org \
    --cc=zhengjunjie@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).