From: Mathieu Othacehe <othacehe@gnu.org>
To: "Rémi Teissier" <rteissier.code@chillpc.fr>
Cc: 65662@debbugs.gnu.org
Subject: [bug#65662] [PATCH] gnu: Add antifennel.
Date: Thu, 26 Oct 2023 15:04:17 +0200 [thread overview]
Message-ID: <87jzr9k01a.fsf@gnu.org> (raw)
In-Reply-To: <e3349ef4-a55b-4318-b030-668f7ce8d44c@chillpc.fr> ("Rémi Teissier"'s message of "Thu, 31 Aug 2023 16:15:51 +0200")
Hello,
Sorry for the delay!
> From c546257438e4e824ddf54351b77a754d2f466567 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?R=C3=A9mi=20Teissier?= <rteissier.code@chillpc.fr>
> Date: Thu, 31 Aug 2023 15:17:28 +0200
> Subject: [PATCH] gnu: Add antifennel.
>
You are missing a commit message here. It should look like:
* gnu/packages/lua.scm (antifennel): New package.
> + (base32
> + "1hd9h17q31b3gg88c657zq4han4air2ag55rrakbmcpy6n8acsqc"))
The indentation seems off here.
> + (file-name (git-file-name name version))))
> + (build-system gnu-build-system)
> + (inputs (list lua luajit))
> + (arguments
> + '(#:phases (modify-phases %standard-phases
> + (delete 'configure)
> + (delete 'check)
Are tests disabled because there are no tests or because there are not
passing. If we are in the first case you can specify it with a simple
comment such as ;no tests.
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((bin (string-append (assoc-ref outputs "out")
> + "/bin")))
The preferred way now is to use gexp, meaning that you can directly
write:
(install-file "antifennel" #$output)
> + (home-page "https://git.sr.ht/~technomancy/antifennel")
> + (synopsis "Turn Lua code into Fennel code")
> + (description
> + "Turn Lua code into Fennel code. This compiler does the opposite
> + of what the Fennel compiler does.")
It would be nice to expand a bit the description and use sentences, such
as: This package provides a way to turn Lua code into Fennel code by...
> + (license (list license:expat))))
You don't need a list if there is just one license :)
Could you please send an updated patch?
Don't hesitate if you need some guidance!
Mathieu
next prev parent reply other threads:[~2023-10-26 13:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 14:15 [bug#65662] [PATCH] gnu: Add antifennel Rémi Teissier
2023-10-26 13:04 ` Mathieu Othacehe [this message]
2023-11-01 15:09 ` Rémi Teissier
2023-11-24 17:13 ` bug#65662: " Mathieu Othacehe
2023-11-01 14:54 ` [bug#65662] [PATCH v1] " Rémi Teissier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzr9k01a.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=65662@debbugs.gnu.org \
--cc=rteissier.code@chillpc.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).