From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 4Fb3MIjBzGUt5gAAqHPOHw:P1 (envelope-from ) for ; Wed, 14 Feb 2024 14:35:04 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 4Fb3MIjBzGUt5gAAqHPOHw (envelope-from ) for ; Wed, 14 Feb 2024 14:35:04 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707917704; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=Jrrpui4gRRz+95mV1AP9k/CFkj0xBYbFD2884ohX/KU=; b=lM5kRZri9Bk4AoFoL2jMgqw1wyr7HuPn+xF+DPLmCAioK2vzLyWdYKdut6M+qnbOWx7PXX h97yf8okH78Sme7TZuzYB7vF8uYQsIcgs232l0qLQ0ESoao5OH7dsDLQ8FkYdY8+vBQLiE vN7x6nLX89u6ogFMOtzG+y0/kX0PCTJ8CCydAKkzP+GPWIdqaxy7+wVhm91v3kK5AvPZBk Q4BnlRvJQhYi/TnCxv0VL4FvpslMJQ0YfEyyfdlguwTlnRZieb2yQ7F3pxHzGbgrJR49VX nsrG1P/MpaSBKYiR7m8FQZB8a7fVp19e8tGVR/j9240n3ZfgJGDg0aw3hfcIWg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707917704; a=rsa-sha256; cv=none; b=LxhZQDzh+xz38xjuoBvnuCzEttXKDSkwgThBxhquANHm+6IeYEUehRE01tNgbtpCOUjdu3 rtJSvinr7jyknBWhfVd/sbMqKDQmX6ufWz/6r/of1QKDw3bPXMorYjdzYt3Sjgg1UZQQBC 7T4cdY0rPWlTeXZ7fmild9g89W2WNPv6yYbMaXqCsIk+IGImNvmyA9DoHSa4eqzuQYAi71 KEoauuZ81bO1Erqi7j4JE8eOmnC3PLYcZUto9YrR1swOc5LZRoxhC624AOOhl3/XEw8mMN AlTY5ZiIuxyUMr4OJIkaqGksjvCAIqRo4Irm5IdgEIu5FeZWg7/+nhzhb9ySrw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B5F2911E18 for ; Wed, 14 Feb 2024 14:35:04 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1raFPS-0001kZ-6K; Wed, 14 Feb 2024 08:34:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raFPQ-0001jL-Aw for guix-patches@gnu.org; Wed, 14 Feb 2024 08:34:44 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1raFPQ-0007q1-2H for guix-patches@gnu.org; Wed, 14 Feb 2024 08:34:44 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1raFPi-0008Bu-2T for guix-patches@gnu.org; Wed, 14 Feb 2024 08:35:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68742] QA review for 68742 Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 14 Feb 2024 13:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68742 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ekaitz Zarraga , Erik Eduardo Cc: 68742-done@debbugs.gnu.org, 68742@debbugs.gnu.org X-Debbugs-Original-Cc: 68742-done@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.170791766531439 (code B ref -1); Wed, 14 Feb 2024 13:35:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Feb 2024 13:34:25 +0000 Received: from localhost ([127.0.0.1]:50816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raFP6-0008Ay-A9 for submit@debbugs.gnu.org; Wed, 14 Feb 2024 08:34:24 -0500 Received: from lists.gnu.org ([209.51.188.17]:34140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raFP1-0008Ak-L1 for submit@debbugs.gnu.org; Wed, 14 Feb 2024 08:34:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raFOi-0001Ca-DH for guix-patches@gnu.org; Wed, 14 Feb 2024 08:34:00 -0500 Received: from mira.cbaines.net ([212.71.252.8]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1raFOf-0007hw-Vt for guix-patches@gnu.org; Wed, 14 Feb 2024 08:34:00 -0500 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id 6895F27BBE2; Wed, 14 Feb 2024 13:33:55 +0000 (GMT) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 370bfceb; Wed, 14 Feb 2024 13:33:54 +0000 (UTC) References: <18af450b-4585-c935-487f-7d3c59b80822@elenq.tech> User-agent: mu4e 1.10.7; emacs 29.1 From: Christopher Baines Date: Wed, 14 Feb 2024 13:33:11 +0000 In-reply-to: <18af450b-4585-c935-487f-7d3c59b80822@elenq.tech> Message-ID: <87jzn7891c.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -8.77 X-Spam-Score: -8.77 X-Migadu-Queue-Id: B5F2911E18 X-TUID: Fok5w/vdBbXQ --=-=-= Content-Type: text/plain Ekaitz Zarraga writes: > user guix > usertag 68742 + reviewed-looks-good > thanks > > Guix QA review form submission: > It's a simple addition. I think it's ok. > I linted, and I also built, and things the author expected work. > > Items marked as checked: Lint warnings, Package builds, Commit messages Thanks both, I've tweaked the indentation a little and pushed this to master as 8d4c3032416c69f883d074f4f6d7bcc9741be75c. Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmXMwT9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcnTRAAuXFtl47iIx1mUwdiSl+pRiNWE/8uTyuf Ctj4Bg6qCFyie9TfwP5oKvNTFdIr2PenBWywFVVpptiOX0FoIBL0lTP71ReNAJ+2 aoab+opnwLNzXSY4PUhICBoVhPYiDZgIJQ2L/6goJh2ytCE/te2yrta67XvV8+Ld cJKxBC7S4dP1HcJjDtK63etu787Dhrckq4k4PiPzil61bts5ziJJRKK98MCZzY7S BCiRVGWJFZQpn5SRDXa2ga/WOIEearUmGH8aVayN1+0X210LBitUCbS3fIzGbF+3 igfSit5U9iMlLgeGKUOpSai8Pz2NvN06PfaXmfvStuRzhnrOOstBvR7IGju99/tU DYWrtipz+CxvwT0mqpqaZ637lzxnyJjP/WZFkJ6GaVZ4q8lc/u48gFpWK9+lcuGx IA2yyDMwtcJmeLumKU0RUJ68wj7XMI+Xza4blRiMtkSTr9AhVPnAX3BJgLhSL11Y Lw6tp8T/KF9EEjpDAUSb3c/Gu7OzbmxOW2rPkgADu7j6QfZ9eZlJ6nkAZT15xaer k8slrqIL9k97amUsl2EVSP2LsoMSQohzge488fywEhXBu4KjR7sQFNB58RcM44UM i4VhfH660/2osylWAevG3pqBU26IKNcDfAMaIA5PPSsjqT01V9GGgpgj4sIP468u 5cfj1gDuPFM= =50AG -----END PGP SIGNATURE----- --=-=-=--