From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id UDcuGJzL02UfoAAA62LTzQ:P1 (envelope-from ) for ; Mon, 19 Feb 2024 22:43:56 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id UDcuGJzL02UfoAAA62LTzQ (envelope-from ) for ; Mon, 19 Feb 2024 22:43:56 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="ctq+0Q3/"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708379036; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=sBXqsnkFap33LiJOAkac++uinnjbzVEkTZhN3fZjx1Q=; b=rYV+IHyyoGjMG7QoGDf9HF8GZwUe1AfkPG26LloZoCUXFtfk+8N7LHCvubfDRQGWpReyNi QI7dg7Qz6TIUPWZoLBLwlD5gH4GS6hEprGGKUWfzjhcLPb8c/TomY46hV7FwU/JOSisTJI C5LlDx4/fwBkNP6GRN/5UG7Uo3rqhxKPXpiE1pVS7avmZ2HA3vCEKsoxxrqu0XIbv4ZRp9 uWIeSKG5UwZcAQuobq/fr0xYEAka2V7ZvpL62N4m/jCpkPVnVxy61S3zsx75DVFN3f2sNY zdr75P3POvhNEvDF4q6L2l2zz0eWRJxmX35f9SXIcqL0nwmnINcBvMeNo0KZMg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="ctq+0Q3/"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708379036; a=rsa-sha256; cv=none; b=Mk2g6R8vFeUJNmA0El76nrPfP/A7/JTlMLF8OO8JeQ7vjN5eVzWBbbTyZgdkhmLXqa2wbJ ZSIZyuk2nvTWnydoBq0ndvty7ogM+5MTzik95Or0Oi2vQCE46eySeEQIQ3liXyq45l/NnU YSdbLcnEM/VoQ+yoo/FVPIhbQW1boVJj0f+YS930h2BLy08rh72X0j90wiySzUgzKW57/2 hl52LFCh++iVTHBo0hpNAmLz5DEJ18S5ChN0hPnEMMWMMezdUpqaijvleaQpL4UqTRC/84 jUnkO8XF0dS9QVGVYGlcIL8ymVUTo2moBX+OtgN9WMvTtKo1ms+9s0Mj5JDmSw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1B86C23D5A for ; Mon, 19 Feb 2024 22:43:56 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rcBQP-0002Hv-US; Mon, 19 Feb 2024 16:43:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcBQN-0002HO-Nd for guix-patches@gnu.org; Mon, 19 Feb 2024 16:43:43 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rcBQL-0007PG-P9 for guix-patches@gnu.org; Mon, 19 Feb 2024 16:43:42 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rcBQh-0005jl-1r for guix-patches@gnu.org; Mon, 19 Feb 2024 16:44:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68935] [PATCH v2 5/6] import: Insert packages into modules alphabetically. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 19 Feb 2024 21:44:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68935 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Herman Rimm Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 68935@debbugs.gnu.org, Christopher Baines Received: via spool by 68935-submit@debbugs.gnu.org id=B68935.170837902421989 (code B ref 68935); Mon, 19 Feb 2024 21:44:03 +0000 Received: (at 68935) by debbugs.gnu.org; 19 Feb 2024 21:43:44 +0000 Received: from localhost ([127.0.0.1]:43680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcBQO-0005ia-E8 for submit@debbugs.gnu.org; Mon, 19 Feb 2024 16:43:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcBQM-0005iB-9d for 68935@debbugs.gnu.org; Mon, 19 Feb 2024 16:43:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcBPv-0007K1-Gs; Mon, 19 Feb 2024 16:43:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=sBXqsnkFap33LiJOAkac++uinnjbzVEkTZhN3fZjx1Q=; b=ctq+0Q3/LlfnevtfGATd /RV1Qsir8e2ekmn/zuq6jnIo1c4tdRklKx0BLIQcHT4Z0e9CDfnSgj1GZKqmHGh6P9Vmf1tkfgKH1 ifIiiQpwjYP7PLKzHtWslXx/nW/kN6bK8ENSfG/chSuiyx3qUEvbUKHzZEaaaQjpoh/tiHLOPnwaU lPlmC27T/BylcQEBk0nMPj5pYNRchZgm2wmd0mDnNID3qdmvzdCMmfpxPvJAGz/UjNjnb6Exer7ub HmKGyCWjLlCtRXcKuAu3zBbfVAL79LA1szIA81IrcVvHxK1PZKF916WXb1zMAlf3zGvbZ/a3HAm4t ePIHt091gdGP3w==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (Herman Rimm's message of "Fri, 9 Feb 2024 20:25:17 +0100") References: <3c0da641938e96a9f0c491abb74b30c75634df9a.1707505804.git.herman@rimm.ee> Date: Mon, 19 Feb 2024 22:43:12 +0100 Message-ID: <87jzn0p1u7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -2.51 X-Spam-Score: -2.51 X-Migadu-Queue-Id: 1B86C23D5A X-TUID: S0zZIxKyGGxz Herman Rimm skribis: > * guix/scripts/import.scm (guix-import): Add 'insert' option. > (define-import): Add procedure. > * doc/guix.texi (Invoking guix import): Describe 'insert' option. > > Change-Id: Id021095355283ade79acde120890eb2ce9173cf7 [...] > +(define (define-import importer args proc) > + "Wrap package expressions from IMPORTER with 'define-public and invoke > +PROC callback." s/define-import/import-as-definitions/ for clarity? > + ((? list? expressions) Rather: (expressions ...). (It=E2=80=99s equivalent but more customary.) Otherwise LGTM, thanks! Ludo=E2=80=99.