From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id AOuCCkI+62V7GQEAe85BDQ:P1 (envelope-from ) for ; Fri, 08 Mar 2024 17:35:14 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id AOuCCkI+62V7GQEAe85BDQ (envelope-from ) for ; Fri, 08 Mar 2024 17:35:14 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lease-up.com header.s=2017 header.b=AYIEVdcg; dkim=fail ("headers rsa verify failed") header.d=lease-up.com header.s=2017 header.b=AYIEVdcg; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1709915714; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=sDEtYzjaZ5y3HS91XTVMCSn1EMeKyJq05pAgk+cHYzE=; b=mZ24t/5aGAfhXgCIQJMT4NTOJqCYJ6LRmhss7JXc6fgzm0DH7LxxRkHqdJJLdGKSwiHO2s /77q0TL+ZDNziWxGh1ORFsw9kBQX5wN0LBpdbEhIAIYpfgGagPzMTOx96S4n3x29vI9s78 ZmaviaFJq49iJxT4yYdJiaEol1Tg3pO8kx2xUXtGGxLEDYftxglpa393/mV1cUFvuS/2MU csO5l395q/kLkTGB9eodXLBPT0Y0JSOjeliUZI95zBPSyn+/ezlvEZbVnsDU6G9s7EWLIs yl70w0AUsgb9ayQNViutlX1RSba22Me3niTh59KMOHVRTiPOtfndteC1PFxGPA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1709915714; a=rsa-sha256; cv=none; b=DmAVFuTp9DBvKjIVrLzymjkGVuBp48DpfMRA1vmMz0S4wajkFarubm0q8aDo7ID3hulkR1 eQdpi7OYgcBb+XxKoSJBzxwJdE/K6n7OvvYS/UmYFW/Oz0kJW4zN1jgGLZDrqQJkZsQ/kU dNI80mVXpPnAA+2EndUt7HqWVbYvlEpisHe2dqQ618UwtgBvGh8mY77QWytKfj27I0Vedy 8T8OIrqfDspGWfzYEnU8XM+r28FsP6y5q+NfFwUAsPb6lX+CVpteWFusqQ55saYVFbBAub 6cs2P3QNbDgU1hyoPXSSfifgEdWKfBcPkwCpug37G2Y7t/ZSI14uUjOcBh3gHg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lease-up.com header.s=2017 header.b=AYIEVdcg; dkim=fail ("headers rsa verify failed") header.d=lease-up.com header.s=2017 header.b=AYIEVdcg; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 065055E7CF for ; Fri, 8 Mar 2024 17:35:14 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ridB2-0007qT-Qe; Fri, 08 Mar 2024 11:34:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ridB1-0007pv-7u for guix-patches@gnu.org; Fri, 08 Mar 2024 11:34:31 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ridB0-0003vI-Vr for guix-patches@gnu.org; Fri, 08 Mar 2024 11:34:30 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ridBX-0004zJ-2h for guix-patches@gnu.org; Fri, 08 Mar 2024 11:35:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69343] Simplify bootloader data structures and procedures Resent-From: Felix Lechner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 08 Mar 2024 16:35:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69343 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lilah Tascheter Cc: 69343@patchwise.org Received: via spool by 69343-submit@debbugs.gnu.org id=B69343.170991566819084 (code B ref 69343); Fri, 08 Mar 2024 16:35:03 +0000 Received: (at 69343) by debbugs.gnu.org; 8 Mar 2024 16:34:28 +0000 Received: from localhost ([127.0.0.1]:59397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ridAx-0004xe-KK for submit@debbugs.gnu.org; Fri, 08 Mar 2024 11:34:28 -0500 Received: from sail-ipv4.us-core.com ([208.82.101.137]:42938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ridAs-0004xQ-2K for 69343@debbugs.gnu.org; Fri, 08 Mar 2024 11:34:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=sDEtYzjaZ5y3HS9 1XTVMCSn1EMeKyJq05pAgk+cHYzE=; h=date:references:in-reply-to:subject: cc:to:from; d=lease-up.com; b=AYIEVdcgRkXPttTWjDvWC/bLyfLkIMKR60dedlkK ncv4bLp38oTpVQz6bH9gg9C/taVWD3Pn8Tp0z6D49kkdcTb9ComonCSA5xYvE3OA/PO7s1 dY8kEnboVqN2IgZxdnx9RLT7Gg9Y/AgWLmdol9ftEOhSu9NiSDHu6/dfGLhlg= Received: by localhost (OpenSMTPD) with ESMTPA id fe69d9f2 for <69343@debbugs.gnu.org>; Fri, 8 Mar 2024 16:33:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=sDEtYzjaZ5y3HS9 1XTVMCSn1EMeKyJq05pAgk+cHYzE=; h=date:references:in-reply-to:subject: cc:to:from; d=lease-up.com; b=AYIEVdcgRkXPttTWjDvWC/bLyfLkIMKR60dedlkK ncv4bLp38oTpVQz6bH9gg9C/taVWD3Pn8Tp0z6D49kkdcTb9ComonCSA5xYvE3OA/PO7s1 dY8kEnboVqN2IgZxdnx9RLT7Gg9Y/AgWLmdol9ftEOhSu9NiSDHu6/dfGLhlg= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 89270730 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Fri, 8 Mar 2024 16:33:47 +0000 (UTC) In-Reply-To: References: Date: Fri, 08 Mar 2024 08:33:44 -0800 Message-ID: <87jzmcwumv.fsf@lease-up.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Felix Lechner X-ACL-Warn: , Felix Lechner via Guix-patches From: Felix Lechner via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.78 X-Spam-Score: -6.78 X-Migadu-Queue-Id: 065055E7CF X-Migadu-Scanner: mx11.migadu.com X-TUID: tRNgxYZP/fdg Hi Lilah, On Fri, Mar 08 2024, Lilah Tascheter wrote: > this is really useful!! love having access to generation numbers > alongside boot params, and the terminology fixing's great too :) Thank you for taking a closer look! Sorry I did not get back to you on the system-path question before. Of course, you were right. If you will please accept an excuse for my tardiness: My family has a new sister. Time passes when a baby cries. > * (gnu system boot) was missing a few imports that it needs to work. I regularly notice missing imports, too, but haven't figured out when they present an obstacle to running a Guile program. > * (gnu system boot) requires the procedure > system-linux-image-file-name, which is defined in (gnu system). I > moved it over to (gnu system boot). Thanks for doing that! Now you and I are co-conspirators in re-arranging the procedures. > * generation->boot-alternative in (guix scripts system) had typos in > variables resulting in them not being used. Thank you for finding those. I have poor vision and am not good with details, including speling. > * commit messages didn't have relevant gnu changelog info. Yes, I will read the GNU ChangeLog spec one more time, but all hope may be lost. > * one of those commit messages had a wholeass log that's Way too much > extraneous information and just got in the way My commit messages are widely regarded as wordy, roundabout and overly documentative. > this v2 passes all relevant unit tests, but could still definately use some > verification that the modified paths function properly before I'd say this is > ready to be merged. I use 'guix deploy' and will test your patch series shortly. (Despite the previous shortcomings, I have been using it in production.) My branch rebase is overdue. Unfortunately, I have many custom patches, including some affecting core packages. A branch rebase locally causes a full bootstrap and takes about two days. Given your attention here, I am sure your changes are fine. Folks should feel free to merge your work before I return with confirmation. Thanks! Kind regards Felix