unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: 71640@debbugs.gnu.org
Subject: [bug#71640] yt-dlp: Update to 2024-05-27
Date: Fri, 28 Jun 2024 20:27:00 -0400	[thread overview]
Message-ID: <87jzi8a90r.fsf@gmail.com> (raw)
In-Reply-To: <Zn2b2G6UJEOloQqk@jasmine.lan> (Leo Famulari's message of "Thu, 27 Jun 2024 13:05:28 -0400")

Hi Leo,

Leo Famulari <leo@famulari.name> writes:

> On Sun, Jun 23, 2024 at 09:58:13PM -0400, Maxim Cournoyer wrote:
>> > +                  python-requests-next ; TODO Remove this special package
>> > +                  python-urllib3-next  ; TODO Remove this one too
>> 
>> That's OK only because that's an application and these inputs are not
>> propagated.  I'm a bit worried the '-next' variants may be used by
>> packagers elsewhere, but I guess this means we should give the
>> python-team branch a spin.
>
> I could make the packages hidden. Is there a better approach?

Not really, as the problem with Python is that everything gets
propagated and you can't mix incompatible libraries together. I guess
that's something to keep in mind when reviewing Python packages.  It's
OK to use any version for *applications*, but it's not OK for libraries,
as these are expected to be compatible with the larger Python package
collection of Guix.

>> Also, I see you haven't used inheritance anywhere; I guess that's to
>> make the transition to the latest package as painful as possible
>> (simply deleting the old definitions).
>
> For me, using inheritance is painful, and this is relatively painless.

I meant painless above.  I disagree that inheritance is generally
painful, although it brings some complications (such as 'guix refresh'
not taking inheritance dependencies into account).

Anyway, LGTM :-).

-- 
Thanks,
Maxim




  reply	other threads:[~2024-06-29  0:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-19  1:45 [bug#71640] yt-dlp: Update to 2024-05-27 Leo Famulari
2024-06-19  2:13 ` [bug#71640] [PATCH 1/6] gnu: yt-dlp: Don't inherit from youtube-dl Leo Famulari
2024-06-19  2:13   ` [bug#71640] [PATCH 2/6] gnu: Add python-requests 2.31.0 Leo Famulari
2024-06-19  2:13   ` [bug#71640] [PATCH 3/6] gnu: Add python-urllib3 1.26.17 Leo Famulari
2024-06-19  2:13   ` [bug#71640] [PATCH 4/6] gnu: python-pytest-sanic: Further relax the websockets version requirements Leo Famulari
2024-06-19  2:13   ` [bug#71640] [PATCH 5/6] gnu: python-websockets: Update to 12.0 Leo Famulari
2024-06-24  2:00     ` [bug#71640] yt-dlp: Update to 2024-05-27 Maxim Cournoyer
2024-06-27 17:07       ` Leo Famulari
2024-06-19  2:13   ` [bug#71640] [PATCH 6/6] gnu: yt-dlp: Update to 2024.05.27 Leo Famulari
2024-06-24  1:58     ` [bug#71640] yt-dlp: Update to 2024-05-27 Maxim Cournoyer
2024-06-27 17:05       ` Leo Famulari
2024-06-29  0:27         ` Maxim Cournoyer [this message]
2024-06-24  2:03   ` Maxim Cournoyer
2024-07-01 12:19 ` [bug#71640] Deprecation Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzi8a90r.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=71640@debbugs.gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).