[bug#73058] [PATCH] gnu: gsl: Add debug output.

[bug#73058] [PATCH] gnu: gsl: Add debug output.

[Artyom Bologov]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

Hello Guix,

This patch adds a debug output for GSL. Encountered the absence of debug
output while debugging a GSL-reliant program. Tested, produces the
proper debugging file with the right symbols.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Add debug output to GSL --]
[-- Type: text/x-patch, Size: 864 bytes --]

From c8e5967de674c5eec61f9686902ea6fe568531bf Mon Sep 17 00:00:00 2001
From: Artyom Bologov <mail@aartaka.me>
Date: Thu, 5 Sep 2024 23:24:28 +0400
Subject: [PATCH] gnu: gsl: Add debug output.

* gnu/packages/maths.scm (gsl)[outputs]: Add "debug".
---
 gnu/packages/maths.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 2fe64d4aee..92244ed5f8 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -725,7 +725,7 @@ (define-public gsl
               (sha256
                (base32
                 "0jxkxrnpys2j3rh8bzx0bmnh4w6xm28jd57rgxsjp0s863agpc6w"))))
-    (outputs '("out" "static"))
+    (outputs '("out" "static" "debug"))
     (build-system gnu-build-system)
     (arguments
      (list ;; FIXME: Setting CFLAGS=-fPIC is not only unnecessary, it's also
-- 
2.41.0


[-- Attachment #3: Type: text/plain, Size: 47 bytes --]


Thanks,
-- 
Artyom Bologov
https://aartaka.me

bug#73058: [PATCH] gnu: gsl: Add debug output.

[jgart via Guix-patches via]

LGTM!

all the best,

jgart

https://whereis.xn--q9jyb4c/

[bug#73058] closed (Re: [PATCH] gnu: gsl: Add debug output.)

[John Kehayias via Guix-patches via]

Hello,

On Fri, Sep 06, 2024 at 12:15 AM, GNU bug Tracking System wrote:

> Your bug report
>
> #73058: [PATCH] gnu: gsl: Add debug output.
>
> which was filed against the guix-patches package, has been closed.
>
> The explanation is attached below, along with your original report.
> If you require more details, please reply to 73058@debbugs.gnu.org.
>
> --
> 73058: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73058
> GNU Bug Tracking System
> Contact help-debbugs@gnu.org with problems
>
> From: "jgart" <jgart@dismail.de>
> Subject: Re: [PATCH] gnu: gsl: Add debug output.
> To: 73058-done@debbugs.gnu.org
> Cc: Artyom Bologov <mail@aartaka.me>
> Date: Fri, 06 Sep 2024 00:13:28 +0000 (2 hours, 12 minutes, 9 seconds ago)
>
> LGTM!
>
> all the best,
>
> jgart
>
> https://whereis.xn--q9jyb4c/
>

Did you mean to push this to master? I see a lot of rebuilds on Cuirass.
Though perhaps a good chunk done by now.

If it needs to be reverted (I wasn't sure), we could take it (and an
update?) on mesa-updates or maybe gnome-team if they are quicker?

John

> ----------
>
> From: Artyom Bologov <mail@aartaka.me>
> Subject: [PATCH] gnu: gsl: Add debug output.
> To: Guix Patches <guix-patches@gnu.org>
> Date: Thu, 05 Sep 2024 23:28:17 +0400
> Date: Thu, 05 Sep 2024 23:28:17 +0400 (6 hours, 57 minutes, 20 seconds ago)
>
> Hello Guix,
>
> This patch adds a debug output for GSL. Encountered the absence of debug
> output while debugging a GSL-reliant program. Tested, produces the
> proper debugging file with the right symbols.
>
>
>
> Thanks,

[bug#73058] closed (Re: [PATCH] gnu: gsl: Add debug output.)

[Ludovic Courtès]

Hi John and jgart,

John Kehayias <john.kehayias@protonmail.com> skribis:

> On Fri, Sep 06, 2024 at 12:15 AM, GNU bug Tracking System wrote:

[...]

>> From: "jgart" <jgart@dismail.de>
>> Subject: Re: [PATCH] gnu: gsl: Add debug output.
>> To: 73058-done@debbugs.gnu.org
>> Cc: Artyom Bologov <mail@aartaka.me>
>> Date: Fri, 06 Sep 2024 00:13:28 +0000 (2 hours, 12 minutes, 9 seconds ago)
>>
>> LGTM!
>>
>> all the best,
>>
>> jgart
>>
>> https://whereis.xn--q9jyb4c/
>>
>
> Did you mean to push this to master? I see a lot of rebuilds on Cuirass.
> Though perhaps a good chunk done by now.

It’s a serious issue indeed: builders, in particular for Arm/RISC-V/PPC,
cannot be expected to catch up with such a change on ‘master’.  Please
check out the rebuild scheduling policy, in this case for changes
impacting 300+ packages:

  https://guix.gnu.org/manual/devel/en/html_node/Managing-Patches-and-Branches.html

In fact, we have more important changes to ‘gsl’ that were noticed
during ‘core-updates’ but delayed due to the important cost of a
rebuild; see 4d8382ab840300ffe2a364d0e2a27b8db3d04fab and the discussion
at <https://issues.guix.gnu.org/72451>.

> If it needs to be reverted (I wasn't sure), we could take it (and an
> update?) on mesa-updates or maybe gnome-team if they are quicker?

I was planning to have a gsl-specific branch, where we could have this
patch too, and which could join a “merge train” with ‘mesa-updates’ or
similar.  WDYT?

So I reverted this commit in c4a2b99f7d06ef5676d4148410a3b734c286f7cb
and canceled pending builds on ci.guix.

Thanks,
Ludo’.

[bug#73058] closed (Re: [PATCH] gnu: gsl: Add debug output.)

[jgart via Guix-patches via]

hi ludo,

sorry for the disruption and thanks for reverting the commit. i didn't realize the amount of rebuilds that this would cause when i pushed it and i forgot to run `guix refresh -l gsl` before pushing 🦆

all the best,

jgart

https://whereis.みんな/