unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Graves via Guix-patches via <guix-patches@gnu.org>
To: 72452@debbugs.gnu.org, mrh <mrh57@posteo.net>
Subject: [bug#72452] [PATCH] add guile-swayer package
Date: Mon, 09 Sep 2024 06:46:40 +0200	[thread overview]
Message-ID: <87jzfl5t8v.fsf@ngraves.fr> (raw)
In-Reply-To: <2c614792845a675a1296bcbeb6ef8d8502d51aba.1722717063.git.mrh57@posteo.net>


Some other nitpicks:

1) (commit field should rather refer to version such as
 (commit (string-append "v" version))

This makes it easier to update.

2) guix lint complains about
guile-swayer@0.2.0: the source file name should contain the package name

You're missing
       (file-name (git-file-name name version))
in the origin. This makes it easier to find things in the store.

-- 
Best regards,
Nicolas Graves




  parent reply	other threads:[~2024-09-09  4:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-03 20:31 [bug#72452] [PATCH] add guile-swayer package mrh
2024-09-07 16:15 ` Nicolas Graves via Guix-patches via
2024-09-07 18:17   ` mrh57
2024-09-07 18:28 ` [bug#72452] [PATCH v2] gnu: add guile-swayer mrh
2024-09-09  4:46 ` Nicolas Graves via Guix-patches via [this message]
2024-09-09 16:21   ` [bug#72452] [PATCH] add guile-swayer package mrh57
2024-09-10  8:14     ` Nicolas Graves via Guix-patches via
2024-09-09 16:24 ` [bug#72452] [PATCH v3] gnu: add guile-swayer Alec Barreto
2024-09-10 12:08 ` [bug#72452] [PATCH v4] " Alec Barreto
2024-09-10 12:13 ` [bug#72452] Fwd: Re: [bug#72452] [PATCH] add guile-swayer package mrh57
2024-09-11 15:10   ` Nicolas Graves via Guix-patches via
2024-09-11 22:25     ` Alec Barreto
2024-09-10 17:23 ` [bug#72452] QA review for 72452 Nicolas Graves via Guix-patches via
2024-09-11 22:27 ` [bug#72452] [PATCH v5] gnu: Add guile-swayer Alec Barreto
2024-09-12 17:12   ` Ludovic Courtès
2024-09-13 12:03     ` Alec Barreto
2024-09-14 14:18       ` Alec Barreto
2024-09-14 15:52         ` Nicolas Graves via Guix-patches via
2024-09-14 18:23           ` Alec Barreto
2024-09-16 19:49             ` Nicolas Graves via Guix-patches via
2024-09-17  0:51               ` Alec Barreto
2024-09-17  0:54 ` [bug#72452] [PATCH v6] " Alec Barreto
2024-09-19 10:47   ` bug#72452: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzfl5t8v.fsf@ngraves.fr \
    --to=guix-patches@gnu.org \
    --cc=72452@debbugs.gnu.org \
    --cc=mrh57@posteo.net \
    --cc=ngraves@ngraves.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).