From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id IN6IDzqf/mbj8AAA62LTzQ:P1 (envelope-from ) for ; Thu, 03 Oct 2024 13:42:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id IN6IDzqf/mbj8AAA62LTzQ (envelope-from ) for ; Thu, 03 Oct 2024 15:42:18 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=g9yb8KP7; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=gvwWlP8n; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1727962938; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=hxcJaGEi7Tuny8VvSbKnxUwKTzOm1yxwm5BwC1vPymU=; b=Hk6asA5YnGX0c3cH+vv0eBuhL20QX32jR/iRLny63YyuIzEEy9qnUnrvfhxJk5Xi4uuSu9 gRil5mSiDnUCBGjnzNZcy8XYYhzaa8LcdEfjNN/NaGB8anwbPSuOBSnWqWpUFaCvtWK35o XqdE9kiG5n+mVujwZMgbV1mGO1/EduB2EqVT9TMYDCTJ9eiycm4VuMhUpCzXBcEGbPLzTH o12b0yJcXZur2TqG7b6kXKAHAT5HnsLsgNOIcKD3NkVgdVXiV1M4LnxWExot+Gn8BPfIc/ UX+9TJ7F9K3brvFGpIWK73eGiPfyWavYUtWIyOjB495BxY4gVsuIYHLRDAZ/nw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=g9yb8KP7; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=gvwWlP8n; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1727962938; a=rsa-sha256; cv=none; b=YYGpMv4RowaNJOwKl40sznBlZWspbE+xjLT1n0CnRH7hFPsuEWkL1rMoF5ezagpGQpDDDi cylL9p7H1vvwEtICszunCeBw5clOtfiACbnyQBN/7HJuV6+eeDrAK+AI89wiTSjw/KDrcR 2aVIGHUhZXhwKgIJxFokZWTP5WH8m1c2PsmTxgaoYKEDbnZMWTcoBtCeb+uwySuoOtVMsG OLkAxkeWTTKKUsysKQf807Rm64Jo2tK+7VqRswVfeEItS1SS5dL4gXabgCvlevRPvhvr02 cy6luZXSbhHtutf1Lp3e1Jow86EQFU7yulW3l0cyEc8tc/cIAteoj713B2EylQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0771486B7F for ; Thu, 03 Oct 2024 15:42:17 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1swM5i-00013n-CN; Thu, 03 Oct 2024 09:42:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swM5g-00013W-Sn for guix-patches@gnu.org; Thu, 03 Oct 2024 09:42:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1swM5g-00086w-Jw for guix-patches@gnu.org; Thu, 03 Oct 2024 09:42:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=hxcJaGEi7Tuny8VvSbKnxUwKTzOm1yxwm5BwC1vPymU=; b=g9yb8KP7ZOYobeZr2QnOfHCmnrrlzDKGSk7t3uLWmEEgVrMytAEUQJQTlkhmtLkXSWJLZ4Beq6SlIGAtd/TqiYYtKbUg7d6H0J8qM9U4vmpS03moz7k2Waplr9N70qmGnmFAKa6pyBY+TiZU0/j6AENkWnjIAJrGBUivRCD69UQs4k2YNH4itcUlmXsFNRxWDAmGAJd4GglfelcSXAtl9mZGU1QUVK/g1NFO8R+10VR9H9R5m9cpbH8C43nC0BDxe89mu2J4Tuukdyo+vwby6xZ7QXIDC2lZ5kopcVcbVwMbh5BP55cny+6ffyi4j4NDsldDaW+wuN40/LyfrXNuYg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1swM5i-0004aD-DF for guix-patches@gnu.org; Thu, 03 Oct 2024 09:42:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72925] Adding JPM package for Janet Resent-From: "Suhail Singh" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 03 Oct 2024 13:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72925 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Omar Bassam Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Guillaume Le Vaillant , Katherine Cox-Buday , Munyoki Kilyungi , jgart , Suhail Singh Received: via spool by 72925-submit@debbugs.gnu.org id=B72925.172796288217566 (code B ref 72925); Thu, 03 Oct 2024 13:42:02 +0000 Received: (at 72925) by debbugs.gnu.org; 3 Oct 2024 13:41:22 +0000 Received: from localhost ([127.0.0.1]:60318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swM54-0004ZG-60 for submit@debbugs.gnu.org; Thu, 03 Oct 2024 09:41:22 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:60566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swM52-0004Z2-81 for 72925@debbugs.gnu.org; Thu, 03 Oct 2024 09:41:20 -0400 Received: by mail-qt1-f193.google.com with SMTP id d75a77b69052e-4582a0b438aso7567291cf.0 for <72925@debbugs.gnu.org>; Thu, 03 Oct 2024 06:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727962813; x=1728567613; darn=debbugs.gnu.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=hxcJaGEi7Tuny8VvSbKnxUwKTzOm1yxwm5BwC1vPymU=; b=gvwWlP8nNUytJ9cz1fr9XUGOHifQ52Bum9lpTIJVysWHVIYck1wVhDkafQ8Yhdva8Z 0xhexvHL0HwIIP54NJ5YW8SdIC5EAt9l8meAYoctOvBeu0oWcNkeCKEKBzD0WgEik97s LxZDQDUmCTp/hvxIcjEOMGoRBgrCbRRxO4wygxBdrOr68jF+AYXzu/HjwgtKqqr+OzkR P5y9FTDb5khi6lWNhCl9mEzezcolWp5UDusZZkmJiHdIkyi5m01nPCdLv1hbRHqpzVXR JFRdcQc/LijURmqfEBbi0odi3IwMOQKwd9Uu8kjJv2VfSHLyHbpF+e+K+qTsjcWQ6Swp 2o9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727962813; x=1728567613; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hxcJaGEi7Tuny8VvSbKnxUwKTzOm1yxwm5BwC1vPymU=; b=Tj1fGXZ6c/gN7hii5/ge7dk+WTlPBPp1R6nQ+nxW+0susFH+D27IO/qLFDunOYMF9o 9VUZf74bK7/LRGh/HIIGM9In47eRVl4ELgsjeg02KdrT8fsYdHSZDLA4w3nRTH1T5gfW kGAMzMZ1sE/OmK1OxWSpOVjDI2xwlDguUrqRFqfUiZcxXKEvpM21qAmkFXuGDDdWrpis bpc+1j2Lj9DbAUKMFLt7s8MOgFuy5dvXedz/yisH2bscYy8iSw6oJsu7ZPoZkm99kbcT wZDY4Zg4EN+kNCZA04h+/fN/QPW3pRmxOdWTO1Qlr4zGPPoscU5Ndo5kSd3u37BfQGH9 iEMQ== X-Forwarded-Encrypted: i=1; AJvYcCUufuH28JESNs9IPaw4VZQa+D4HkkgWuKw9bkB25dBElW2hgWwzWKNufWCFTRrluh+hEGoRNw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwoD080zDHm8pjUxyXhOcllpCkY4lY8PB9lBBtDj+AByv3fQH9h JAxGRlRrNcOFUnzqm0R4w/al8kEYmFIlCIKJMiuFctd/LkcLFGqz X-Google-Smtp-Source: AGHT+IEprmyH+AOrfly3UwyOpjOknoDYGAreYp0cR8Kcqdq2/zxAr3KJLvqYroVxiKAZR7p56SmeGw== X-Received: by 2002:a05:622a:120e:b0:458:294c:39e7 with SMTP id d75a77b69052e-45d8053d99bmr100755531cf.38.1727962812616; Thu, 03 Oct 2024 06:40:12 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45d92e0fd0fsm5600821cf.24.2024.10.03.06.40.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2024 06:40:12 -0700 (PDT) From: "Suhail Singh" In-Reply-To: (Omar Bassam's message of "Thu, 3 Oct 2024 10:14:20 +0300") References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> <87plok7kkn.fsf@gmail.com> <8734lev012.fsf@gmail.com> <875xqanty2.fsf@gmail.com> <87cyki9obi.fsf@gmail.com> <878qv69n0o.fsf@gmail.com> <874j5u7yme.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Thu, 03 Oct 2024 09:40:00 -0400 Message-ID: <87jzep2tlb.fsf_-_@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: 4.44 X-Spam-Score: 4.44 X-Migadu-Queue-Id: 0771486B7F X-TUID: kRrHNz4c8oIp Omar Bassam writes: > I just have some questions before submitting v8 if you don't mind. just to > make sure I understand correctly. Questions are always welcome :) >> Specifically, in the file "configs/linux_config.janet", among other >> things, the below are set >> >> #+begin_src janet >> :c++ "c++" >> :c++-link "c++" >> :cc "cc" >> :cc-link "cc" >> #+end_src >> >> Since Guix, as far as I know, doesn't have packages that provide c++ nor >> cc, I believe the above need to be patched to refer to gcc and g++ >> respectively. >> >> So we need to substitute the above "c++" and "cc" in the > "configs/linux_config.janet" to point to the absolute path for the gcc and > g++ packages? I believe there are multiple ways to make this work. I haven't tested this, so take my opinions as speculative. If we replace "cc" and "c++" with the _absolute path_ for "gcc" and "g++" respectively from the Guix store, then I don't think we need to specify gcc-toolchain as a propagated input. Upon reflecting on this, this is probably the better approach. If, however, we replace "cc" and "c++" with the _strings_ "gcc" and "g++", then I believe we may need to specify gcc-toolchain in the propagated inputs. IIUC, in this case we would replace the command that JPM invokes when building. By additionally having gcc-toolchain in the propagated inputs we'll ensure that they're available in the PATH. > Should we also replace other commands that are hard-coded like "cp" and > "chown" from coreutils the same way I did in my first initial patch? I don't believe this is necessary. There's a question regd. whether or not coreutils needs to be added to the propagated inputs, however. I don't have a definitive answer, but the way to test it would be to run it in a pure container and see if things work without having to explicitly specify coreutils. If you're unable to test it, let me know when you send v8 and I can test it on your behalf. For reference, I use something like the below: #+begin_src sh guix shell --pure -CPWN \ -E '.*GTK.*|.*XDG.*|.*DISPLAY.*|TERM|INSIDE_EMACS' \ -p /path/to/profile #+end_src > Further, I believe JPM should have a few propagated inputs: >> - gcc-toolchain >> - curl >> - git >> - nss-certs. >> >> I understand why we need gcc-toolchain. But why do we need curl, git and > nss-certs? linux_config.janet also specifies: #+begin_src janet ... :curlpath "curl" ... :gitpath "git" ... #+end_src Whether Guix packaging picks these up automatically or not, I haven't tested, but it seems for common usage of JPM these dependencies ought to be available. Similar to the case of "gcc" and "g++", it might be better to replace these with references to the respective binaries in the Guix store instead (as opposed to propagating them as I had previously suggested). Regarding nss-certs, it provides certificates for Certification Authorities which, IIUC, would be relevant for HTTPS URLs (e.g. fetching dependencies over git+https). To summarize, here's what I believe is needed. Add nss-certs to the propagated inputs, and for the below replace their occurrence in linux_config.janet with references to binaries in the store: - cc -> absolute path of gcc - c++ -> absolute path of g++ - curl -> absolute path of curl - git -> absolute path of git -- Suhail