unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org>
To: Rostislav Svoboda <rostislav.svoboda@gmail.com>
Cc: Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
	Andrew Tropin <andrew@trop.in>,
	Liliana Marie Prikler <liliana.prikler@gmail.com>,
	74137@debbugs.gnu.org
Subject: [bug#74137] [PATCH] gnu: Add emacs-vi-tilde-fringe.
Date: Fri, 01 Nov 2024 15:31:29 +0100	[thread overview]
Message-ID: <87jzdnkou6.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <23748ec5d9ce9396cfab96cadc3f33134c9eb470.1730383172.git.Rostislav.Svoboda@gmail.com> (Rostislav Svoboda's message of "Thu, 31 Oct 2024 14:59:36 +0100")

Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-vi-tilde-fringe): New variable.

Thank you.

> +(define-public emacs-vi-tilde-fringe
> +  (let ((commit "f1597a8d54535bb1d84b442577b2024e6f910308")
> +        (revision "0"))
> +    (package
> +      (name "emacs-vi-tilde-fringe")
> +      (version (git-version "1.0" revision commit))

I think you can use (version "1.0") and ignore revision. There are no
functionnal differences between the initial 1.0 release and the commit
you point to.

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/syl20bnr/vi-tilde-fringe")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "0wdm8k49zl6i6wnh7vjkswdh5m9lix56jv37xvc90inipwgs402z"))))
> +      (build-system emacs-build-system)
> +      (home-page "https://github.com/syl20bnr/vi-tilde-fringe")
> +      (synopsis "Display tildes on empty lines in the Emacs fringe a la Vi")
> +      (description
> +       "Display tildes on empty lines in the Emacs fringe a la Vi.")

The description should consist of complete sentences only.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou






  reply	other threads:[~2024-11-01 14:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31 13:59 [bug#74137] [PATCH] gnu: Add emacs-vi-tilde-fringe Rostislav Svoboda
2024-11-01 14:31 ` Nicolas Goaziou via Guix-patches via [this message]
2024-11-01 14:41   ` Rostislav Svoboda
2024-11-01 15:02     ` Nicolas Goaziou via Guix-patches via
2024-11-01 15:51       ` Rostislav Svoboda
2024-11-01 16:05         ` Nicolas Goaziou via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzdnkou6.fsf@nicolasgoaziou.fr \
    --to=guix-patches@gnu.org \
    --cc=74137@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=cox.katherine.e+guix@gmail.com \
    --cc=liliana.prikler@gmail.com \
    --cc=mail@nicolasgoaziou.fr \
    --cc=rostislav.svoboda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).