unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Runciter <runciter@whispers-vpn.org>
Cc: 74411@debbugs.gnu.org
Subject: [bug#74411] [PATCH v2 4/5] gnu: Add freedict-dictionaries.
Date: Fri, 29 Nov 2024 14:28:08 +0100	[thread overview]
Message-ID: <87jzcm185z.fsf@gnu.org> (raw)
In-Reply-To: <1dcd87131c679a4d7e80d9d4c9c44807fb00cf0a.1732150157.git.runciter@whispers-vpn.org> (runciter@whispers-vpn.org's message of "Thu, 21 Nov 2024 00:50:10 +0000")

Runciter <runciter@whispers-vpn.org> skribis:

> * gnu/packages/dictionaries (freedict-dictionaries): New variable.
>
> Signed-off-by: Runciter <runciter@whispers-vpn.org>

[...]

> +(define-public freedict-dictionaries
> +  (package
> +    (name "freedict-dictionaries")
> +    (version "914b5f7")

Regarding the version number of Git snapshots, see
<https://guix.gnu.org/manual/devel/en/html_node/Version-Numbers.html>.

> +    (inputs (list espeak-ng
> +                  python
> +                  perl
> +                  gzip
> +                  tar
> +                  libxslt
> +                  dictd-1.13.1
> +                  perl-libxml
> +                  freedict-tools-0.6.0))

You can remove ‘tar’ and ‘gzip’, they’re provided by ‘gnu-build-system’.

‘python’ and ‘perl’ should probably be in ‘native-inputs’, assuming
they’re used at build-time.

> +    (arguments
> +     (list
> +      #:tests? #f

Please add a short comment explaining why the test suite is skipped
(such as “no tests”).

> +    (synopsis "Freedict multilingual dictionaries compiled to the dictd
> +format")

Maybe: “Multilingual dictionaries compiled to the DICT format” (the
format is “DICT”, right?).




  reply	other threads:[~2024-11-29 13:29 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-17 18:06 [bug#74411] [PATCH 0/4] Add DICT and FreeDict projects packages Runciter via Guix-patches via
2024-11-18  5:55 ` [bug#74411] [PATCH 1/4] gnu: Add (gnu packages dictd) Runciter via Guix-patches via
2024-11-18  5:56 ` [bug#74411] [PATCH 2/4] gnu: Add dictd-1.13.1 Runciter via Guix-patches via
2024-11-18  5:56 ` [bug#74411] [PATCH 3/4] gnu: Add freedict-tools-0.6.0 Runciter via Guix-patches via
2024-11-18  5:56 ` [bug#74411] [PATCH 4/4] gnu: Add freedict-dictionaries Runciter via Guix-patches via
2024-11-18  6:37 ` [bug#74411] freedict-dictionaries build non-deterministic Runciter via Guix-patches via
2024-11-19  8:43   ` Nicolas Graves via Guix-patches via
2024-11-19 15:13 ` Runciter via Guix-patches via
2024-11-21  0:49 ` [bug#74411] [PATCH v2 1/5] gnu: Add (gnu packages dictd) Runciter via Guix-patches via
2024-11-21  0:49   ` [bug#74411] [PATCH v2 2/5] gnu: Add dictd-1.13.1 Runciter via Guix-patches via
2024-11-29 13:11     ` Ludovic Courtès
2024-11-21  0:50   ` [bug#74411] [PATCH v2 3/5] gnu: Add freedict-tools-0.6.0 Runciter via Guix-patches via
2024-11-29 13:14     ` Ludovic Courtès
2024-11-21  0:50   ` [bug#74411] [PATCH v2 4/5] gnu: Add freedict-dictionaries Runciter via Guix-patches via
2024-11-29 13:28     ` Ludovic Courtès [this message]
2024-11-21  0:50   ` [bug#74411] [PATCH v2 5/5] gnu: freedict-tools: Fix non-determinism of dictzip compressed file headers Runciter via Guix-patches via
2024-11-29 13:34     ` Ludovic Courtès
2024-11-29 13:10   ` [bug#74411] [PATCH v2 1/5] gnu: Add (gnu packages dictd) Ludovic Courtès
2024-11-21  1:15 ` [bug#74411] patch v2 non-determinism fix Runciter via Guix-patches via
2024-12-01 20:41 ` [bug#74411] [PATCH v2 1/5] gnu: Add (gnu packages dictd) Runciter via Guix-patches via
2024-12-01 20:53 ` [bug#74411] [PATCH v2 4/5] gnu: Add freedict-dictionaries Runciter via Guix-patches via
2024-12-01 20:59 ` [bug#74411] [PATCH v3 1/5] gnu: Add (gnu packages dictd) Runciter via Guix-patches via
2024-12-01 20:59   ` [bug#74411] [PATCH v3 2/5] gnu: Add dictd Runciter via Guix-patches via
2024-12-01 21:00   ` [bug#74411] [PATCH v3 3/5] gnu: Add freedict-tools Runciter via Guix-patches via
2024-12-01 21:00   ` [bug#74411] [PATCH v3 4/5] gnu: Add freedict-dictionaries Runciter via Guix-patches via
2024-12-01 21:00   ` [bug#74411] [PATCH v3 5/5] gnu: freedict-tools: Fix non-determinism of dictzip compressed file headers Runciter via Guix-patches via
2024-12-02 21:04   ` bug#74411: [PATCH v3 1/5] gnu: Add (gnu packages dictd) Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzcm185z.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=74411@debbugs.gnu.org \
    --cc=runciter@whispers-vpn.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).