unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: Simon Tournier <zimon.toutoune@gmail.com>,
	Vivien Kraus <vivien@planete-kraus.eu>,
	Maxim Cournoyer <maxim.cournoyer@gmail.com>,
	73073@debbugs.gnu.org
Subject: [bug#73073] [PATCH v3 2/8] gnu: gnome-recipes: Move libgd origin from phases to native-inputs.
Date: Thu, 12 Dec 2024 12:27:37 +0100	[thread overview]
Message-ID: <87jzc5b0pi.fsf@gnu.org> (raw)
In-Reply-To: <9a979351131943abba4d767be6bca4e159eff5e1.camel@gmail.com> (Liliana Marie Prikler's message of "Wed, 04 Dec 2024 19:29:34 +0100")

Hi Liliana,

Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:

> Am Mittwoch, dem 04.12.2024 um 18:54 +0100 schrieb Ludovic Courtès:
>> From: Simon Tournier <zimon.toutoune@gmail.com>
>> 
>> * gnu/packages/dlang.scm (gnome-recipes)[arguments]<phases>: Move
>> libgd
>> origin from here...
>> [native-inputs]: ...to here.

[...]

>> +               #$(this-package-native-input (git-file-name "libgd"
>> version))
>>                 "subprojects/libgd"))))))
>>      (inputs (list glib
>>                    gnome-autoar
>> @@ -821,6 +813,15 @@ (define-public gnome-recipes
>>      (native-inputs (list desktop-file-utils ;for update-desktop-
>> database
>>                           gettext-minimal
>>                           `(,glib "bin")
>> +                         (origin
>> +                           (method git-fetch)
>> +                           (uri (git-reference
>> +                                 (url
>> "https://gitlab.gnome.org/GNOME/libgd")
>> +                                 (commit
>> "c7c7ff4e05d3fe82854219091cf116cce6b19de0")))
>> +                           (file-name (git-file-name "libgd"
>> version))
>> +                           (sha256
>> +                            (base32
>> +                            
> Not sure what the state of this is here, but again noting that
> "version" has no meaning in the libgd input and "checkout" would be
> more honest.

You’re right, though packages do have a ‘version’ field; use of
‘git-file-name’ here follows established convention in Guix.

Thanks,
Ludo’.

  reply	other threads:[~2024-12-12 11:28 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-06 15:51 [bug#73073] [PATCH 0/6] Allow origin with label as inputs Simon Tournier
2024-09-06 15:54 ` [bug#73073] [PATCH 1/6] guix: packages: " Simon Tournier
2024-09-06 15:54 ` [bug#73073] [PATCH 2/6] gnu: dmd-bootstrap: Move phobos origin from phases to native-inputs Simon Tournier
2024-09-06 15:54 ` [bug#73073] [PATCH 3/6] gnu: smithforth: Move system.fs " Simon Tournier
2024-09-06 15:54 ` [bug#73073] [PATCH 4/6] gnu: gnome-recipes: Move libgd " Simon Tournier
2024-09-06 17:33   ` Liliana Marie Prikler
2024-09-06 18:11     ` Simon Tournier
2024-09-06 20:14       ` Liliana Marie Prikler
2024-09-07 11:37         ` Simon Tournier
2024-09-06 15:54 ` [bug#73073] [PATCH 5/6] gnu: farstream: Move common " Simon Tournier
2024-09-06 15:54 ` [bug#73073] [PATCH 6/6] gnu: gnulib: Move phobos " Simon Tournier
2024-09-06 21:45 ` [bug#73073] [PATCH 0/6] Allow origin with label as inputs Ludovic Courtès
2024-09-07 13:40   ` Simon Tournier
2024-09-07 14:49     ` Liliana Marie Prikler
2024-09-16 20:13     ` Ludovic Courtès
2024-09-10  1:27 ` [bug#73073] [PATCH v2 0/8] Allow origin inside inputs with "new style" Simon Tournier
2024-09-10  1:27   ` [bug#73073] [PATCH v2 1/8] guix: packages: " Simon Tournier
2024-09-16 20:19     ` Ludovic Courtès
2024-09-16 20:42       ` Simon Tournier
2024-09-26 13:30         ` Maxim Cournoyer
2024-09-10  1:27   ` [bug#73073] [PATCH v2 2/8] gnu: gnome-recipes: Move libgd origin from phases to native-inputs Simon Tournier
2024-09-10  4:30     ` Liliana Marie Prikler
2024-09-10  7:58       ` Simon Tournier
2024-09-10  1:27   ` [bug#73073] [PATCH v2 3/8] gnu: dmd-bootstrap: Move phobos " Simon Tournier
2024-09-10  1:27   ` [bug#73073] [PATCH v2 4/8] gnu: smithforth: Move system.fs " Simon Tournier
2024-09-10  1:27   ` [bug#73073] [PATCH v2 5/8] gnu: farstream: Move common " Simon Tournier
2024-09-10  1:27   ` [bug#73073] [PATCH v2 6/8] gnu: gnulib: Move phobos " Simon Tournier
2024-09-10  1:27   ` [bug#73073] [PATCH v2 7/8] gnu: git: Move git-manpages " Simon Tournier
2024-09-10  1:27   ` [bug#73073] [PATCH v2 8/8] gnu: cgit: Remove input labels Simon Tournier
2024-12-04 17:54 ` [bug#73073] [PATCH v3 0/8] Support lookups of origins used as package inputs Ludovic Courtès
2024-12-04 17:54   ` [bug#73073] [PATCH v3 1/8] packages: Use origin file names as their input labels Ludovic Courtès
2024-12-10 13:55     ` Simon Tournier
2024-12-12 11:19       ` Ludovic Courtès
2024-12-12 11:51         ` Simon Tournier
2024-12-13 10:53         ` Nicolas Goaziou via Guix-patches via
2024-12-04 17:54   ` [bug#73073] [PATCH v3 2/8] gnu: gnome-recipes: Move libgd origin from phases to native-inputs Ludovic Courtès
2024-12-04 18:29     ` Liliana Marie Prikler
2024-12-12 11:27       ` Ludovic Courtès [this message]
2024-12-12 22:18         ` Liliana Marie Prikler
2024-12-12 22:34           ` Simon Tournier
2024-12-04 17:54   ` [bug#73073] [PATCH v3 3/8] gnu: dmd-bootstrap: Move phobos " Ludovic Courtès
2024-12-04 17:54   ` [bug#73073] [PATCH v3 4/8] gnu: smithforth: Move system.fs " Ludovic Courtès
2024-12-04 17:54   ` [bug#73073] [PATCH v3 5/8] gnu: farstream: Move common " Ludovic Courtès
2024-12-04 17:54   ` [bug#73073] [PATCH v3 6/8] gnu: gnulib: Move phobos " Ludovic Courtès
2024-12-04 17:54   ` [bug#73073] [PATCH v3 7/8] gnu: git: Move git-manpages " Ludovic Courtès
2024-12-04 17:54   ` [bug#73073] [PATCH v3 8/8] gnu: cgit: Remove input labels Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzc5b0pi.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=73073@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=maxim.cournoyer@gmail.com \
    --cc=vivien@planete-kraus.eu \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).