* [bug#75817] [PATCH] profiles: emacs-subdirs: Avoid building list with a loop
@ 2025-01-24 23:01 Thiago Jung Bauermann via Guix-patches via
2025-01-25 0:30 ` Liliana Marie Prikler
` (3 more replies)
0 siblings, 4 replies; 13+ messages in thread
From: Thiago Jung Bauermann via Guix-patches via @ 2025-01-24 23:01 UTC (permalink / raw)
To: 75817; +Cc: Liliana Marie Prikler, Thiago Jung Bauermann
If the EMACSNATIVELOADPATH environment variable (by mistake) has duplicated
paths, Emacs fails to load with:
$ emacs
List contains a loop:
("/home/user/.guix-profile/lib/emacs/native-site-lisp"
"/gnu/store/…-emacs-lsp-mode-9.0.0/lib/emacs/native-site-lisp"
"/home/user/.guix-profile/lib/emacs/native-site-lisp"
"/home/user/.guix-profile/lib/emacs/native-site-lisp"
"/gnu/store/…-emacs-lsp-mode-9.0.0/lib/emacs/native-site-lisp" . #2)
$ echo $?
255
A git bisect in Guix to find when the problem was introduced arrived at
commit e9b13294700d ("profiles: emacs-subdirs: Also expand
native-comp-eln-load-path.").
Fix the problem by applying Liliana's suggestion of changing 'nconc' to
'append' in the Elisp code written to subdirs.el.
* guix/profiles.scm (emacs-subdirs): Use 'append' rather than 'nconc'.
Change-Id: If646b806f24666b5247850d30d2819c7482c130b
Fixes: <https://issues.guix.gnu.org/75709>
Suggested-by: Liliana Marie Prikler <liliana.prikler@gmail.com>
---
guix/profiles.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/guix/profiles.scm b/guix/profiles.scm
index 87b9543ac01f..63b2a08a48d4 100644
--- a/guix/profiles.scm
+++ b/guix/profiles.scm
@@ -1230,8 +1230,8 @@ (define build
(setq native-comp-eln-load-path
(mapcan (lambda (dir)
(if (equal dir needle)
- (nconc ',native-comp-dirs
- (list dir))
+ (append ',native-comp-dirs
+ (list dir))
(list dir)))
native-comp-eln-load-path))))
port)
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [bug#75817] [PATCH] profiles: emacs-subdirs: Avoid building list with a loop
2025-01-24 23:01 [bug#75817] [PATCH] profiles: emacs-subdirs: Avoid building list with a loop Thiago Jung Bauermann via Guix-patches via
@ 2025-01-25 0:30 ` Liliana Marie Prikler
2025-01-25 4:16 ` Thiago Jung Bauermann via Guix-patches via
2025-01-25 4:14 ` [bug#75817] [PATCH v2] " Thiago Jung Bauermann via Guix-patches via
` (2 subsequent siblings)
3 siblings, 1 reply; 13+ messages in thread
From: Liliana Marie Prikler @ 2025-01-25 0:30 UTC (permalink / raw)
To: Thiago Jung Bauermann, 75817
Am Freitag, dem 24.01.2025 um 20:01 -0300 schrieb Thiago Jung
Bauermann:
> If the EMACSNATIVELOADPATH environment variable (by mistake) has
> duplicated paths, Emacs fails to load with:
>
> $ emacs
> List contains a loop:
> ("/home/user/.guix-profile/lib/emacs/native-site-lisp"
> "/gnu/store/…-emacs-lsp-mode-9.0.0/lib/emacs/native-site-lisp"
> "/home/user/.guix-profile/lib/emacs/native-site-lisp"
> "/home/user/.guix-profile/lib/emacs/native-site-lisp"
> "/gnu/store/…-emacs-lsp-mode-9.0.0/lib/emacs/native-site-lisp" .
> #2)
> $ echo $?
> 255
>
> A git bisect in Guix to find when the problem was introduced arrived
> at commit e9b13294700d ("profiles: emacs-subdirs: Also expand
> native-comp-eln-load-path.").
>
> Fix the problem by applying Liliana's suggestion of changing 'nconc'
> to 'append' in the Elisp code written to subdirs.el.
It's better to describe the bug in code so that folks won't stumble
over it again. E.g. "Note: needle may be found multiple times, so
don't use destructive procedures like nconc."
> * guix/profiles.scm (emacs-subdirs): Use 'append' rather than
> 'nconc'.
>
> Change-Id: If646b806f24666b5247850d30d2819c7482c130b
> Fixes: <https://issues.guix.gnu.org/75709>
You have some horizontal space here to name the bug :)
> Suggested-by: Liliana Marie Prikler <liliana.prikler@gmail.com>
> ---
> guix/profiles.scm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/guix/profiles.scm b/guix/profiles.scm
> index 87b9543ac01f..63b2a08a48d4 100644
> --- a/guix/profiles.scm
> +++ b/guix/profiles.scm
> @@ -1230,8 +1230,8 @@ (define build
> (setq native-comp-eln-load-path
> (mapcan (lambda (dir)
> (if (equal dir needle)
> - (nconc ',native-comp-
> dirs
> - (list dir))
> + (append ',native-comp-
> dirs
> + (list dir))
> (list dir)))
> native-comp-eln-load-path))))
> port)
Cheers
^ permalink raw reply [flat|nested] 13+ messages in thread
* [bug#75817] [PATCH v2] profiles: emacs-subdirs: Avoid building list with a loop
2025-01-24 23:01 [bug#75817] [PATCH] profiles: emacs-subdirs: Avoid building list with a loop Thiago Jung Bauermann via Guix-patches via
2025-01-25 0:30 ` Liliana Marie Prikler
@ 2025-01-25 4:14 ` Thiago Jung Bauermann via Guix-patches via
2025-01-25 14:26 ` Liliana Marie Prikler
2025-01-28 23:58 ` [bug#75817] (No Subject) Navajeeth via Guix-patches via
2025-01-29 2:22 ` [bug#75817] EXWM not starting Andres Moreno
3 siblings, 1 reply; 13+ messages in thread
From: Thiago Jung Bauermann via Guix-patches via @ 2025-01-25 4:14 UTC (permalink / raw)
To: 75817; +Cc: Liliana Marie Prikler, Thiago Jung Bauermann
If the EMACSNATIVELOADPATH environment variable (by mistake) has duplicated
paths, Emacs fails to load with:
$ emacs
List contains a loop:
("/home/user/.guix-profile/lib/emacs/native-site-lisp"
"/gnu/store/…-emacs-lsp-mode-9.0.0/lib/emacs/native-site-lisp"
"/home/user/.guix-profile/lib/emacs/native-site-lisp"
"/home/user/.guix-profile/lib/emacs/native-site-lisp"
"/gnu/store/…-emacs-lsp-mode-9.0.0/lib/emacs/native-site-lisp" . #2)
$ echo $?
255
A git bisect in Guix to find when the problem was introduced arrived at
commit e9b13294700d ("profiles: emacs-subdirs: Also expand
native-comp-eln-load-path.").
Fix the problem by applying Liliana's suggestion of changing 'nconc' to
'append' in the Elisp code written to subdirs.el.
* guix/profiles.scm (emacs-subdirs): Use 'append' rather than 'nconc'.
Change-Id: If646b806f24666b5247850d30d2819c7482c130b
Fixes: Emacs "List contains a loop" error <https://issues.guix.gnu.org/75709>
Suggested-by: Liliana Marie Prikler <liliana.prikler@gmail.com>
---
guix/profiles.scm | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
Changes since v1:
Made the following changes suggested by Liliana:
- Added comment to Elisp comment warning about destructive procedures
- Added short bug description to "Fixes" tag.
diff --git a/guix/profiles.scm b/guix/profiles.scm
index 87b9543ac01f..fb4dbc5bd079 100644
--- a/guix/profiles.scm
+++ b/guix/profiles.scm
@@ -1230,8 +1230,12 @@ (define build
(setq native-comp-eln-load-path
(mapcan (lambda (dir)
(if (equal dir needle)
- (nconc ',native-comp-dirs
- (list dir))
+ ;; Note: needle may be found
+ ;; multiple times, so don't use
+ ;; destructive procedures like
+ ;; nconc.
+ (append ',native-comp-dirs
+ (list dir))
(list dir)))
native-comp-eln-load-path))))
port)
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [bug#75817] [PATCH] profiles: emacs-subdirs: Avoid building list with a loop
2025-01-25 0:30 ` Liliana Marie Prikler
@ 2025-01-25 4:16 ` Thiago Jung Bauermann via Guix-patches via
0 siblings, 0 replies; 13+ messages in thread
From: Thiago Jung Bauermann via Guix-patches via @ 2025-01-25 4:16 UTC (permalink / raw)
To: Liliana Marie Prikler; +Cc: 75817
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> Am Freitag, dem 24.01.2025 um 20:01 -0300 schrieb Thiago Jung
> Bauermann:
>> If the EMACSNATIVELOADPATH environment variable (by mistake) has
>> duplicated paths, Emacs fails to load with:
>>
>> $ emacs
>> List contains a loop:
>> ("/home/user/.guix-profile/lib/emacs/native-site-lisp"
>> "/gnu/store/…-emacs-lsp-mode-9.0.0/lib/emacs/native-site-lisp"
>> "/home/user/.guix-profile/lib/emacs/native-site-lisp"
>> "/home/user/.guix-profile/lib/emacs/native-site-lisp"
>> "/gnu/store/…-emacs-lsp-mode-9.0.0/lib/emacs/native-site-lisp" .
>> #2)
>> $ echo $?
>> 255
>>
>> A git bisect in Guix to find when the problem was introduced arrived
>> at commit e9b13294700d ("profiles: emacs-subdirs: Also expand
>> native-comp-eln-load-path.").
>>
>> Fix the problem by applying Liliana's suggestion of changing 'nconc'
>> to 'append' in the Elisp code written to subdirs.el.
> It's better to describe the bug in code so that folks won't stumble
> over it again. E.g. "Note: needle may be found multiple times, so
> don't use destructive procedures like nconc."
Good point. I added your suggested note as a comment in the Elisp code.
>> * guix/profiles.scm (emacs-subdirs): Use 'append' rather than
>> 'nconc'.
>>
>> Change-Id: If646b806f24666b5247850d30d2819c7482c130b
>> Fixes: <https://issues.guix.gnu.org/75709>
> You have some horizontal space here to name the bug :)
Indeed. I added a short description.
Thank you for your quick review!
--
Thiago
^ permalink raw reply [flat|nested] 13+ messages in thread
* [bug#75817] [PATCH v2] profiles: emacs-subdirs: Avoid building list with a loop
2025-01-25 4:14 ` [bug#75817] [PATCH v2] " Thiago Jung Bauermann via Guix-patches via
@ 2025-01-25 14:26 ` Liliana Marie Prikler
2025-01-26 18:04 ` Thiago Jung Bauermann via Guix-patches via
2025-01-27 8:41 ` Ludovic Courtès
0 siblings, 2 replies; 13+ messages in thread
From: Liliana Marie Prikler @ 2025-01-25 14:26 UTC (permalink / raw)
To: Thiago Jung Bauermann, 75817
Am Samstag, dem 25.01.2025 um 01:14 -0300 schrieb Thiago Jung
Bauermann:
> If the EMACSNATIVELOADPATH environment variable (by mistake) has
> duplicated
> paths, Emacs fails to load with:
>
> $ emacs
> List contains a loop:
> ("/home/user/.guix-profile/lib/emacs/native-site-lisp"
> "/gnu/store/…-emacs-lsp-mode-9.0.0/lib/emacs/native-site-lisp"
> "/home/user/.guix-profile/lib/emacs/native-site-lisp"
> "/home/user/.guix-profile/lib/emacs/native-site-lisp"
> "/gnu/store/…-emacs-lsp-mode-9.0.0/lib/emacs/native-site-lisp" .
> #2)
> $ echo $?
> 255
>
> A git bisect in Guix to find when the problem was introduced arrived
> at commit e9b13294700d ("profiles: emacs-subdirs: Also expand
> native-comp-eln-load-path.").
>
> Fix the problem by applying Liliana's suggestion of changing 'nconc'
> to 'append' in the Elisp code written to subdirs.el.
>
> * guix/profiles.scm (emacs-subdirs): Use 'append' rather than
> 'nconc'.
>
> Change-Id: If646b806f24666b5247850d30d2819c7482c130b
> Fixes: Emacs "List contains a loop" error
> <https://issues.guix.gnu.org/75709>
> Suggested-by: Liliana Marie Prikler <liliana.prikler@gmail.com>
> ---
Reworded commit message slightly and pushed to emacs-team. Let's wait
a little for all Emacsen to rebuild on CI before merging this into
master :)
Thanks
^ permalink raw reply [flat|nested] 13+ messages in thread
* [bug#75817] [PATCH v2] profiles: emacs-subdirs: Avoid building list with a loop
2025-01-25 14:26 ` Liliana Marie Prikler
@ 2025-01-26 18:04 ` Thiago Jung Bauermann via Guix-patches via
2025-01-27 8:41 ` Ludovic Courtès
1 sibling, 0 replies; 13+ messages in thread
From: Thiago Jung Bauermann via Guix-patches via @ 2025-01-26 18:04 UTC (permalink / raw)
To: Liliana Marie Prikler; +Cc: 75817
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> Am Samstag, dem 25.01.2025 um 01:14 -0300 schrieb Thiago Jung
> Bauermann:
>> If the EMACSNATIVELOADPATH environment variable (by mistake) has
>> duplicated
>> paths, Emacs fails to load with:
>>
>> $ emacs
>> List contains a loop:
>> ("/home/user/.guix-profile/lib/emacs/native-site-lisp"
>> "/gnu/store/…-emacs-lsp-mode-9.0.0/lib/emacs/native-site-lisp"
>> "/home/user/.guix-profile/lib/emacs/native-site-lisp"
>> "/home/user/.guix-profile/lib/emacs/native-site-lisp"
>> "/gnu/store/…-emacs-lsp-mode-9.0.0/lib/emacs/native-site-lisp" .
>> #2)
>> $ echo $?
>> 255
>>
>> A git bisect in Guix to find when the problem was introduced arrived
>> at commit e9b13294700d ("profiles: emacs-subdirs: Also expand
>> native-comp-eln-load-path.").
>>
>> Fix the problem by applying Liliana's suggestion of changing 'nconc'
>> to 'append' in the Elisp code written to subdirs.el.
>>
>> * guix/profiles.scm (emacs-subdirs): Use 'append' rather than
>> 'nconc'.
>>
>> Change-Id: If646b806f24666b5247850d30d2819c7482c130b
>> Fixes: Emacs "List contains a loop" error
>> <https://issues.guix.gnu.org/75709>
>> Suggested-by: Liliana Marie Prikler <liliana.prikler@gmail.com>
>> ---
> Reworded commit message slightly and pushed to emacs-team. Let's wait
> a little for all Emacsen to rebuild on CI before merging this into
> master :)
>
> Thanks
Thank you!
--
Thiago
^ permalink raw reply [flat|nested] 13+ messages in thread
* [bug#75817] [PATCH v2] profiles: emacs-subdirs: Avoid building list with a loop
2025-01-25 14:26 ` Liliana Marie Prikler
2025-01-26 18:04 ` Thiago Jung Bauermann via Guix-patches via
@ 2025-01-27 8:41 ` Ludovic Courtès
2025-01-27 17:59 ` Liliana Marie Prikler
1 sibling, 1 reply; 13+ messages in thread
From: Ludovic Courtès @ 2025-01-27 8:41 UTC (permalink / raw)
To: Liliana Marie Prikler; +Cc: 75817, Thiago Jung Bauermann
Hello,
Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:
> Am Samstag, dem 25.01.2025 um 01:14 -0300 schrieb Thiago Jung
> Bauermann:
>> If the EMACSNATIVELOADPATH environment variable (by mistake) has
>> duplicated
>> paths, Emacs fails to load with:
>>
>> $ emacs
>> List contains a loop:
>> ("/home/user/.guix-profile/lib/emacs/native-site-lisp"
>> "/gnu/store/…-emacs-lsp-mode-9.0.0/lib/emacs/native-site-lisp"
>> "/home/user/.guix-profile/lib/emacs/native-site-lisp"
>> "/home/user/.guix-profile/lib/emacs/native-site-lisp"
>> "/gnu/store/…-emacs-lsp-mode-9.0.0/lib/emacs/native-site-lisp" .
>> #2)
>> $ echo $?
>> 255
>>
>> A git bisect in Guix to find when the problem was introduced arrived
>> at commit e9b13294700d ("profiles: emacs-subdirs: Also expand
>> native-comp-eln-load-path.").
>>
>> Fix the problem by applying Liliana's suggestion of changing 'nconc'
>> to 'append' in the Elisp code written to subdirs.el.
>>
>> * guix/profiles.scm (emacs-subdirs): Use 'append' rather than
>> 'nconc'.
>>
>> Change-Id: If646b806f24666b5247850d30d2819c7482c130b
>> Fixes: Emacs "List contains a loop" error
>> <https://issues.guix.gnu.org/75709>
>> Suggested-by: Liliana Marie Prikler <liliana.prikler@gmail.com>
>> ---
> Reworded commit message slightly and pushed to emacs-team. Let's wait
> a little for all Emacsen to rebuild on CI before merging this into
> master :)
Looking forward to applying this fix (exwm wouldn’t start this morning).
:-)
Ludo’.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [bug#75817] [PATCH v2] profiles: emacs-subdirs: Avoid building list with a loop
2025-01-27 8:41 ` Ludovic Courtès
@ 2025-01-27 17:59 ` Liliana Marie Prikler
2025-01-27 22:46 ` Ludovic Courtès
0 siblings, 1 reply; 13+ messages in thread
From: Liliana Marie Prikler @ 2025-01-27 17:59 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 75817, Thiago Jung Bauermann
Am Montag, dem 27.01.2025 um 09:41 +0100 schrieb Ludovic Courtès:
> Hello,
>
> Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:
>
> > Am Samstag, dem 25.01.2025 um 01:14 -0300 schrieb Thiago Jung
> > Bauermann:
> > > If the EMACSNATIVELOADPATH environment variable (by mistake) has
> > > duplicated
> > > paths, Emacs fails to load with:
> > >
> > > $ emacs
> > > List contains a loop:
> > > ("/home/user/.guix-profile/lib/emacs/native-site-lisp"
> > > "/gnu/store/…-emacs-lsp-mode-9.0.0/lib/emacs/native-site-lisp"
> > > "/home/user/.guix-profile/lib/emacs/native-site-lisp"
> > > "/home/user/.guix-profile/lib/emacs/native-site-lisp"
> > > "/gnu/store/…-emacs-lsp-mode-9.0.0/lib/emacs/native-site-lisp"
> > > .
> > > #2)
> > > $ echo $?
> > > 255
> > >
> > > A git bisect in Guix to find when the problem was introduced
> > > arrived
> > > at commit e9b13294700d ("profiles: emacs-subdirs: Also expand
> > > native-comp-eln-load-path.").
> > >
> > > Fix the problem by applying Liliana's suggestion of changing
> > > 'nconc'
> > > to 'append' in the Elisp code written to subdirs.el.
> > >
> > > * guix/profiles.scm (emacs-subdirs): Use 'append' rather than
> > > 'nconc'.
> > >
> > > Change-Id: If646b806f24666b5247850d30d2819c7482c130b
> > > Fixes: Emacs "List contains a loop" error
> > > <https://issues.guix.gnu.org/75709>
> > > Suggested-by: Liliana Marie Prikler <liliana.prikler@gmail.com>
> > > ---
> > Reworded commit message slightly and pushed to emacs-team. Let's
> > wait a little for all Emacsen to rebuild on CI before merging this
> > into master :)
>
> Looking forward to applying this fix (exwm wouldn’t start this
> morning).
> :-)
Welp, I just found out the hard way there is no jobset for emacs-team…
Should we add one or just directly push to master?
Cheers
^ permalink raw reply [flat|nested] 13+ messages in thread
* [bug#75817] [PATCH v2] profiles: emacs-subdirs: Avoid building list with a loop
2025-01-27 17:59 ` Liliana Marie Prikler
@ 2025-01-27 22:46 ` Ludovic Courtès
2025-02-03 19:40 ` Ludovic Courtès
0 siblings, 1 reply; 13+ messages in thread
From: Ludovic Courtès @ 2025-01-27 22:46 UTC (permalink / raw)
To: Liliana Marie Prikler; +Cc: 75817, Thiago Jung Bauermann
Hello,
Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:
>> Looking forward to applying this fix (exwm wouldn’t start this
>> morning).
>> :-)
> Welp, I just found out the hard way there is no jobset for emacs-team…
> Should we add one or just directly push to master?
There was one but it was deactivated; I’ve now reactivated it.
https://ci.guix.gnu.org/jobset/emacs-team
Ludo’.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [bug#75817] (No Subject)
2025-01-24 23:01 [bug#75817] [PATCH] profiles: emacs-subdirs: Avoid building list with a loop Thiago Jung Bauermann via Guix-patches via
2025-01-25 0:30 ` Liliana Marie Prikler
2025-01-25 4:14 ` [bug#75817] [PATCH v2] " Thiago Jung Bauermann via Guix-patches via
@ 2025-01-28 23:58 ` Navajeeth via Guix-patches via
2025-01-29 2:22 ` [bug#75817] EXWM not starting Andres Moreno
3 siblings, 0 replies; 13+ messages in thread
From: Navajeeth via Guix-patches via @ 2025-01-28 23:58 UTC (permalink / raw)
To: 75817@debbugs.gnu.org
[-- Attachment #1: Type: text/plain, Size: 163 bytes --]
How would I apply this patch? Like so?
guix build guix --with-patch=guix=guix.patch
My EXWM, too, wouldn’t start this morning and I am desperate.
—Navajeeth
[-- Attachment #2: Type: text/html, Size: 681 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [bug#75817] EXWM not starting
2025-01-24 23:01 [bug#75817] [PATCH] profiles: emacs-subdirs: Avoid building list with a loop Thiago Jung Bauermann via Guix-patches via
` (2 preceding siblings ...)
2025-01-28 23:58 ` [bug#75817] (No Subject) Navajeeth via Guix-patches via
@ 2025-01-29 2:22 ` Andres Moreno
3 siblings, 0 replies; 13+ messages in thread
From: Andres Moreno @ 2025-01-29 2:22 UTC (permalink / raw)
To: 75817
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
Navajeeth,
Have you tried reverting to a previous generation? This should have a
working version of Emacs, etc. You should be able to do this from the
console without entering your window manager.
Something along the lines of
guix package -S <previous generation>
or even
guix package --roll-back
to get you back to the previous working generation
Good luck!
[-- Attachment #2: Type: text/html, Size: 1107 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [bug#75817] [PATCH v2] profiles: emacs-subdirs: Avoid building list with a loop
2025-01-27 22:46 ` Ludovic Courtès
@ 2025-02-03 19:40 ` Ludovic Courtès
2025-02-03 20:24 ` bug#75817: " Liliana Marie Prikler
0 siblings, 1 reply; 13+ messages in thread
From: Ludovic Courtès @ 2025-02-03 19:40 UTC (permalink / raw)
To: Liliana Marie Prikler; +Cc: 75709, 75817, Thiago Jung Bauermann
Hey Liliana,
Ludovic Courtès <ludo@gnu.org> skribis:
> Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:
>
>>> Looking forward to applying this fix (exwm wouldn’t start this
>>> morning).
>>> :-)
>> Welp, I just found out the hard way there is no jobset for emacs-team…
>> Should we add one or just directly push to master?
>
> There was one but it was deactivated; I’ve now reactivated it.
>
> https://ci.guix.gnu.org/jobset/emacs-team
Could you please merge it if that’s OK?
I think it’s a real problem to keep Emacs broken when we have a fix and
substitutes.
Ludo’.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#75817: [PATCH v2] profiles: emacs-subdirs: Avoid building list with a loop
2025-02-03 19:40 ` Ludovic Courtès
@ 2025-02-03 20:24 ` Liliana Marie Prikler
0 siblings, 0 replies; 13+ messages in thread
From: Liliana Marie Prikler @ 2025-02-03 20:24 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 75709-done, 75817-done, Thiago Jung Bauermann
Am Montag, dem 03.02.2025 um 20:40 +0100 schrieb Ludovic Courtès:
> Hey Liliana,
>
> Ludovic Courtès <ludo@gnu.org> skribis:
>
> > Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:
> >
> > > > Looking forward to applying this fix (exwm wouldn’t start this
> > > > morning).
> > > > :-)
> > > Welp, I just found out the hard way there is no jobset for emacs-
> > > team… Should we add one or just directly push to master?
> >
> > There was one but it was deactivated; I’ve now reactivated it.
> >
> > https://ci.guix.gnu.org/jobset/emacs-team
>
> Could you please merge it if that’s OK?
>
> I think it’s a real problem to keep Emacs broken when we have a fix
> and substitutes.
Ahh, my bad. It was already merged as
f9b1e548c95a115e2bb143d0f4b1632a600f32da, but I forgot to close the
bug.
Cheers
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2025-02-03 20:25 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-24 23:01 [bug#75817] [PATCH] profiles: emacs-subdirs: Avoid building list with a loop Thiago Jung Bauermann via Guix-patches via
2025-01-25 0:30 ` Liliana Marie Prikler
2025-01-25 4:16 ` Thiago Jung Bauermann via Guix-patches via
2025-01-25 4:14 ` [bug#75817] [PATCH v2] " Thiago Jung Bauermann via Guix-patches via
2025-01-25 14:26 ` Liliana Marie Prikler
2025-01-26 18:04 ` Thiago Jung Bauermann via Guix-patches via
2025-01-27 8:41 ` Ludovic Courtès
2025-01-27 17:59 ` Liliana Marie Prikler
2025-01-27 22:46 ` Ludovic Courtès
2025-02-03 19:40 ` Ludovic Courtès
2025-02-03 20:24 ` bug#75817: " Liliana Marie Prikler
2025-01-28 23:58 ` [bug#75817] (No Subject) Navajeeth via Guix-patches via
2025-01-29 2:22 ` [bug#75817] EXWM not starting Andres Moreno
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).