From: Ricardo Wurmus <rekado@elephly.net>
To: John Darrington <jmd@gnu.org>
Cc: 26108@debbugs.gnu.org
Subject: bug#26108: [PATCH 6/7] gnu: Add mia.
Date: Thu, 30 Mar 2017 15:15:51 +0200 [thread overview]
Message-ID: <87inmq52ig.fsf@elephly.net> (raw)
In-Reply-To: <1489608324-23632-6-git-send-email-jmd@gnu.org>
John Darrington <jmd@gnu.org> writes:
> * gnu/packages/image-processing.scm (mia): New variable.
[…]
> +
> +(define-public mia
> + (package
> + (name "mia")
> + (version "2.4.3")
> + (source (origin
> + ;; There are too many issues with the released version which
> + ;; prevent a clean build and test under Guix. So until the next
> + ;; release I suggest we use this git checkout.
That’s okay. Could you please wrap the “(package …)“ expression in a
let expression where ‘commit’ is bound to
"d91cade30a10f179bba8c8e48b84983a296d2c33" and ‘revision’ to "1". Then
the version field should be changed to
(string-append "2.4.3-" revision "." (string-take commit 7))
because this is not exactly version "2.4.3”.
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://git.code.sf.net/p/mia/mia2")
> + (commit
> "d91cade30a10f179bba8c8e48b84983a296d2c33")))
After wrapping the thing in a let binding you can use “(commit commit)”
here.
> + (sha256
> + (base32
> + "0y8ihqbliqy21fph3dm5h6k2nvjbajx4y0mn351x990r9y0767vz"))
> + (file-name (string-append name "-" version))))
Usually, we append “-checkout” to git clones.
> + (build-system cmake-build-system)
> + (arguments `(#:configure-flags `("-DMIA_CREATE_NIPYPE_INTERFACES=0"
> + ,(string-append "-DCMAKE_INSTALL_LIBDIR="
> + (assoc-ref %outputs "out")
> + "/lib")
> + ;; According to upstream this is necessary
> + ;; with g++-4.9.x because the std::regex
> + ;; library doesn't work reliably.
> + "-DMIA_USE_BOOST_REGEX=ON"
> +
> "-DCMAKE_CXX_FLAGS=-fpermissive")))
I have a slight preference to adding a line break after “arguments”.
> + (inputs `(("boost" ,boost)
> + ("dcmtk" ,dcmtk)
> + ("doxygen" ,doxygen)
I think this should be a native input.
Please also add a line break after “inputs”.
> + ("eigen" ,eigen)
> + ("fftw" ,fftw)
> + ("fftwf" ,fftwf)
> + ("gsl" ,gsl)
> + ("gts" ,gts)
> + ("hdf5" ,hdf5)
> + ("itpp" ,itpp)
> + ("libjpeg" ,libjpeg)
> + ("libpng" ,libpng)
> + ("libtiff" ,libtiff)
> + ("libxml" ,libxml2)
> + ("libxml++" ,libxml++)
> + ("maxflow" ,maxflow)
> + ("niftilib" ,niftilib)
> + ("nlopt" ,nlopt)
> + ("openexr" ,openexr)
> + ("python-lxml" ,python2-lxml)
> + ("vtk" ,vtk@6.3)))
> + (native-inputs `(("pkg-config" ,pkg-config)
> + ("python" ,python-2)))
Please add a line break after “native-inputs” (for consistency). Please
also collapse the spaces after "pkg-config".
> + (synopsis "Toolkit for gray scale medical image analysis")
> + (description "MIA provides a combination of command line tools, plug-ins,
> +and libraries that make it possible run image processing tasks interactively
> +in a command shell and to prototype using the shell's scripting
> +language. It is built around a plug-in structure that makes it easy to add
> +functionality without compromising the original code base and it makes use of a
> +wide variety of external libraries that provide additional functionality.")
> + (home-page "http://mia.sourceforge.net")
> + (license license:gpl3+)))
The rest looks good to me (I did not check the license). Would you like
to push an updated version or would you like me to make the changes
myself?
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
https://elephly.net
next parent reply other threads:[~2017-03-30 12:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1489608324-23632-1-git-send-email-jmd@gnu.org>
[not found] ` <1489608324-23632-6-git-send-email-jmd@gnu.org>
2017-03-30 13:15 ` Ricardo Wurmus [this message]
2017-03-31 5:27 ` bug#26108: [PATCH 6/7] gnu: Add mia John Darrington
2017-05-15 21:09 ` Ricardo Wurmus
[not found] ` <1489608324-23632-5-git-send-email-jmd@gnu.org>
2017-05-11 6:44 ` bug#26111: [PATCH 5/7] gnu: Add vtk version 6.3.0 Ricardo Wurmus
[not found] ` <1489608324-23632-3-git-send-email-jmd@gnu.org>
[not found] ` <871stv7hyk.fsf@openmailbox.org>
[not found] ` <20170318072335.GA12217@jocasta.intra>
[not found] ` <20170321021240.GA29321@jasmine>
[not found] ` <20170321023043.GA455@jocasta.intra>
[not found] ` <20170321183012.GC28482@jasmine>
2017-05-15 21:07 ` bug#26109: [PATCH 3/7] gnu: Add dcmtk Ricardo Wurmus
[not found] ` <1489608324-23632-7-git-send-email-jmd@gnu.org>
2017-06-02 16:31 ` bug#26110: [PATCH 7/7] gnu: Move vtk to image-processing.scm Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inmq52ig.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=26108@debbugs.gnu.org \
--cc=jmd@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).