unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Petter <petter@mykolab.ch>
Cc: 26776@debbugs.gnu.org
Subject: bug#26776: [PATCH] gnu: Add Parcimonie.
Date: Thu, 11 May 2017 23:31:10 +0200	[thread overview]
Message-ID: <87inl7krmp.fsf@gnu.org> (raw)
In-Reply-To: <20170504135128.4747771c@mykolab.ch> (petter@mykolab.ch's message of "Thu, 4 May 2017 13:51:28 +0200")

Hi Petter,

Petter <petter@mykolab.ch> skribis:

> From fdf2b751d19a1c9397535cb5054557b1fd711d23 Mon Sep 17 00:00:00 2001
> From: Petter <petter@mykolab.ch>
> Date: Sun, 30 Apr 2017 11:40:06 +0200
> Subject: [PATCH] gnu: Add Parcimonie.
>
> * gnu/packages/gnupg.scm: New variables.
> * gnu/packages/perl.scm: Same.
> * gnu/packages/web.scm: Same.
> * gnu/packages/xml.scm: Same.

Overall this looks good to me, and a useful addition!  There are a few
“cosmetic” things that I think should be addressed:

[...]

> +    (synopsis "Lorem Ipsum")
> +    (description "Lorem Ipsum")

Could you fix this?  :-)

> +(define-public perl-archive-extract
> +(package
> +  (name "perl-archive-extract")
> +  (version "0.80")
> +  (source
> +    (origin
> +      (method url-fetch)
> +      (uri (string-append
> +             "mirror://cpan/authors/id/B/BI/BINGOS/Archive-Extract-"
> +             version
> +             ".tar.gz"))
> +      (sha256
> +        (base32
> +          "1x15j1q6w6z8hqyqgap0lz4qbq2174wfhksy1fdd653ccbaw5jr5"))))
> +  (build-system perl-build-system)
> +  (home-page
> +    "http://search.cpan.org/dist/Archive-Extract")
> +  (synopsis "Generic archive extracting mechanism")
> +  (description "It allows you to extract any archive file of the type .tar, .tar.gz, .gz, .Z, tar.bz2, .tbz, .bz2, .zip, .xz,, .txz, .tar.xz or .lzma without having to worry how it does so, or use different interfaces for each type by using either perl modules, or commandline tools on your system.")
> +  (license (package-license perl))))

Please run:

  ./etc/indent-code.el gnu/packages/perl.scm perl-archive-extract
  ./pre-inst-env guix lint perl-archive-extract

Likewise for the other packages here.

Last thing: we usually submit one package per patch.  Do you think you
could split the patch?  If not, if there are no objections (Ricardo?),
we could consider making an exception…

Thanks in advance!

Ludo’.

  reply	other threads:[~2017-05-11 21:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-04 11:51 bug#26776: [PATCH] gnu: Add Parcimonie Petter
2017-05-11 21:31 ` Ludovic Courtès [this message]
2017-10-25  8:53   ` Ricardo Wurmus
2017-10-26 22:17     ` [bug#26776] " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87inl7krmp.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=26776@debbugs.gnu.org \
    --cc=petter@mykolab.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).