[bug#27682] [PATCH 2/2] gnu: Add lxc.

[iyzsong@member.fsf.org (宋文武)]

Marius Bakke <mbakke@fastmail.com> writes:

> 宋文武 <iyzsong@member.fsf.org> writes:
>
>> * gnu/packages/virtualization.scm (lxc): New package.
>
> Thanks!
>
> [...]
>
>> +    (arguments
>> +     '(#:configure-flags
>> +       '("--sysconfdir=/etc"
>> +         "--localstatedir=/var")
>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (replace 'install
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (let* ((out         (assoc-ref outputs "out"))
>> +                    (bashcompdir (string-append out "/etc/bash_completion.d")))
>> +               (zero? (system*
>> +                       "make" "install"
>> +                       (string-append "bashcompdir=" bashcompdir)
>> +                       ;; Thoses files will be handled by system services.
>> +                       "LXCPATH=/tmp/var/lib/lxc"
>> +                       "localstatedir=/tmp/var"
>> +                       "sysconfdir=/tmp/etc"
>> +                       "sysconfigdir=/tmp/etc/default"))))))))
>
> If these are not important, why not set them to $out/etc, $out/var and
> so on? /tmp seems like a dangerous default to me, since any unprivileged
> user can populate these directories.

Those paths are configured to '/var/lib/lxc', '/var' etc.  The install
phase drop them to avoid touching system directories in the builder.
The effective paths are still '/var/lib/lxc', owned by root, which will
be handled by lxc-service-type and alike.