From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60548)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dl0ah-0000Bv-6I
	for guix-patches@gnu.org; Thu, 24 Aug 2017 18:27:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dl0ac-0006TX-4r
	for guix-patches@gnu.org; Thu, 24 Aug 2017 18:27:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:44628)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dl0ac-0006TR-15
	for guix-patches@gnu.org; Thu, 24 Aug 2017 18:27:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dl0ab-0001US-RW
	for guix-patches@gnu.org; Thu, 24 Aug 2017 18:27:01 -0400
Subject: [bug#27907] [PATCH] graph: Provide access to the package record in
	the emit
Resent-Message-ID: <handler.27907.B27907.15036136025702@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <rbumv7j4aii.fsf@gnu.org> <87lgn3w0n6.fsf@gnu.org>
Date: Fri, 25 Aug 2017 00:26:23 +0200
In-Reply-To: <87lgn3w0n6.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Tue, 01 Aug 2017 21:25:49 +0200")
Message-ID: <87inhchab4.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Roel Janssen <roel@gnu.org>
Cc: 27907@debbugs.gnu.org

Hi!

ludo@gnu.org (Ludovic Court=C3=A8s) skribis:

> Roel Janssen <roel@gnu.org> skribis:
>
>> I would like to expand the Cypher back-end and in the long run add a
>> SPARQL graph back-end to GNU Guix.  For this, I will need to have access
>> to the package records inside the emit-* functions.
>>
>> This patch makes this change by essentially changing the "label"
>> parameter of the emit-* functions passed as "(node-label head)" into a
>> "node" parameter, passed as "head".
>>
>> The rest of the patch adapts the current emit-* functions to this
>> change.
>>
>> I tested the Graphviz, D3js, and Cypher back-ends, and all seem to work
>> as before.
>>
>> Is it OK to apply this change?
>
> Sure, looks good to me!

Actually no!  :-)

The problem was that it broke all non-package-related =E2=80=9Cnode types=
=E2=80=9D (like
=E2=80=9Cguix graph -t references=E2=80=9D), and it had the problem that it=
 ignores the
=E2=80=98label=E2=80=99 procedure in <node-type>.  And =E2=80=9Cmake check=
=E2=80=9D failed.

So I reverted it in 5e60bef9802e448924f889d34d95a249b008652c.  We need
to rethink about it.

Cheers,
Ludo=E2=80=99.