From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2CN0-0000at-W0 for guix-patches@gnu.org; Wed, 11 Oct 2017 04:28:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2CMz-0005Of-W9 for guix-patches@gnu.org; Wed, 11 Oct 2017 04:28:02 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:52542) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e2CMz-0005Ob-T6 for guix-patches@gnu.org; Wed, 11 Oct 2017 04:28:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e2CMz-0002Do-MW for guix-patches@gnu.org; Wed, 11 Oct 2017 04:28:01 -0400 Subject: [bug#27344] [PATCH v3 7/8] gnu: Add qucs. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87lglnery8.fsf@foradis.org> <20170909175752.8566-1-theodoros@foradis.org> <20170909175752.8566-7-theodoros@foradis.org> Date: Wed, 11 Oct 2017 10:27:15 +0200 In-Reply-To: <20170909175752.8566-7-theodoros@foradis.org> (Theodoros Foradis's message of "Sat, 9 Sep 2017 20:57:51 +0300") Message-ID: <87infmccnw.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Theodoros Foradis Cc: 27344@debbugs.gnu.org Hi, Theodoros Foradis skribis: > * gnu/packages/engineering.scm (qucs): New variable. [...] > + (propagated-inputs > + `(("gcc-toolchain" ,gcc-toolchain-5))) ; for freehdl What=E2=80=99s the reason for this? Propagated inputs should be used sparsely because they =E2=80=9Cpollute=E2= =80=9D user profiles. Here we=E2=80=99d be forcing a big package, and a specific versi= on of that, in user profiles, which is not OK. Apart from that the patch LGTM though, so if we can remove these two lines, we can commit. Thank you! Ludo=E2=80=99.