From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRjqX-0007hu-AP for guix-patches@gnu.org; Wed, 20 Dec 2017 14:16:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRjqU-0000M0-5f for guix-patches@gnu.org; Wed, 20 Dec 2017 14:16:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:36066) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eRjqU-0000Lp-0g for guix-patches@gnu.org; Wed, 20 Dec 2017 14:16:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eRjqT-0002He-Nc for guix-patches@gnu.org; Wed, 20 Dec 2017 14:16:01 -0500 Subject: [bug#29409] Remove hugetlb control group on ARM32. References: <877euhtjkj.fsf@gmail.com> In-Reply-To: <877euhtjkj.fsf@gmail.com> Resent-Message-ID: From: Mathieu Othacehe Date: Wed, 20 Dec 2017 20:15:07 +0100 Message-ID: <87ind19pok.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 29409@debbugs.gnu.org --=-=-= Content-Type: text/plain Hi Guix, Mounting %control-groups fails on ARM32 platform because we build a kernel without LPAE support which implies hugetlb control group cannot be supported. Like Debian we could have an ARMMP and ARMMP-LPAE kernel but the problem would still exists for ARMMP. I'm not sure what do about, a workaround could be the ugly hack attached, WDYT ? Thanks, Mathieu --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-file-systems-Do-not-mount-hugetlb-cgroup-filesystem-.patch >From 2172a1897a9729b65767bb58883247a3c604109f Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Wed, 20 Dec 2017 20:02:33 +0100 Subject: [PATCH] file-systems: Do not mount hugetlb cgroup filesystem on arm32. On ARM32 without LPAE support, hugetlb control group is not supported. * gnu/system/file-systems.scm (%control-groups): Remove hugetlb from control groups on arm32 platforms. --- gnu/system/file-systems.scm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gnu/system/file-systems.scm b/gnu/system/file-systems.scm index 27734e892..cbe6a725a 100644 --- a/gnu/system/file-systems.scm +++ b/gnu/system/file-systems.scm @@ -21,6 +21,7 @@ #:use-module (rnrs bytevectors) #:use-module (srfi srfi-1) #:use-module (guix records) + #:use-module (guix utils) #:use-module (gnu system uuid) #:re-export (uuid ;backward compatibility string->uuid @@ -278,8 +279,9 @@ TARGET in the other system." ;; This must be mounted after, and unmounted before the ;; parent directory. (dependencies (list parent)))) - '("cpuset" "cpu" "cpuacct" "memory" "devices" "freezer" - "blkio" "perf_event" "hugetlb"))))) + `("cpuset" "cpu" "cpuacct" "memory" "devices" "freezer" + "blkio" "perf_event" + ,@(if (not (target-arm32?)) '("hugetlb") '())))))) (define %elogind-file-systems ;; We don't use systemd, but these file systems are needed for elogind, -- 2.15.0 --=-=-=--