From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezYZO-0001MS-93 for guix-patches@gnu.org; Fri, 23 Mar 2018 22:06:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezYZG-0000Jt-UY for guix-patches@gnu.org; Fri, 23 Mar 2018 22:06:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:42386) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ezYZG-0000Jl-RZ for guix-patches@gnu.org; Fri, 23 Mar 2018 22:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ezYZG-0002ER-F3 for guix-patches@gnu.org; Fri, 23 Mar 2018 22:06:02 -0400 Subject: bug#30572: [PATCH 2/7] tests: Add tests for "guix pack". Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Chris Marusich References: <20180222102933.4978-1-cmmarusich@gmail.com> <20180315040915.5556-1-cmmarusich@gmail.com> <20180315040915.5556-3-cmmarusich@gmail.com> <20180316220732.19c2375a@scratchpost.org> <87a7v6pnmm.fsf@gnu.org> <87y3im5b7u.fsf@gmail.com> <87h8pa59yn.fsf@gmail.com> <87in9od8nv.fsf@gmail.com> <87a7v0lb20.fsf@gnu.org> Date: Sat, 24 Mar 2018 03:05:31 +0100 In-Reply-To: <87a7v0lb20.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 22 Mar 2018 10:22:15 +0100") Message-ID: <87in9mw7mc.fsf@garuda.local.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Danny Milosavljevic Cc: 30572-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo and Danny, I've committed this patch set to master (8e88f6fa8236a1fe66912957ecacae348355ec15 is the last commit in the series)! I'll watch Hydra to make sure it doesn't cause any unexpected breakage. ludo@gnu.org (Ludovic Court=C3=A8s) writes: >> +if is_available chroot && is_available unshare; then >> + # Verify we can extract and use it. >> + test_directory=3D"`mktemp -d`" >> + trap 'rm -rf "$test_directory"' EXIT >> + cd "$test_directory" >> + tar -xf "$the_pack" >> + unshare -r chroot . /opt/gnu/bin/guile --version >> + cd - >> +else >> + echo "warning: skipping pack verification because chroot or unshare= is unavailable" >&2 >> +fi > > I just realized we could unconditionally extra the pack, do > > test -x "$test_directory/opt/gnu/bin/guile" > > and keep only the =E2=80=98unshare=E2=80=99 bit in the conditional. > > But I=E2=80=99m nitpicking, please push, with or without this change! :-) That's a good idea. I've included that improvement in my changes. > Thanks for your patience, Thank you and Danny for taking the time to review this patch series! Your feedback definitely helped make the code better. Now I just need to go write a blog post... :-) =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAlq1smsACgkQ3UCaFdgi Rp2igRAAxQAJtNPeHmSspKOh39NfsHxbMrceYoWgLk5DuLFReLniJybtjGhNyxfo 9gHrUbWC7VFMXm3dqx0NLoXhNJ7hmehlNfMBi/rw4XjB/A4gXPEXrc9eOEUQxMU5 rGjaSIor6zpLMOb1rlfl9f7My96Z6Dxjxhk79/Cjq3c3cnPIHqnDnXzabPXJImkF QukWx3AyRiBGGu7Kc6YgIMQDd7+9emVWkNYihETpP896gPlgBaiapElnZAQjVQwF 42jJ/FxiW9QMXvqEoj8naFmT1M/bgeBDeuwde1TLqFQcjkdRw4t5sedyGqIKPlGN RYu4qrq1dILwrgTWB7Vpml4/aj/V4kPkLdl7c5pPgzv8/qYdljhspnmLSsb4kH4a 19TeftHq5vbqBmil3qayuwiryHrkNR56S/XrpWO/RdZKJK9MP5cj3/a3EcYONBOk 9y9rc7ShOsjnu8udVmBfnEtsXFVxBuZETEzK9s+dS7+XruVhK7I54dPAC94OO8UM jL/VEXsg5W2Vdhhz8OiI8XHAJoS4WJxWYBJqDSjf5FzELxBSSirK1MbWHD19bBJF lvcZNwFgL1ZPVCDHRg6DmXAwoymTxwFPobYEfjilZ9WXW4jSse2aP3gW6YHPCdcg gorK5qekshLkAp0dYgkOyn03KSpuphG7N533WnXpOn5Koqr7Dxo= =67YO -----END PGP SIGNATURE----- --=-=-=--