unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Clément Lassieur" <clement@lassieur.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 31156-done@debbugs.gnu.org
Subject: bug#31156: [PATCH 2/2] gnu: gajim: Update to 1.0.1.
Date: Tue, 17 Apr 2018 11:23:58 +0200	[thread overview]
Message-ID: <87in8qyymp.fsf@lassieur.org> (raw)
In-Reply-To: <878t9mdc4p.fsf@fastmail.com>

Marius Bakke <mbakke@fastmail.com> writes:

> Clément Lassieur <clement@lassieur.org> writes:
>
>> * gnu/packages/messaging.scm (python2-nbxmpp): Remove variable.
>> (gajim): Update to 1.0.1.
>> [build-system]: Change to PYTHON-BUILD-SYSTEM.
>> [arguments]: Remove the PYTHONPATH wrapper.  Don't override "APP".  Add a
>> GI_TYPELIB_PATH wrapper.  Add 'remove-test-resolver, 'start-xserver and
>> 'install-icons phases.
>> [native-inputs]: Add XORG-SERVER.
>> [inputs]: Remove PYTHON2-AXOLOTL, PYTHON2-NBXMPP, PYTHON2-PYOPENSSL,
>> PYTHON2-GNUPG, PYTHON2-PYGTK, PYTHON-2.  Add ADWAITA-ICON-THEME,
>> GNOME-KEYRING, GTK+, GTKSPELL3, HICOLOR-ICON-THEME, LIBSECRET, PYTHON-DBUS,
>> PYTHON-DOCUTILS, PYTHON-GNUPG, PYTHON-NBXMPP, PYTHON-PILLOW, PYTHON-PYASN1,
>> PYTHON-PYCAIRO, PYTHON-PYGOBJECT, PYTHON-PYOPENSSL.
>
> Wooow, nice work.  Is there any reason to remove python2-nbmxmpp?  I
> understand gajim was the only consumer in Guix, but it may be needed
> again in the future, or be in use by downstreams.
>
> If upstream no longer supports Python2, maybe it would be better as a
> separate change/squashed in the previous commit?
>
> Anyway, thanks for this, the Gajim changes LGTM!

Hi Marius,

I'm fine with keeping python2-nbxmpp, just in case someone needs it
later, so I re-added it and pushed.

Thank you for reviewing!
Clément

  reply	other threads:[~2018-04-17  9:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-14 22:33 [bug#31156] Update Gajim to 1.0.1 Clément Lassieur
2018-04-14 22:35 ` [bug#31156] [PATCH 1/2] gnu: python-nbxmpp: Update to 0.6.4 Clément Lassieur
2018-04-14 22:35   ` [bug#31156] [PATCH 2/2] gnu: gajim: Update to 1.0.1 Clément Lassieur
2018-04-15  8:31     ` Clément Lassieur
2018-04-16 22:23     ` Marius Bakke
2018-04-17  9:23       ` Clément Lassieur [this message]
2018-04-16 22:18   ` [bug#31156] [PATCH 1/2] gnu: python-nbxmpp: Update to 0.6.4 Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87in8qyymp.fsf@lassieur.org \
    --to=clement@lassieur.org \
    --cc=31156-done@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).