From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBSdy-00024W-P8 for guix-patches@gnu.org; Wed, 25 Apr 2018 18:12:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fBSdv-0002Gi-DS for guix-patches@gnu.org; Wed, 25 Apr 2018 18:12:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:59981) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fBSdv-0002GV-Ap for guix-patches@gnu.org; Wed, 25 Apr 2018 18:12:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fBSdt-0001Oi-Rx for guix-patches@gnu.org; Wed, 25 Apr 2018 18:12:03 -0400 Subject: [bug#31102] [PATCH] gnu: wpa-supplicant: Install wpa_gui. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) In-Reply-To: <871sf5aiqo.fsf@fastmail.com> (Marius Bakke's message of "Mon, 23 Apr 2018 20:19:11 +0200") References: <20180408202241.10285-1-mbakke@fastmail.com> <87k1tgglmc.fsf@gnu.org> <871sf5aiqo.fsf@fastmail.com> Date: Thu, 26 Apr 2018 00:11:40 +0200 Message-ID: <87in8fndgj.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 31102-done@debbugs.gnu.org Howdy Marius, Marius Bakke skribis: > Ludovic Court=C3=A8s writes: > >> Hi Marius, >> >> Marius Bakke skribis: >> >>> * gnu/packages/admin.scm (wpa-supplicant)[inputs]: Add QTBASE and QTSVG. >>> [native-inputs]: Add IMAGEMAGICK and INKSCAPE. >>> [outputs]: New field. >>> [arguments]: Add phases 'build-wpa-gui' and 'install-wpa-gui'. >> >> The patch LGTM, but I wonder if we should make it a separate package. >> >> Since it uses a separate output, that should be fine *if* you get >> substitutes. If you don=E2=80=99t, then you end up building Qt. >> >> Since wpa_supplicant is a requirement for most GuixSD configs, that >> could be an issue. >> >> From the patch, it seems that the GUI is well isolated, in a separate >> directory, with a different build system and all. Do you think it would >> work to make a separate =E2=80=9Cwpa-supplicant-gui=E2=80=9D package? W= DYT? > > Yes, that makes sense. I pushed it as a separate package in > 050e5756781cdfed2d790e15c67bc48c9aced131. Awesome, thank you! Ludo=E2=80=99.