unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: swedebugia <swedebugia@riseup.net>
Cc: 33436@debbugs.gnu.org
Subject: [bug#33436] [PATCH] gnu: Add python-warcio.
Date: Wed, 21 Nov 2018 11:21:06 +0100	[thread overview]
Message-ID: <87in0qu3xp.fsf@gnu.org> (raw)
In-Reply-To: <4f8816d0-8b47-7299-f31b-a2fa0f592d2d@riseup.net> (swedebugia's message of "Mon, 19 Nov 2018 21:41:46 +0100")

Hello!

swedebugia <swedebugia@riseup.net> skribis:

>>From 537b2b111a464956bdec640ea5f84c4598ea66f9 Mon Sep 17 00:00:00 2001
> From: swedebugia <swedebugia@riseup.net>
> Date: Mon, 19 Nov 2018 21:37:46 +0100
> Subject: [PATCH] gnu: Add python-warcio.
>
> * gnu/packages/python.scm: New variable.
                           ^
Nitpick: You forgot the variable name here.  :-)

> +   (arguments
> +    ;; FIXME: Some tests require network access. 150 out of 1354 fail
> +    '(#:tests? #f))

Could you investigate a bit further?  What do the test logs show?

It would be good to see if these tests can be easily fixed, if they
should definitely be skipped (for instance because they rely on some
external service), or if it’s something else.

> +   (home-page "https://github.com/webrecorder/warcio")
> +   (synopsis "Streaming web archival archive (WARC) library")
> +   (description
> +    "warcio is designed for fast, low-level access to web archival
                 ^^
What about: “warcio is a Python library to read and write the WARC format
commonly used in Web archives.  It is designed for…”?

Thank you,
Ludo’.

  reply	other threads:[~2018-11-21 10:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-19 20:41 [bug#33436] [PATCH] gnu: Add python-warcio swedebugia
2018-11-21 10:21 ` Ludovic Courtès [this message]
2019-01-11  8:29   ` Ludovic Courtès
2019-02-24  2:01     ` swedebugia
2019-03-04 13:43       ` Ludovic Courtès
2021-07-13 15:23   ` bug#33436: " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87in0qu3xp.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=33436@debbugs.gnu.org \
    --cc=swedebugia@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).