From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:42836)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hN1qB-0005Fw-HB
	for guix-patches@gnu.org; Sat, 04 May 2019 17:05:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hN1qA-0006Gn-71
	for guix-patches@gnu.org; Sat, 04 May 2019 17:05:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:38900)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hN1qA-0006Ga-2u
	for guix-patches@gnu.org; Sat, 04 May 2019 17:05:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hN1q9-0005Ev-Lz
	for guix-patches@gnu.org; Sat, 04 May 2019 17:05:01 -0400
Subject: [bug#35545] [PATCH 08/17] gnu: Add java-openjfx-base.
Resent-Message-ID: <handler.35545.B35545.155700384220054@debbugs.gnu.org>
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
References: <20190503145820.606f37db@sybil.lepiller.eu>
	<20190503130134.24788-1-julien@lepiller.eu>
	<20190503130134.24788-8-julien@lepiller.eu>
	<87v9yrvabq.fsf@nicolasgoaziou.fr>
	<20190504133850.71eddeb5@sybil.lepiller.eu>
Date: Sat, 04 May 2019 23:03:55 +0200
In-Reply-To: <20190504133850.71eddeb5@sybil.lepiller.eu> (Julien Lepiller's
	message of "Sat, 4 May 2019 13:38:50 +0200")
Message-ID: <87imuqextw.fsf@nicolasgoaziou.fr>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 35545@debbugs.gnu.org

Hello,

Julien Lepiller <julien@lepiller.eu> writes:

> Thanks! I fixed that and your comment on patch 07. Is there anything
> more? Do you need more time for a complete review or have you reviewed
> everything already?

I read your patches in order to learn a bit more about the Ant build
system, which I never used before. I didn't find any obvious typo in the
rest of the patches, but I cannot comment on the build part.

Regards,

-- 
Nicolas Goaziou