From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:47294) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcUmP-0002jX-Jv for guix-patches@gnu.org; Sun, 16 Jun 2019 09:01:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcUmN-00031G-Ib for guix-patches@gnu.org; Sun, 16 Jun 2019 09:01:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54665) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hcUmM-00030y-5Q for guix-patches@gnu.org; Sun, 16 Jun 2019 09:01:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hcUmL-0006TU-KK for guix-patches@gnu.org; Sun, 16 Jun 2019 09:01:02 -0400 Subject: [bug#35790] [PATCH] scripts: lint: Handle warnings with a record type. Resent-Message-ID: References: <878suz27ke.fsf@gnu.org> <20190601183135.11882-1-mail@cbaines.net> <87ftolj0v2.fsf@gnu.org> From: Christopher Baines In-reply-to: <87ftolj0v2.fsf@gnu.org> Date: Sun, 16 Jun 2019 14:00:16 +0100 Message-ID: <87imt5u1lr.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 35790@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hello, > > Christopher Baines skribis: > >> Rather than emiting warnings directly to a port, have the checkers retur= n the >> warning or warnings. >> >> This makes it easier to use the warnings in different ways, for example, >> loading the data in to a database, as you can work with the >> records directly, rather than having to parse the output to determine the >> package and location. > > I like it! > > Maybe we should just ignore the i18n issue for now and keep > already-translated messages in . I want the Guix Data Service to support internationalisation at some point, so I've had a go at doing this. I'll say more in reply to your other email. > One question I have: before, warnings would be emitted as we go; now, we > first collect all the warnings for a given package, and emit all of them > at once. How does it look in terms of UX? Not quite, warnings are emitted once returned from each checker for each package. The display will only be delayed if a checker takes a long time to return the warnings, which I don't think happens (or at least happens much). --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl0GPWBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdENBAAhWupmqSN5YSvpDqC9pcasK935jX60J7uUgWx1qiMVvti1viiD54bhHDP UwsDTfWDL1TYHPZzpoCMoCn0GZXWDR7fD5KclU4e7FlRgwxfsR7TKLc58i0LRYV4 Cxpf5+Jof5kNIiJTI1wHpK5s+aj1ZBzqj4G8PMbYAt8QM/f6BwCqCu3WSvOSsunm nHvhrIz7S5J1rvNKyGeyVZL24aogr3cmNFLyZLJCuvC8PsPyv7B6PCqB6aroA9cY Jjfppffz06PfMgoudZI+c8UDRm2X8kGtu5f6dgq5KQCkwjeouaFEGNi+fjCXP6u4 YYVNwUQDuVEx4Rtve+uZGXa5rZqJEL5B9N+7pCClBN9yixBRf11zqV+7VzZDoby2 FqQSFMoQVlBeXtsP7C/vjXstPPNH1yXMyoLSeH2Gnp/4juLttP4crszQFl/DUjjy VDnur6f3K4sM+QhUjciuG3pZ2SRRUXDGTpy7KWcYZVLjG2AgeX2Y7sGBmGKpWYPd KozFfFr0zANCELfwOYOwu/Ig6ItZMvPY0SobmnTEsJ2bPegw9kKDU+zyHK0IlpEG lRSfZSqxq/rWiqLra02v3utGi22GqDszT3ELe2JhrdJgsMrpR+AdqR+uLsgtI6sx MLkbsHdhUFsZlErFTMfvhfuiuSJSKS2XIWmUWjK8q07DBk4lyq0= =cG/F -----END PGP SIGNATURE----- --=-=-=--